feat: Implement warning modal component with multiple alert states - #833
Open
barani-2502 wants to merge 4 commits into
Open
feat: Implement warning modal component with multiple alert states#833barani-2502 wants to merge 4 commits into
barani-2502 wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new warning modal component and a corresponding demo page for the Sentinel module. The modal is built using Alpine.js and supports warning, danger, and info alert types with specific icons and styling. Review feedback focuses on correcting grammatical errors in the default messages, removing an unused 'icon' property from the component state, improving the robustness of the show method with a default parameter, and enhancing accessibility by adding support for the Escape key to close the modal.
|
barani-2502
force-pushed
the
warning_widget
branch
2 times, most recently
from
April 28, 2026 07:02
a0c4bf7 to
3aef285
Compare
barani-2502
force-pushed
the
session_monitor
branch
3 times, most recently
from
May 19, 2026 07:42
0259c4e to
e8ce46b
Compare
barani-2502
force-pushed
the
warning_widget
branch
from
May 19, 2026 08:25
1e7aa1f to
8b885e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new reusable warning modal component for the sentinel system to handle user-facing alerts during proctoring sessions.