build: upgrade dependencies - #7
Conversation
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
WalkthroughThe updates focus on dependency and version management for the Android project. The TPStreamsAndroidPlayer library version is incremented, and the Kotlin version is updated across relevant configuration files. The Kotlin Gradle plugin dependency is also modified to reference the centralized Kotlin version variable for consistency. Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
android/build.gradle (2)
80-86: Consider externalising TPStreamsAndroidPlayer versionHard-coding
1.0.2makes the next bump manual in multiple places. Placing it alongside the other version constants ingradle.properties(e.g.Tpstreams_tpPlayerVersion) keeps version management single-sourced and avoids accidental drift between example & library modules.-implementation 'com.github.testpress:TPStreamsAndroidPlayer:1.0.2' +def tpPlayerVersion = getExtOrDefault("tpPlayerVersion") +implementation "com.github.testpress:TPStreamsAndroidPlayer:$tpPlayerVersion"Remember to add
Tpstreams_tpPlayerVersion=1.0.2togradle.properties.
14-16: Now that plugin & stdlib share the same property, drop the “DifferentKotlinGradleVersion” suppressionThe lint warning was relevant when the Gradle plugin version was pinned differently. With
${getExtOrDefault('kotlinVersion')}driving both, the suppression can be removed to keep the build file tidy.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
android/build.gradle(1 hunks)android/gradle.properties(1 hunks)example/android/build.gradle(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build-android
- GitHub Check: build-ios
🔇 Additional comments (2)
android/gradle.properties (1)
1-1: Verify Kotlin 2.2.0–AGP 8.7.2 compatibility before mergingJumping two minor releases is generally safe, but Kotlin 2.2.0 is still very fresh and AGP 8.7.2 is likewise on the bleeding edge. Please run a full CI build (including unit tests and ProGuard/R8 if applicable) to surface any compiler / byte-code incompatibilities or IDE lint regressions before tagging a release.
#!/bin/bash # Quick sanity-check: look for compile / lint errors related to Kotlin 2.2.0. # We only scan Gradle output logs produced by CI (assuming they live under build/). fd -e log 'gradle' build | xargs grep -i -e 'Unsupported Kotlin version' -e 'deprecated' -e 'error'example/android/build.gradle (1)
8-18: 👍 Kotlin version hook-up looks goodThe example module now re-uses the
kotlinVersionproperty, ensuring the Gradle plugin and stdlib stay in lock-step with the library module. No further action required here.
Summary by CodeRabbit