Skip to content

Fix some Shellecheck issues - #3149

Merged
drwetter merged 1 commit into
testssl:3.3devfrom
dcooper16:fix_shellcheck_issues
Sep 18, 2026
Merged

drwetter merged 1 commit into
testssl:3.3devfrom
dcooper16:fix_shellcheck_issues

Conversation

@dcooper16

Copy link
Copy Markdown
Collaborator

Fix Shellcheck issues SC2171, SC2236, SC2269, SC2320, SC2321, and SC2322.

What is your pull request about?

  • Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change: bug fix, feature or improvement that would cause existing output (especially JSON, CSV) to not work as expected before
  • Typo / spelling fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • I've read CONTRIBUTING.md
  • My code follows Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order of last name) and the change to CHANGELOG.md

AI section

  • I found a bug / an improvement using LLM version: [e.g. GPT-A.B, Claude <NAME> A.B, Gemini A.B <NAME>, Qwen<B>-Coder, DeepSeek-<A> etc.]
  • My contribution does not include any AI-generated content
  • My contribution includes AI-generated content, as disclosed below:
    • AI Tools: [e.g. GitHub CoPilot, JetBrains Junie, VS Code plugin <NAME> etc.]
    • LLMs and versions: [e.g. GPT-A.B, Claude <NAME> A.B, Gemini A.B <NAME>, Qwen<B>-Coder, DeepSeek-<A> etc.]

Fix Shellcheck issues SC2171, SC2236, SC2269, SC2320, SC2321, and SC2322.
@dcooper16
dcooper16 force-pushed the fix_shellcheck_issues branch from f16e66d to 3cf9b65 Compare September 18, 2026 00:52
@drwetter
drwetter merged commit a080c03 into testssl:3.3dev Sep 18, 2026
4 checks passed
@drwetter

Copy link
Copy Markdown
Collaborator

Good point! Thank you, David!

If we believe that could be security relevant (user determined input and the payload would fly someplace else) that should be backported.

@dcooper16
dcooper16 deleted the fix_shellcheck_issues branch September 18, 2026 19:02
dcooper16 added a commit to dcooper16/testssl.sh that referenced this pull request Sep 18, 2026
This commit backports the fixes from testssl#3149 to the 3.2 branch.
@dcooper16 dcooper16 mentioned this pull request Sep 19, 2026
17 tasks
@dcooper16

Copy link
Copy Markdown
Collaborator Author

If we believe that could be security relevant (user determined input and the payload would fly someplace else) that should be backported.

I don't know if there could be any security issues, but I went ahead and backported it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants