Load from the composer autoload

[marc-jan]

I created an extra method createFromComposerAutoload to load the ClassNameMapper with data of the composer autoloader.

If you use the createFromComposerFile method you only get the specific information of your custom added autoloading. With the new loading option you can also get information of namespaces in vendor packages.

I hope you like it.

[coveralls]

Coverage increased (+0.8%) to 73.016% when pulling ded017c on gek-van-software:autoload into fa32a0e on thecodingmachine:1.0.

[fezfez]

+1 i need this for cause i publish shared package that use location of class (https://github.com/thecodingmachine/graphqlite). (ci fail not related)

[fezfez]

@moufmouf : can you check this ?

[marc-jan]

@moufmouf Can you please check this? Same as @fezfez I'm creating shared composer packages where I plugin a package to graphqlite.

[moufmouf]

Hey guys! I'm absolutely sorry, I don't know how I missed this PR. I'm having a look at it right now!

[moufmouf]

Ok, I was worried that the new code might break when Composer 2 is released.
Looking at the code base for Composer 2, so far, the autoloader has the same methods in Composer 2:
https://github.com/composer/composer/blob/2.0/src/Composer/Autoload/ClassLoader.php

So this PR looks great!

[moufmouf]

I did a few more tests and this PR still needs some work I think.

In particular, it will fail if the composer autoloader is generated with an authoritative classmap:

composer dumpautoload --classmap-authoritative

In this case, every reference to PSR-0 or PSR-4 is stripped from the Composer autoloader. I'm sure we kind find a workaround around this, but this is still to be developed.

[marc-jan]

@moufmouf Good one. I will have a look at it.

[marc-jan]

@moufmouf Also did some tests with --classmap-authoritative enabled and disabled in several projects and I'm always getting good/same results. Am I missing something?

[moufmouf]

Hey @marc-jangvs ,

Thanks a lot for your reactivity.

Ok. I'm not 100% sure that classmap-authoritative is having an impact.

Actually, I'm having trouble making this work. The Composer autoloader seems to behave in a weird way.

I changed your unit test to load the "real" autoloader from Composer (rather than the test autoloader you wrote).

ee76481

This should work, but it fails. Having a look at what is going on, I realize that (in my case), the $loader->getPrefixesPsr4() method returns only the Psr4 namespaces from dependencies (and not from composer.json).

Did you manage to have this working for dependencies AND for project files?

[marc-jan]

@moufmouf Hm that is strange. I'm using it in combination with the GraphqLite package and for example I have a simple PingController in a generic package inside vendor. Also I have some controllers inside my project that I configured inside my composer.json in the autoload section with:

{ "autoload": { "psr-4": { "App\\": "src/App/src/" } } }

$loader->getPrefixesPsr4() returns both namespaces with or without --classmap-authoritative.

Didn't do anything else to make it work.

[fezfez]

Any news on this?