Uh oh!
There was an error while loading. Please reload this page.
Fix process stderr tests broken by Node ExperimentalWarning - #202
Conversation
The stderr assertions used exact matching which broke when Node's type stripping experimental warning appeared in stderr output. Use toContain instead so tests tolerate runtime diagnostic messages.
📝 WalkthroughWalkthroughUpdates test assertions in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The warning pollutes stderr in child processes, breaking tests that assert on stderr content. Since type stripping is intentionally enabled, suppress the warning via --disable-warning=ExperimentalWarning.
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.env:
- Line 1: The NODE_OPTIONS value in the .env file contains spaces and should be
quoted for dotenv compatibility; update the NODE_OPTIONS entry so the entire
value is wrapped in quotes (e.g., set NODE_OPTIONS="--experimental-strip-types
--disable-warning=ExperimentalWarning --conditions=development") to satisfy
dotenv-linter and avoid parser/tooling issues.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
.joinand.expect) fail because Node's type strippingExperimentalWarningappears in stderr outputtoEqual("boom\n")) which doesn't tolerate runtime diagnostic messagestoContainso they pass regardless of Node warningsTest plan
Summary by CodeRabbit
Tests
Chores