🐛 Avoid aborting settled fetches

[taras]

Motivation

Node's native fetch can raise a late Undici exception when Effection tears down a scope and aborts a request whose fetch promise has already settled. This is reproducible with a data: URL and can surface after the owning operation has completed.

Closes#232.

Approach

• Track settlement of the native fetch promise.
• Abort through a local controller only while that promise is still pending.
• Preserve cancellation when an in-flight fetch operation is halted.
• Document the settlement-aware lifecycle and bump @effectionx/fetch to 0.2.1.
• Add a real Node data: regression test plus deterministic in-flight cancellation coverage.

The lifecycle boundary is the native fetch promise's settlement: once it produces a Response (or rejects), later scope teardown does not abort it.

Verification

• pnpm test — 384 passed, 6 skipped
• pnpm check
• pnpm lint
• pnpm fmt:check
• pnpm build
• pnpm sync

Summary by CodeRabbit

• Bug Fixes

  • Completed fetch requests now remain intact when their Effection scope exits.
  • In-flight fetch requests are automatically aborted when their scope is cancelled or exits.

• Documentation

  • Clarified fetch cancellation behavior and lifecycle expectations.

• Chores

  • Updated the fetch package version to 0.2.1.

[coderabbitai]

📝 Walkthrough

Walkthrough

FetchApi.fetch now tracks native request settlement and aborts only in-flight requests during Effection scope cleanup. Tests cover both lifecycle states. Documentation describes the behavior, and the package version changes to 0.2.1.

Changes

Fetch cancellation lifecycle

Layer / File(s)	Summary
Conditional fetch cancellation fetch/api.ts	FetchApi.fetch uses a local AbortController. Effection cleanup aborts the controller only while the native fetch remains unsettled.
Lifecycle validation and release updates fetch/fetch.test.ts, fetch/fetch.ts, fetch/README.md, fetch/package.json	Tests cover settled and in-flight fetches. Documentation describes scope-based cancellation. The package version changes to 0.2.1.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
participant EffectionScope
participant FetchApi
participant NativeFetch
EffectionScope->>FetchApi: start fetch operation
FetchApi->>NativeFetch: fetch(input, signal)
NativeFetch-->>FetchApi: settle response or rejection
FetchApi->>FetchApi: mark request settled
EffectionScope->>FetchApi: run cleanup
FetchApi->>NativeFetch: abort if request is unsettled

Loading

Possibly related PRs

• thefrontside/effectionx#150: Both changes modify fetch cancellation behavior.
• thefrontside/effectionx#158: Both changes modify fetch lifecycle handling and related tests.

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary change: preventing aborts after fetch promises settle.
Description check	✅ Passed	The description includes the required Motivation and Approach sections and provides clear implementation and verification details.
Linked Issues check	✅ Passed	The implementation and tests satisfy issue #232 by preserving in-flight cancellation and avoiding aborts after native fetch settlement.
Out of Scope Changes check	✅ Passed	The documentation, regression tests, and package version update directly support the linked issue and stated pull request objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Policy Compliance	✅ Passed	Changed package metadata is valid, version 0.2.0→0.2.1 is a patch bump, cleanup uses ensure without async finally, tests are deterministic, and commits contain no AI marketing.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch agent/fetch-settlement-abort

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@effectionx/fetch@234

commit: 00f4eee

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@fetch/fetch.test.ts`:
- Around line 203-259: Migrate the tests in the cancellation describe block of
fetch/fetch.test.ts to the Node.js test runner, replacing `@effectionx/vitest`
usage with the corresponding test APIs from `@effectionx/bdd`. Update imports and
test declarations to use the required bdd helpers while preserving both
cancellation assertions and existing test behavior.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 67b42de5-5555-4a86-8925-5b1801d0aa25

📥 Commits

Reviewing files that changed from the base of the PR and between d1ecfeb and 00f4eee.

📒 Files selected for processing (5)

• fetch/README.md
• fetch/api.ts
• fetch/fetch.test.ts
• fetch/fetch.ts
• fetch/package.json