Skip to content

Add google cloud datastore implementation - #136

Open
amuhra wants to merge 4 commits into
thenativeweb:masterfrom
amuhra:master
Open

Add google cloud datastore implementation#136
amuhra wants to merge 4 commits into
thenativeweb:masterfrom
amuhra:master

Conversation

@amuhra

Copy link
Copy Markdown

Hi, I just added google cloud datastore implementation for my own usage, just thought that you might want to merge it in your main repository.

Feedbacks are welcome.

ADD google cloud datastore index definition [mandatory for test]
@adrai

Copy link
Copy Markdown
Contributor

Can index.yaml be moved somewhere else? i.e. test directory?

@amuhra

Copy link
Copy Markdown
Author

yes, it can
should I move it ?

@adrai

Copy link
Copy Markdown
Contributor

yes

@amuhra

Copy link
Copy Markdown
Author

already move the file to test folder

@adrai

Copy link
Copy Markdown
Contributor

Can you also extend the readme?

@adrai

Copy link
Copy Markdown
Contributor

btw: Can you please use the use function Store.use instead of require (like the other db implementations)?

update README to cover "cloud datastore"
@amuhra

Copy link
Copy Markdown
Author

done

@adrai

Copy link
Copy Markdown
Contributor

Is the datastore “testable” via travis or should we skip it in the tests?

@amuhra

Copy link
Copy Markdown
Author

I think so, but I haven't got lucky with cloud datastore emulator in the past few days

@adrai

Copy link
Copy Markdown
Contributor

ok, then perhaps it would be better to skip it here and here

@kojuka

Copy link
Copy Markdown

@amura2406 any updates to this? I'd also like to use cloud datastore.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@amuhra@adrai@kojuka