Skip to content

ASoC: SOF: ipc: Log unexpected DSP replies as debug messages instead of error#1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ranj063 wants to merge 1 commit into from
Closed

ASoC: SOF: ipc: Log unexpected DSP replies as debug messages instead of error #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions sound/soc/sof/ipc.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -308,21 +308,20 @@ int sof_ipc_tx_message(struct snd_sof_ipc *ipc, u32 header,
EXPORT_SYMBOL(sof_ipc_tx_message);

/* handle reply message from DSP */
int snd_sof_ipc_reply(struct snd_sof_dev *sdev, u32 msg_id)
void snd_sof_ipc_reply(struct snd_sof_dev *sdev, u32 msg_id)
{
struct snd_sof_ipc_msg *msg = &sdev->ipc->msg;

if (msg->ipc_complete) {
dev_err(sdev->dev, "error: no reply expected, received 0x%x",
dev_dbg(sdev->dev,
"no reply expected, received 0x%x, will be ignored",
msg_id);
return -EINVAL;
return;

@plbossartplbossartDec 2, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you clarify what you are trying to fix?
Is this that the error level is too high?
This doesn't change any functionality so why change?

@ranj063ranj063Dec 2, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart yes it isnt really an error. We see this every time the FW boots when the DSP resumes and it is misleading

@ranj063ranj063Dec 2, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then let's describe what the change really is in the commit message...

@plbossart i've updated the commit message now. Is this better?

@plbossartplbossartDec 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranj063 I find the updated commit still confusing, specifically this part "In fact, the host just ignores this message
and returns an error in such cases. But, the error message could be
misleading when trying to debug other issues."

It's odd to mention an 'error in such cases' when it's removed here? Something's not quite right.

}

/* wake up and return the error if we have waiters on this message ? */
msg->ipc_complete = true;
wake_up(&msg->waitq);

return 0;
}
EXPORT_SYMBOL(snd_sof_ipc_reply);

Expand Down
2 changes: 1 addition & 1 deletion sound/soc/sof/sof-priv.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -432,7 +432,7 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset);
*/
struct snd_sof_ipc *snd_sof_ipc_init(struct snd_sof_dev *sdev);
void snd_sof_ipc_free(struct snd_sof_dev *sdev);
int snd_sof_ipc_reply(struct snd_sof_dev *sdev, u32 msg_id);
void snd_sof_ipc_reply(struct snd_sof_dev *sdev, u32 msg_id);
void snd_sof_ipc_msgs_rx(struct snd_sof_dev *sdev);
int snd_sof_ipc_stream_pcm_params(struct snd_sof_dev *sdev,
struct sof_ipc_pcm_params *params);
Expand Down