Skip to content

ASoC: SOF: set up memory windows only at first boot#185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Oct 15, 2018
Merged

ASoC: SOF: set up memory windows only at first boot #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sound/soc/sof/intel/hda-ipc.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -389,7 +389,8 @@ int hda_dsp_ipc_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
snd_sof_fw_parse_ext_data(sdev, HDA_DSP_MBOX_UPLINK_OFFSET +
sizeof(struct sof_ipc_fw_ready));

ipc_get_windows(sdev);
if (sdev->first_boot)

@xiulipanxiulipanOct 12, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this change is also needed for other paltforms? Like BYT?
Maybe we should make it align here.

@ranj063ranj063Oct 12, 2018

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiulipan agreed but we have not implemented the suspend/resume hooks for BYT yet. Maybe we could include this after we do that?

@xiulipanxiulipanOct 15, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranj063
I suggest to make alignment on all platforms. We may forget about this change as there will be patch squash.

@ranj063ranj063Oct 15, 2018

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiulipan alright let me make the change

@xiulipanxiulipanOct 16, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranj063
Good

ipc_get_windows(sdev);

return 0;
}
2 changes: 2 additions & 0 deletions sound/soc/sof/loader.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -269,6 +269,8 @@ int snd_sof_load_firmware(struct snd_sof_dev *sdev,
{
dev_dbg(sdev->dev, "loading firmware\n");

sdev->first_boot = first_boot;

if (sdev->ops->load_firmware)
return sdev->ops->load_firmware(sdev, first_boot);
return 0;
Expand Down
1 change: 1 addition & 0 deletions sound/soc/sof/sof-priv.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -369,6 +369,7 @@ struct snd_sof_dev {

/* PM */
bool restore_kcontrols; /* restore kcontrols upon resume */
bool first_boot;

void *private; /* core does not touch this */
};
Expand Down