Skip to content

ASoC: SOF: add debug ABI version - #1947

Merged
lgirdwood merged 1 commit into
thesofproject:topic/sof-devfrom
xiulipan:pr/ABI315
Mar 31, 2020
Merged

ASoC: SOF: add debug ABI version#1947
lgirdwood merged 1 commit into
thesofproject:topic/sof-devfrom
xiulipan:pr/ABI315

Conversation

@xiulipan

@xiulipanxiulipan commented Mar 28, 2020•
edited
Loading

Copy link
Copy Markdown

Add new debug ABI version to be increased when changing user space debug
interfaces while the the main FW ABI is not affected.

The abi_dbg_version share same defination with SOF_ABI_VER

This change main ABI to 3.14.0

@xiulipanxiulipan mentioned this pull request Mar 28, 2020
Merged
@ranj063

ranj063 commented Mar 28, 2020

Copy link
Copy Markdown
Collaborator

@xiulipan the first pacth is also in the previous pull request. Anyway, a single PR is good for both I think. The patches themselves look good but what's missing is the part where these ext data types are parsed.

@plbossart

plbossart commented Mar 28, 2020

Copy link
Copy Markdown
Member

@xiulipan the first pacth is also in the previous pull request. Anyway, a single PR is good for both I think. The patches themselves look good but what's missing is the part where these ext data types are parsed.

@lgirdwood was asking for separate PRs to help track changes with the ABI tool?

@ranj063

ranj063 commented Mar 28, 2020

Copy link
Copy Markdown
Collaborator

@xiulipan the first pacth is also in the previous pull request. Anyway, a single PR is good for both I think. The patches themselves look good but what's missing is the part where these ext data types are parsed.

@lgirdwood was asking for separate PRs to help track changes with the ABI tool?

oh I missed that memo possibly.

@mengdonglinmengdonglin added the ABI involves ABI changes, need extra attention label Mar 30, 2020
kv2019i
kv2019i requested changes Mar 30, 2020
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiulipan We need to stick to ABI classifier versions in the split PRs.
@lgirdwood This is getting quite complicated now....

Comment threadinclude/uapi/sound/sof/abi.h Outdated
lyakh
lyakh reviewed Mar 30, 2020
View reviewed changes
Comment threadinclude/sound/sof/info.h
struct sof_ipc_user_abi_version {
struct sof_ipc_ext_data_hdr ext_hdr;

uint32_t abi_dbg_version;

@lyakhlyakhMar 30, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering whether we aren't overcomplicating things and whether we shouldn't stick to just one ABI version

@kv2019ikv2019iMar 30, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh No idea of the usage model of this, but this discussion needs to happen on the FW side PR as the people involved are not reading this.

@xiulipanxiulipan mentioned this pull request Mar 31, 2020
Merged
@xiulipan

xiulipan commented Mar 31, 2020

Copy link
Copy Markdown
Author

@lgirdwood Ping here from thesofproject/sof#2522

@xiulipan
ASoC: SOF: add debug ABI version
8d330f1
Add new debug ABI version to be increased when changing user space debug
interfaces while the the main FW ABI is not affected.
The abi_dbg_version share same defination with SOF_ABI_VER
This change main ABI to 3.14.0
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipan

xiulipan commented Mar 31, 2020

Copy link
Copy Markdown
Author

@kv2019i@lgirdwood Rebased and updated to ABI 14

@kv2019i
kv2019i requested review from kv2019i and lyakhMarch 31, 2020 11:25
kv2019i
kv2019i approved these changes Mar 31, 2020
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiulipan ! I'll give reviewers a bit of time, wait for CI to complete and will then merge.

@lgirdwood

lgirdwood commented Mar 31, 2020

Copy link
Copy Markdown
Member

Travis build failure related to cpu_dai not being initialised in topology, checkpatch about types.

@lgirdwood

lgirdwood commented Mar 31, 2020

Copy link
Copy Markdown
Member

Jenkins showing IPC timeout on one APL variant, looks like a non 100% reproducible issue.

@lgirdwood
lgirdwood merged commit 95a9868 into thesofproject:topic/sof-devMar 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@kv2019ikv2019ikv2019i approved these changes
@dbalutadbalutaAwaiting requested review from dbaluta
@juimonenjuimonenAwaiting requested review from juimonen
@keyonjiekeyonjieAwaiting requested review from keyonjie
@ranj063ranj063Awaiting requested review from ranj063ranj063 is a code owner
@plbossartplbossartAwaiting requested review from plbossart
@lyakhlyakhAwaiting requested review from lyakhlyakh is a code owner

Assignees

No one assigned

Labels

ABIinvolves ABI changes, need extra attention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@xiulipan@ranj063@plbossart@lgirdwood@lyakh@kv2019i@mengdonglin