Skip to content

ASoC: intel: sof_sdw: init all aggregated codecs - #1962

Merged
kv2019i merged 1 commit into
thesofproject:topic/sof-devfrom
bardliao:rt1308_init
Apr 3, 2020
Merged

ASoC: intel: sof_sdw: init all aggregated codecs#1962
kv2019i merged 1 commit into
thesofproject:topic/sof-devfrom
bardliao:rt1308_init

Conversation

@bardliao

@bardliaobardliao commented Mar 31, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

Init codecs which belong to the same group id on all links.

Signed-off-by: Bard Liao yung-chuan.liao@linux.intel.com

Fixes#1953

RanderWang
RanderWang previously approved these changes Mar 31, 2020
View reviewed changes

@RanderWangRanderWang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

plbossart
plbossart previously approved these changes Mar 31, 2020
View reviewed changes

@plbossartplbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine @bardliao but I don't know how things worked before? Is this required now that we have the NO_AGGREGATION removed?

@bardliao

bardliao commented Mar 31, 2020

Copy link
Copy Markdown
CollaboratorAuthor

The code looks fine @bardliao but I don't know how things worked before? Is this required now that we have the NO_AGGREGATION removed?

Yes, NO_AGGREGATION flag will hide the issue.

@RanderWang

RanderWang commented Apr 1, 2020•
edited
Loading

Copy link
Copy Markdown

The code looks fine @bardliao but I don't know how things worked before? Is this required now that we have the NO_AGGREGATION removed?

yes, without aggregation we only need to init codec on current link for current BE DAI.

ranj063
ranj063 reviewed Apr 1, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_sdw.c
@bardliao
bardliao dismissed stale reviews from plbossart and RanderWang via dff3515April 1, 2020 05:33
ranj063
ranj063 previously approved these changes Apr 1, 2020
View reviewed changes
lyakh
lyakh reviewed Apr 1, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_sdw.c

part_id = SDW_PART_ID(link->adr_d[i].adr);
codec_index = find_codec_info_part(part_id);
do {

@lyakhlyakhApr 1, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to figure out why we need to loop here. It looks like now with aggregation the loop over links in sof_card_dai_links_create() only calls create_sdw_dailink() for the first link in each group. That's why you now have to walk over all links, looking for others from the same group. Maybe you could add a comment about that for the next reader :-)

lyakh
lyakh previously approved these changes Apr 1, 2020
View reviewed changes
kv2019i
kv2019i requested changes Apr 1, 2020
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardliao Functionality looks good, but I think some commentary is needed to keep the code maintainable.

Comment threadsound/soc/intel/boards/sof_sdw.c
@plbossart

plbossart commented Apr 1, 2020

Copy link
Copy Markdown
Member

@bardliao please add comments to explain that the loop is done once and group_id > 0 means aggregation. You and I know this, but others may not.

@bardliao
bardliao dismissed stale reviews from lyakh and ranj063 via 0a5dd8cApril 2, 2020 01:10
@bardliao
bardliao requested review from kv2019i and lyakhApril 2, 2020 01:11
kv2019i
kv2019i requested changes Apr 2, 2020
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some iteration on code comments needed.

Comment threadsound/soc/intel/boards/sof_sdw.c
@bardliao
ASoC: intel: sof_sdw: init all aggregated codecs
9f6eeb4
Init codecs which belong to the same group id on all links.
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
@kv2019i

kv2019i commented Apr 3, 2020

Copy link
Copy Markdown
Collaborator

Jenkins build stalled, CI errors are known or unrelated (GLK sof-logger error), merging.

@kv2019i
kv2019i merged commit 052e45d into thesofproject:topic/sof-devApr 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plbossartplbossartplbossart approved these changes
@lyakhlyakhlyakh approved these changes
@ranj063ranj063ranj063 approved these changes
@kv2019ikv2019ikv2019i approved these changes
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood is a code owner
@RanderWangRanderWangAwaiting requested review from RanderWang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG][CML]Aplay0,2 rt1308 right speaker have sound output when muted speaker in alsamixer.

6 participants

@bardliao@RanderWang@plbossart@kv2019i@lyakh@ranj063