Skip to content

ASoC: Intel: Boards: tgl_max98373: add dai_trigger function - #2123

Merged
plbossart merged 2 commits into
topic/sof-devfrom
sof_dev_15_05
Jun 1, 2020
Merged

ASoC: Intel: Boards: tgl_max98373: add dai_trigger function#2123
plbossart merged 2 commits into
topic/sof-devfrom
sof_dev_15_05

Conversation

@RDharageswari

@RDharageswariRDharageswari commented May 15, 2020

Copy link
Copy Markdown

Speaker amplifier feedback is not modeled as being dependent on any
active output. Even when there is no playback happening, parts of the graph,
specifically the IV sense->speaker protection->output remains active and
this prevents the DSP from entering low-power states.

This patch suggest a machine driver level approach where the speaker
pins are enabled/disabled dynamically depending on stream start/stop
events. DPAM graph representations show the feedback loop is indeed
disabled and low-power states can be reached.

@RDharageswariRDharageswari mentioned this pull request May 15, 2020
Closed
RDharageswari
RDharageswari commented May 15, 2020
View reviewed changes

@RDharageswariRDharageswari left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing the errors

ranj063
ranj063 reviewed May 15, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_maxim_common.c Outdated
ranj063
ranj063 reviewed May 16, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_maxim_common.c Outdated
ranj063
ranj063 reviewed May 16, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_maxim_common.c Outdated
ranj063
ranj063 reviewed May 16, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_rt5682.c Outdated
@RDharageswari
RDharageswariforce-pushed the sof_dev_15_05 branch 2 times, most recently from fbccb2b to 43bdcd2CompareMay 16, 2020 00:22
ranj063
ranj063 reviewed May 16, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_maxim_common.c Outdated
plbossart
plbossart requested changes May 16, 2020
View reviewed changes

@plbossartplbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start but this needs more work.

Comment threadsound/soc/intel/boards/sof_maxim_common.c Outdated
Comment threadsound/soc/intel/boards/sof_rt5682.c Outdated
Comment threadsound/soc/intel/boards/sof_maxim_common.c
ranj063
ranj063 reviewed May 27, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_maxim_common.c Outdated
ranj063
ranj063 reviewed May 27, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_maxim_common.c Outdated
case SNDRV_PCM_TRIGGER_STOP:
case SNDRV_PCM_TRIGGER_SUSPEND:
case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
val = snd_soc_dai_active(codec_dai);

@ranj063ranj063May 27, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont seem to use val at all?

@RDharageswariRDharageswariMay 27, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ranj063
ranj063 reviewed May 27, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_maxim_common.c
@RDharageswari
RDharageswariforce-pushed the sof_dev_15_05 branch 2 times, most recently from 73f1579 to c2759d5CompareMay 28, 2020 00:34
ranj063
ranj063 reviewed May 28, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/sof_maxim_common.c
ranj063
ranj063 previously approved these changes May 28, 2020
View reviewed changes

@ranj063ranj063 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @RDharageswari

plbossart
plbossart previously approved these changes May 28, 2020
View reviewed changes

@plbossartplbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ever want to work with a single amplifier the code will need to be updated, see below. It's not hypothetical, see ASoC: Intel: sof_da7219_max98373: Add support for max98360a speaker amp

Comment threadsound/soc/intel/boards/sof_maxim_common.c
Dharageswari RDharageswari R
ASoC: Intel: Boards: tgl_max98373: add dai_trigger function
8947163
Speaker amplifier feedback is not modeled as being dependent on any
active output. Even when there is no playback happening, parts of the
graph, specifically the IV sense->speaker protection->output remains
active and this prevents the DSP from entering low-power states.
This patch suggests a machine driver level approach where the speaker
pins are enabled/disabled dynamically depending on stream start/stop
events. DPAM graph representations show the feedback loop is indeed
disabled and low-power states can be reached.
Signed-off-by: Dharageswari R <dharageswari.r@intel.com>
@RDharageswari
RDharageswari dismissed stale reviews from plbossart and ranj063 via 8947163May 29, 2020 19:52
ranj063
ranj063 previously approved these changes May 29, 2020
View reviewed changes
Dharageswari RDharageswari R
ASoC: Intel: Boards: tgl_max98373: Fix the comment for max_98373_comp…
24e5b26
…onents
MAX_98373_DEV0_NAME is the Right speaker and MAX_98373_DEV1_NAME is the
Left speaker, hence updating the comments for max98373 dailink components
accordingly.
Signed-off-by: Dharageswari R <dharageswari.r@intel.com>
@plbossart
plbossart merged commit 16d98cd into topic/sof-devJun 1, 2020
@RanderWangRanderWang mentioned this pull request Jun 16, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plbossartplbossartplbossart approved these changes
@ranj063ranj063ranj063 approved these changes
@kv2019ikv2019ikv2019i approved these changes
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RDharageswari@plbossart@ranj063@kv2019i