Uh oh!
There was an error while loading. Please reload this page.
ASoC: intel: cml_rt1011_rt5682: find dai link with dai link name - #2174
ASoC: intel: cml_rt1011_rt5682: find dai link with dai link name#2174bardliao wants to merge 2 commits into
Conversation
plbossart
left a comment
There was a problem hiding this comment.
Looks good @bardliao but the commit message is far from clear. Should be something like.
When the cml_rt1011_rt5682_dailink[].codecs pointer is overridden by a quirk with a devm allocated structure and the probe is deferred, in the next probe we will see an use-after-free condition. This can be avoided by changing a test condition so that we don't test an invalid value.
Also we need a Fixes: tag, this should go to linux-stable.
component in previous probe. The component could be freed.
So find dai link with codec dai_name is not reliable.
When the cml_rt1011_rt5682_dailink[].codecs pointer is overridden by a quirk with a devm allocated structure and the probe is deferred, in the next probe we will see an use-after-free condition. This can be avoided by changing a test condition so that we don't test an invalid value. Fixes: 629ba12 (ASoC: Intel: boards: split woofer and tweeter support) Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
for_each_card_prelinks() is a common API to walk through each prelink in the card. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
commented
Jun 9, 2020
change log: change commit message only, not touching the code itself |
ranj063
commented
Jun 9, 2020
@bardliao can we close this now? |
We assign cml_rt1011_rt5682_dailink[].codecs to a devm allocated
component in previous probe. The component could be freed.
So find dai link with codec dai_name is not reliable.
Signed-off-by: Bard Liao yung-chuan.liao@linux.intel.com
Fixes: #2168