Skip to content

ASoc: Intel: cml_rt1011_rt5682: explicitly access first codec - #2181

Merged
bardliao merged 2 commits into
thesofproject:topic/sof-devfrom
fredoh9:fix/cml_codec_array
Jun 12, 2020
Merged

ASoc: Intel: cml_rt1011_rt5682: explicitly access first codec#2181
bardliao merged 2 commits into
thesofproject:topic/sof-devfrom
fredoh9:fix/cml_codec_array

Conversation

@fredoh9

@fredoh9fredoh9 commented Jun 9, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

cml_rt1011_rt5682_dailink[i].codecs is pointer to a codec array.
Explicitly access first codec's dai_name.

This is Initiated from @bardliao while reviewing #2173.

@fredoh9
fredoh9 requested a review from bardliaoJune 9, 2020 23:16
plbossart
plbossart reviewed Jun 10, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/cml_rt1011_rt5682.c Outdated
@fredoh9
fredoh9force-pushed the fix/cml_codec_array branch from 283ad1f to b3fae7aCompareJune 10, 2020 01:48
ranj063
ranj063 reviewed Jun 10, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/cml_rt1011_rt5682.c Outdated
lyakh
lyakh requested changes Jun 10, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/cml_rt1011_rt5682.c Outdated
@fredoh9
fredoh9force-pushed the fix/cml_codec_array branch from b3fae7a to c2cfc30CompareJune 10, 2020 16:10
bardliao
bardliao reviewed Jun 11, 2020
View reviewed changes
Comment threadsound/soc/intel/boards/cml_rt1011_rt5682.c Outdated
@fredoh9
fixup! ASoC: intel: cml_rt1011_rt5682: use for_each_card_prelinks
c049bfe
@fredoh9
ASoc: Intel: cml_rt1011_rt5682: explicitly access first codec
13f8551
dailink.codecs is pointer to a codec array. Explicitly access
first codec's dai_name.
Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
@fredoh9
fredoh9force-pushed the fix/cml_codec_array branch from c2cfc30 to 13f8551CompareJune 11, 2020 16:29
@plbossart

plbossart commented Jun 11, 2020

Copy link
Copy Markdown
Member

@fredoh9 same CI failure on ICL RVP
2020-06-11 16:47:24 UTC [REMOTE_INFO] dsp is not suspended after 15s, end test

something's wrong with this device, care to take a look? Thank you,

@plbossart
plbossart requested review from bardliao and lyakhJune 11, 2020 22:46
@fredoh9

fredoh9 commented Jun 12, 2020

Copy link
Copy Markdown
CollaboratorAuthor

@fredoh9 same CI failure on ICL RVP
2020-06-11 16:47:24 UTC [REMOTE_INFO] dsp is not suspended after 15s, end test

something's wrong with this device, care to take a look? Thank you,

Looks same failure is being started in ICL. We have 3 ICL RVPs in CI but found same error in two of them.

@bardliao
bardliao merged commit db39fed into thesofproject:topic/sof-devJun 12, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plbossartplbossartplbossart approved these changes
@lyakhlyakhlyakh approved these changes
@ranj063ranj063ranj063 approved these changes
@bardliaobardliaobardliao approved these changes
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@kv2019ikv2019iAwaiting requested review from kv2019ikv2019i is a code owner
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fredoh9@plbossart@lyakh@ranj063@bardliao