Uh oh!
There was an error while loading. Please reload this page.
ASoC:SOF: Add src_hash to sof_ipc_fw_version structure - #2292
Conversation
plbossart
commented
Jul 17, 2020
@ktrzcinx when you say 'value is used by sof-logger', did you mean that the value would be exposed in a debugfs value read by sof-logger? |
ktrzcinx
commented
Jul 20, 2020
@plbossart |
This field will be used to compare ldc file with loaded fw version, to assert validity of trace logs. Value used in sof-logger. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
fw_hash to sof_ipc_fw_version structuresrc_hash to sof_ipc_fw_version structurektrzcinx
commented
Aug 19, 2020
FW part has been merged already, so this PR also should keep going. |
ktrzcinx
commented
Aug 19, 2020
SOFCI TEST |
ktrzcinx
commented
Sep 2, 2020
plbossart
commented
Sep 2, 2020
@ktrzcinx I need more coffee but do we actually need this from the firmware, can't we get it from the extended manifest? |
ktrzcinx
commented
Sep 2, 2020
@plbossart actually not, because only fw_ready message is accessible from sof-logger point of view. Logger is default reader of this information, here it's only added to keep data structures aligned. |
plbossart
commented
Sep 2, 2020
ok, thanks for the clarification |
@kv2019i can you take a look (ABI, etc)? Thanks! |
kv2019i
commented
Sep 3, 2020
@plbossart Ack, I'm having some doubts on this -- kernel doesn't use this field, so why add it to the header. But given we don't annotate the changes to FW headers (I have an AR to fix that), keeping them in sync in other ways is problematic as well. Oh well, let's put this in. |
This field will be used to compare ldc file with loaded fw version,
to assert validity of trace logs. Value used in sof-logger.
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com
Related with thesofproject/sof#3195