Uh oh!
There was an error while loading. Please reload this page.
fixup! soundwire: Add generic bandwidth allocation algorithm - #2372
Conversation
Fix checkpath warning - EXPORT_SYMBOL(foo); should immediately follow its function/variable. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Fix checkpath warning - Reusing the krealloc arg is almost always a bug. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
commented
Aug 18, 2020
@plbossart Should 706c576 and 68e447d be squashed into 21f40a0? |
plbossart
commented
Aug 18, 2020
yes, makes sense @bardliao there's no reason to keep them separate. The main open is explanations of this algorithm |
plbossart
commented
Aug 18, 2020
Can you make sure the topic/sof-dev-rebase is updated with these squashed fixes, otherwise we are going to have conflicts during the next merge. |
bardliao
commented
Aug 18, 2020
Done |
Fix checkpath warning:
WARNING: Reusing the krealloc arg is almost always a bug
#365: FILE: drivers/soundwire/generic_bandwidth_allocation.c:207:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#589: FILE: drivers/soundwire/stream.c:31:
+EXPORT_SYMBOL(sdw_cols);