Skip to content

ASoC: SOF: Intel: hda: reduce verbosity of boot error logs - #2382

Merged
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
plbossart:fix/boot-error-logs
Aug 27, 2020
Merged

ASoC: SOF: Intel: hda: reduce verbosity of boot error logs#2382
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
plbossart:fix/boot-error-logs

Conversation

@plbossart

@plbossartplbossart commented Aug 24, 2020

Copy link
Copy Markdown
Member

Previous commits reduced the verbosity of errors during boot
iterations, but there are still a couple remaining.

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

@plbossart

plbossart commented Aug 24, 2020

Copy link
Copy Markdown
MemberAuthor

This should e.g. remove spurious CI errors on ICL RVP. @ranj063@fredoh9 FYI

@fredoh9fredoh9 mentioned this pull request Aug 25, 2020
Closed
ranj063
ranj063 reviewed Aug 25, 2020
View reviewed changes
Comment threadsound/soc/sof/intel/hda-loader.c Outdated
kv2019i
kv2019i reviewed Aug 25, 2020
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart@ranj063 It feels we are sinking deeper with more and more code to handle the ICL boot case. I did spend some time looking at better options, but came back empty handed, so with the off-by-one fixed, seems good to go.

Comment threadsound/soc/sof/intel/hda.c Outdated
Comment threadsound/soc/sof/intel/hda.c
@plbossart

plbossart commented Aug 25, 2020

Copy link
Copy Markdown
MemberAuthor

@kv2019i@ranj063@lyakh updated code, I am not too happy about the code but it makes CI happier so unless you have an alternate suggestion let's go with this?

@ranj063

ranj063 commented Aug 25, 2020

Copy link
Copy Markdown
Collaborator

@kv2019i@ranj063@lyakh updated code, I am not too happy about the code but it makes CI happier so unless you have an alternate suggestion let's go with this?

@plbossart did you forget to push? I dont see the updated code

@fredoh9fredoh9 mentioned this pull request Aug 25, 2020
Closed
ranj063
ranj063 previously approved these changes Aug 25, 2020
View reviewed changes
lyakh
lyakh previously approved these changes Aug 26, 2020
View reviewed changes

@lyakhlyakh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the proposed change is optional

Comment threadsound/soc/sof/intel/hda.c Outdated
@plbossart
plbossart dismissed stale reviews from lyakh and ranj063 via cbc4cccAugust 26, 2020 16:00
@plbossart
plbossart requested review from lyakh and ranj063August 26, 2020 20:49
ranj063
ranj063 previously approved these changes Aug 26, 2020
View reviewed changes

@ranj063ranj063 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @plbossart. I like the new macro. I think it will be useful in the future as well

@plbossart
ASoC: SOF: Intel: hda: reduce verbosity of boot error logs
f3a490d
Previous commits reduced the verbosity of errors during boot
iterations, but there are still a couple remaining which generate
false positives. Errors should only be logged when after last attempt
to download firmware failed.
Duplicating logs and assigning them different levels based on the
iteration number isn't really elegant, use macro as suggested by
Guennadi.
Suggested-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@ranj063

ranj063 commented Aug 26, 2020

Copy link
Copy Markdown
Collaborator

@plbossart are the checkpatch warnings about spaces before tabs legitimate?

@plbossart
plbossart requested a review from ranj063August 26, 2020 20:54
@plbossart

plbossart commented Aug 26, 2020

Copy link
Copy Markdown
MemberAuthor

sorry @ranj063 looks like I dismissed your review by pushing a tab/space fix.

@plbossartplbossart mentioned this pull request Aug 26, 2020
Merged
@plbossart

plbossart commented Aug 26, 2020

Copy link
Copy Markdown
MemberAuthor

i'll merge this tonight so that we can have a clean set of CI results - well until we find new issues.

@ranj063ranj063 mentioned this pull request Aug 26, 2020
Merged
lyakh
lyakh approved these changes Aug 27, 2020
View reviewed changes

@lyakhlyakh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that superfluous empty line is, well, not a deal-breaker I guess

Comment threadsound/soc/sof/intel/hda.c
dev_err(sdev->dev, "error: extended rom status:%s", msg);
sof_dev_dbg_or_err(sdev->dev, hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS,
"extended rom status: %s", msg);

@lyakhlyakhAug 27, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one empty line too many :-)

@plbossart
plbossart merged commit a85e834 into thesofproject:topic/sof-devAug 27, 2020
xiulipan added a commit to xiulipan/sof-test that referenced this pull request Aug 28, 2020
@xiulipan
tools: update the checklist and ignore list with boot time
75fd3b4
With thesofproject/linux#2382
no error logs will generate in boot time. Udpate the err list
and ignore list with this update.
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipanxiulipan mentioned this pull request Aug 28, 2020
Closed
@keyonjie

keyonjie commented Aug 31, 2020•
edited
Loading

Copy link
Copy Markdown

Sorry for late but with this change we even not throwing any warning message when boot failed on those first iterations?

@marc-hbmarc-hb mentioned this pull request Sep 9, 2020
Closed
@xiulipanxiulipan mentioned this pull request Nov 6, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakhlyakhlyakh approved these changes
@ranj063ranj063ranj063 approved these changes
@bardliaobardliaoAwaiting requested review from bardliaobardliao is a code owner
@keyonjiekeyonjieAwaiting requested review from keyonjie
@libinyanglibinyangAwaiting requested review from libinyang
@fredoh9fredoh9Awaiting requested review from fredoh9
@kv2019ikv2019iAwaiting requested review from kv2019i
@juimonenjuimonenAwaiting requested review from juimonen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@plbossart@ranj063@keyonjie@lyakh@kv2019i