Skip to content

enable multiple type controls for single widget - #2423

Merged
ranj063 merged 1 commit into
thesofproject:topic/sof-devfrom
juimonen:multi_control
May 3, 2021
Merged

enable multiple type controls for single widget#2423
ranj063 merged 1 commit into
thesofproject:topic/sof-devfrom
juimonen:multi_control

Conversation

@juimonen

Copy link
Copy Markdown

I was experimenting with beamformer with 2 controls (byte and enum) and
noticed this restriction: It seems that widget can have multiple controls but
they are inherently assumed to be of the same type. The alsa topology
documentation is a little bit hazy on this part...

The diff looks quite nasty and invasive, but it is only refactoring the kcontrol
creation/deletion to be based on type instead of just the topology chunk size.
Also it seems that these struct members I'm touching are not used too much
by anyone else than sof...

I tried this with eq by adding bytes and enum and it seemed to work.

Loading
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@juimonen@plbossart@bardliao@singalsu@lgirdwood@lyakh@kv2019i@fuyuntsuo@ranj063