Uh oh!
There was an error while loading. Please reload this page.
enable multiple type controls for single widget - #2423
Merged
Conversation
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experimenting with beamformer with 2 controls (byte and enum) and
noticed this restriction: It seems that widget can have multiple controls but
they are inherently assumed to be of the same type. The alsa topology
documentation is a little bit hazy on this part...
The diff looks quite nasty and invasive, but it is only refactoring the kcontrol
creation/deletion to be based on type instead of just the topology chunk size.
Also it seems that these struct members I'm touching are not used too much
by anyone else than sof...
I tried this with eq by adding bytes and enum and it seemed to work.