Skip to content

ASoC: Intel: hdac_hdmi: add Icelake support - #244

Closed
bardliao wants to merge 1 commit into
thesofproject:topic/sof-devfrom
bardliao:topic/sof-dev
Closed

ASoC: Intel: hdac_hdmi: add Icelake support#244
bardliao wants to merge 1 commit into
thesofproject:topic/sof-devfrom
bardliao:topic/sof-dev

Conversation

@bardliao

Copy link
Copy Markdown
Collaborator

Add Icelake device id. Also, Icelake's pin2port mapping table is
different from previous platforms. So add .base_nid at drv_data
to use different base for different platforms.

Signed-off-by: Bard liao bard.liao@intel.com

Add Icelake device id. Also, Icelake's pin2port mapping table is
different from previous platforms. So add .base_nid at drv_data
to use different base for different platforms.
Signed-off-by: Bard liao <bard.liao@intel.com>
@bardliao

Copy link
Copy Markdown
CollaboratorAuthor

@lgirdwood@plbossart I found something wrong on pin2port mapping. Please don't merge it until I find the rule of pin2port.

@bardliaobardliao closed this Nov 5, 2018
@plbossart

Copy link
Copy Markdown
Member

isn't the rule already part of the patch_hdmi.c code

/* There is a fixed mapping between audio pin node and display port. * on SNB, IVY, HSW, BSW, SKL, BXT, KBL: * Pin Widget 5 - PORT B (port = 1 in i915 driver) * Pin Widget 6 - PORT C (port = 2 in i915 driver) * Pin Widget 7 - PORT D (port = 3 in i915 driver) * * on VLV, ILK: * Pin Widget 4 - PORT B (port = 1 in i915 driver) * Pin Widget 5 - PORT C (port = 2 in i915 driver) * Pin Widget 6 - PORT D (port = 3 in i915 driver) */staticintintel_base_nid(structhda_codec*codec)
{
switch (codec->core.vendor_id) {
case0x80860054: /* ILK */case0x80862804: /* ILK */case0x80862882: /* VLV */return4;
default:
return5;
}
}
staticintintel_pin2port(void*audio_ptr, intpin_nid)
{
intbase_nid=intel_base_nid(audio_ptr);
if (WARN_ON(pin_nid<base_nid||pin_nid >= base_nid+3))
return-1;
returnpin_nid-base_nid+1; /* intel port is 1-based */
}

@bardliao

Copy link
Copy Markdown
CollaboratorAuthor

@plbossart Yes, and it is why I feel confused. From the role of patch_hdmi.c, the ICL's intel_base_nid should be 5. And the spec also says the same. But it is 4 by reading the nid. So I don't know which one is correct. Actually, I think it is 4 right now, but I don't know if it will be "fixed" to 5 in the future.

oder-chiou pushed a commit to oder-chiou/linux-soundwire that referenced this pull request May 5, 2026
Add a big batch of test coverage to assert all aspects of the tcx opts
attach, detach and query API:
# ./vmtest.sh -- ./test_progs -t tc_opts
[...]
thesofproject#238 tc_opts_after:OK
thesofproject#239 tc_opts_append:OK
thesofproject#240 tc_opts_basic:OK
thesofproject#241 tc_opts_before:OK
thesofproject#242 tc_opts_chain_classic:OK
thesofproject#243 tc_opts_demixed:OK
thesofproject#244 tc_opts_detach:OK
thesofproject#245 tc_opts_detach_after:OK
thesofproject#246 tc_opts_detach_before:OK
thesofproject#247 tc_opts_dev_cleanup:OK
thesofproject#248 tc_opts_invalid:OK
thesofproject#249 tc_opts_mixed:OK
thesofproject#250 tc_opts_prepend:OK
thesofproject#251 tc_opts_replace:OK
thesofproject#252 tc_opts_revision:OK
Summary: 15/0 PASSED, 0 SKIPPED, 0 FAILED
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/r/20230719140858.13224-8-daniel@iogearbox.net
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
oder-chiou pushed a commit to oder-chiou/linux-soundwire that referenced this pull request May 5, 2026
Add a detachment test case with miniq present to assert that with and
without the miniq we get the same error.
# ./test_progs -t tc_opts
thesofproject#244 tc_opts_after:OK
thesofproject#245 tc_opts_append:OK
thesofproject#246 tc_opts_basic:OK
thesofproject#247 tc_opts_before:OK
thesofproject#248 tc_opts_chain_classic:OK
thesofproject#249 tc_opts_delete_empty:OK
thesofproject#250 tc_opts_demixed:OK
thesofproject#251 tc_opts_detach:OK
thesofproject#252 tc_opts_detach_after:OK
thesofproject#253 tc_opts_detach_before:OK
thesofproject#254 tc_opts_dev_cleanup:OK
thesofproject#255 tc_opts_invalid:OK
thesofproject#256 tc_opts_mixed:OK
thesofproject#257 tc_opts_prepend:OK
thesofproject#258 tc_opts_replace:OK
thesofproject#259 tc_opts_revision:OK
Summary: 16/0 PASSED, 0 SKIPPED, 0 FAILED
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/r/20230804131112.11012-2-daniel@iogearbox.net
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
oder-chiou pushed a commit to oder-chiou/linux-soundwire that referenced this pull request May 5, 2026
Add several new tcx test cases to improve test coverage. This also includes
a few new tests with ingress instead of clsact qdisc, to cover the fix from
commit dc644b5 ("tcx: Fix splat in ingress_destroy upon tcx_entry_free").
# ./test_progs -t tc
[...]
thesofproject#234 tc_links_after:OK
thesofproject#235 tc_links_append:OK
thesofproject#236 tc_links_basic:OK
thesofproject#237 tc_links_before:OK
thesofproject#238 tc_links_chain_classic:OK
thesofproject#239 tc_links_chain_mixed:OK
thesofproject#240 tc_links_dev_cleanup:OK
thesofproject#241 tc_links_dev_mixed:OK
thesofproject#242 tc_links_ingress:OK
thesofproject#243 tc_links_invalid:OK
thesofproject#244 tc_links_prepend:OK
thesofproject#245 tc_links_replace:OK
thesofproject#246 tc_links_revision:OK
thesofproject#247 tc_opts_after:OK
thesofproject#248 tc_opts_append:OK
thesofproject#249 tc_opts_basic:OK
thesofproject#250 tc_opts_before:OK
thesofproject#251 tc_opts_chain_classic:OK
thesofproject#252 tc_opts_chain_mixed:OK
thesofproject#253 tc_opts_delete_empty:OK
thesofproject#254 tc_opts_demixed:OK
thesofproject#255 tc_opts_detach:OK
thesofproject#256 tc_opts_detach_after:OK
thesofproject#257 tc_opts_detach_before:OK
thesofproject#258 tc_opts_dev_cleanup:OK
thesofproject#259 tc_opts_invalid:OK
thesofproject#260 tc_opts_mixed:OK
thesofproject#261 tc_opts_prepend:OK
thesofproject#262 tc_opts_replace:OK
thesofproject#263 tc_opts_revision:OK
[...]
Summary: 44/38 PASSED, 0 SKIPPED, 0 FAILED
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/r/8699efc284b75ccdc51ddf7062fa2370330dc6c0.1692029283.git.daniel@iogearbox.net
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bardliao@plbossart@lgirdwood