Uh oh!
There was an error while loading. Please reload this page.
[TEST] SoundWire: fix FIELD_PREP usage - #2442
Closed
plbossart wants to merge 2 commits into
Closed
Conversation
plbossart
requested review from
RanderWang, jack-cy-yu, oder-chiou, ryans-lee and shumingfan
as code ownersSeptember 16, 2020 14:45
plbossart
commented
Sep 16, 2020
MemberAuthor
Looks ok to me, I didn't find any other examples of read-modify-write. |
FIELD_PREP() does not replace the bits so it is not apt in case where we modify a register. Use u32p_replace_bits() instead. Fixes: 3cf25d6 ("soundwire: cadence: use FIELD_{GET|PREP}") Signed-off-by: Vinod Koul <vkoul@kernel.org>
FIELD_PREP() does not replace the bits so it is not apt in case where we modify a register. Use u32_replace_bits() or u16_replace_bits() instead. Fixes: 3b4979c ("soundwire: intel: use FIELD_{GET|PREP}") Signed-off-by: Vinod Koul <vkoul@kernel.org>
plbossartforce-pushed
the
sdw/fix-FIELD_PREP
branch
from
September 17, 2020 17:37
5f34e62 to
0c8a783Compareplbossart
commented
Sep 17, 2020
MemberAuthor
v2 of patches forced-pushed |
bardliao
commented
Sep 18, 2020
Collaborator
@plbossart I will get build error if #2298 is applied. |
bardliao
commented
Sep 18, 2020
Collaborator
Sorry, I thought the fix is for sdca codecs but obviously not. Verified it on TGL-U laptop. |
plbossart
commented
Sep 18, 2020
MemberAuthor
ok, this is upstream so closing |
IulianOlaru249 pushed a commit
to IulianOlaru249/linux
that referenced
this pull request
Mar 16, 2022
As noted in Sphinx thesofproject#2442 new CSS added by extensions are rendered innefective if html_context its changed. So, instead, use add_stylesheet to add theme_overridesc.css Signed-off-by: Octavian Purdila <tavi@cs.pub.ro>
oder-chiou pushed a commit
to oder-chiou/linux-soundwire
that referenced
this pull request
May 5, 2026
…arations) Fix checkpatch code style warnings: WARNING: Missing a blank line after declarations thesofproject#761: FILE: net/core/pktgen.c:761: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations thesofproject#780: FILE: net/core/pktgen.c:780: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations thesofproject#806: FILE: net/core/pktgen.c:806: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations thesofproject#823: FILE: net/core/pktgen.c:823: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations thesofproject#1968: FILE: net/core/pktgen.c:1968: + char f[32]; + memset(f, 0, 32); WARNING: Missing a blank line after declarations thesofproject#2410: FILE: net/core/pktgen.c:2410: + struct pktgen_net *pn = net_generic(dev_net(pkt_dev->odev), pg_net_id); + if (!x) { WARNING: Missing a blank line after declarations thesofproject#2442: FILE: net/core/pktgen.c:2442: + __u16 t; + if (pkt_dev->flags & F_QUEUE_MAP_RND) { WARNING: Missing a blank line after declarations thesofproject#2523: FILE: net/core/pktgen.c:2523: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations thesofproject#2567: FILE: net/core/pktgen.c:2567: + __u32 t; + if (pkt_dev->flags & F_IPSRC_RND) WARNING: Missing a blank line after declarations thesofproject#2587: FILE: net/core/pktgen.c:2587: + __be32 s; + if (pkt_dev->flags & F_IPDST_RND) { WARNING: Missing a blank line after declarations thesofproject#2634: FILE: net/core/pktgen.c:2634: + __u32 t; + if (pkt_dev->flags & F_TXSIZE_RND) { WARNING: Missing a blank line after declarations thesofproject#2736: FILE: net/core/pktgen.c:2736: + int i; + for (i = 0; i < pkt_dev->cflows; i++) { WARNING: Missing a blank line after declarations thesofproject#2738: FILE: net/core/pktgen.c:2738: + struct xfrm_state *x = pkt_dev->flows[i].x; + if (x) { WARNING: Missing a blank line after declarations thesofproject#2752: FILE: net/core/pktgen.c:2752: + int nhead = 0; + if (x) { WARNING: Missing a blank line after declarations thesofproject#2795: FILE: net/core/pktgen.c:2795: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations thesofproject#3480: FILE: net/core/pktgen.c:3480: + ktime_t idle_start = ktime_get(); + schedule(); Signed-off-by: Peter Seiderer <ps.report@gmx.net> Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI check on @vinodkoul's fix