Skip to content

ALSA: hda/hdmi: packet buffer index must be set before reading value - #2518

Closed
kv2019i wants to merge 1 commit into
thesofproject:topic/sof-devfrom
kv2019i:topic/patch-hdmi-xmit-index-fix
Closed

ALSA: hda/hdmi: packet buffer index must be set before reading value#2518
kv2019i wants to merge 1 commit into
thesofproject:topic/sof-devfrom
kv2019i:topic/patch-hdmi-xmit-index-fix

Conversation

@kv2019i

Copy link
Copy Markdown
Collaborator

The check for infoframe transmit status in hdmi_infoframe_uptodate()
makes the assumption that packet buffer index is set to zero.

Align code with specification and explicitly set the index before
AC_VERB_GET_HDMI_DIP_XMIT.

This change is based on code review against specification.

Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com

The check for infoframe transmit status in hdmi_infoframe_uptodate()
makes the assumption that packet buffer index is set to zero.
Align code with specification and explicitly set the index before
AC_VERB_GET_HDMI_DIP_XMIT.
This change is based on code review against specification.
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i

Copy link
Copy Markdown
CollaboratorAuthor

SOFCI TEST

@kv2019i

Copy link
Copy Markdown
CollaboratorAuthor

https://sof-ci.01.org/linuxpr/PR2518/build4747/devicetest/
CML failure logged in as thesofproject/sof-test#463
BYT alsabat failure is tracked in thesofproject/sof-test#379

I'll submit this upstream when 5.10-rc1 is out.

@kv2019i

Copy link
Copy Markdown
CollaboratorAuthor

Merged upstream as 46c3bbd

@kv2019ikv2019i closed this Jan 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kv2019i