Skip to content

ALSA: hda: intel-dsp-config: add PCI id for TGL-H#2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bardliao merged 2 commits into from
Jan 7, 2021
Merged

ALSA: hda: intel-dsp-config: add PCI id for TGL-H #2665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4c87cf
ALSA: hda: intel-dsp-config: simplify flags for TigerLake/ElkhartLake
bardliao Jan 6, 2021
bc3f2dd
ALSA: hda: intel-dsp-config: add PCI id for TGL-H
bardliao Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions sound/hda/intel-dsp-config.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -293,26 +293,17 @@ static const struct config_entry config_table[] = {
{
.flags = FLAG_SOF,
.device = 0xa0c8,
.dmi_table = (const struct dmi_system_id []) {
{
.ident = "Google Chromebooks",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Google"),
}
},
{}
}
},
{
.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
.device = 0xa0c8,

@plbossartplbossartJan 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that's not correct. If we don't have DMIC/SoundWire, and it's not a Chromebook, then we want to use the legacy HDaudio driver.
The Chromebook does not rely on NHLT so the DMIC detection will fail, so it needs a dedicated quirk.

This needs to be reverted IMHO.

.flags = FLAG_SOF,
Comment thread
xiulipan marked this conversation as resolved.
.device = 0x43c8,
},

@plbossartplbossartJan 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above, this will unconditionally select SOF. This is not what we want.

#endif

/* Elkhart Lake */
#if IS_ENABLED(CONFIG_SND_SOC_SOF_ELKHARTLAKE)
{
.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC,
.flags = FLAG_SOF,
.device = 0x4b55,
},
#endif
Expand Down