ASoC: SOF: intel: hda-stream: Print stream name on STREAM_SD_OFFSET t… by ujfalusi · Pull Request #3121 · thesofproject/linux

ujfalusi · 2021-08-26T10:42:38Z

…imeout

In order to provide more information in case of timeout observed while
reading STREAM_SD_OFFSET, print out the stream name or in case there is
no audio stream associated (like dma-trace), print "--"

Signed-off-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com

ujfalusi · 2021-08-26T10:44:20Z

@plbossart, @lgirdwood: FYI. Is this something can be of use as mentioned in thesofproject/sof#4548?

lgirdwood

Thanks, this is useful to help root causing the stream DMA stop offset timeout.

lgirdwood · 2021-08-26T12:59:52Z

+	if (ret < 0) {
+ dev_err(sdev->dev,
+ "%s: cmd %d on substream %s: timeout on STREAM_SD_OFFSET read\n",
+ __func__, cmd, hstream->substream ? hstream->substream->name : "--");


Would it be correct to assume that only the trace and or probes would not have a substream name ? if so, could we asign then a name as part of their open() ?

neither the probes, dma-trace or the real compressed would have substream. We don't have place to assign custom name, let me try something...

We could print out the stream_tag which is always unique

ok, stream_tag is in the FW logs so could be aligned with the dmesg and would work for debug.

Let me try to squeeze it there. We are 90 char already which is the limit I rather not step, but under 100 is still OK for checkpatch

ujfalusi · 2021-08-26T14:02:55Z

Changes since v1:

helper function to get the stream name (hda_hstream_get_stream_name)
return either the substream->name or the cstream->name or NULL

lgirdwood

LGTM, stream_tag would be a bonus.

ujfalusi · 2021-08-26T14:21:59Z

Changes since v2:

print the stream_tag as well as it is unique for each stream, regardless of type (audio/compressed/dtrace)
replace substream %s with stream %s in the prints to save three characters, now the longest line is at 92 char

ranj063

LGTM @ujfalusi. out of curiosity what does stream name print? Usually, I can find out which streamis it my seeing the PCM device number and the direction. Just wondering what this would show

ujfalusi · 2021-08-26T17:40:09Z

@ranj063,
dma-trace: hda_dsp_stream_trigger: cmd 1 on stream -- (1): timeout on STREAM_SD_OFFSET read
aplay -Dplughw:0,0: hda_dsp_stream_trigger: cmd 1 on stream subdevice #0 (1): timeout on STREAM_SD_OFFSET read

on a tgl-h laptop.

ranj063 · 2021-08-26T17:45:54Z

@ranj063,
dma-trace: hda_dsp_stream_trigger: cmd 1 on stream -- (1): timeout on STREAM_SD_OFFSET read
aplay -Dplughw:0,0: hda_dsp_stream_trigger: cmd 1 on stream subdevice #0 (1): timeout on STREAM_SD_OFFSET read
on a tgl-h laptop.

@ujfalusi Thanks. I wonder if it then makes sense to also print the direction? subdevice #0 ?

plbossart · 2021-08-26T18:21:59Z

@ranj063,
dma-trace: hda_dsp_stream_trigger: cmd 1 on stream -- (1): timeout on STREAM_SD_OFFSET read
aplay -Dplughw:0,0: hda_dsp_stream_trigger: cmd 1 on stream subdevice #0 (1): timeout on STREAM_SD_OFFSET read
on a tgl-h laptop.
@ujfalusi Thanks. I wonder if it then makes sense to also print the direction? subdevice #0 ?

I tried to use the stream name for SoundWire stuff and all I could get was a bunch of 'subdevice #0' and 'subdevice #1'. Not very helpful when you have multiple dailinks. I ended-up adding the dai name to at least know which stream this really was.

ujfalusi · 2021-08-26T18:33:21Z

@ranj063,
dma-trace: hda_dsp_stream_trigger: cmd 1 on stream -- (1): timeout on STREAM_SD_OFFSET read
aplay -Dplughw:0,0: hda_dsp_stream_trigger: cmd 1 on stream subdevice #0 (1): timeout on STREAM_SD_OFFSET read
on a tgl-h laptop.
@ujfalusi Thanks. I wonder if it then makes sense to also print the direction? subdevice #0 ?
I tried to use the stream name for SoundWire stuff and all I could get was a bunch of 'subdevice #0' and 'subdevice #1'. Not very helpful when you have multiple dailinks. I ended-up adding the dai name to at least know which stream this really was.

@plbossart, @ranj063, or if we can reach the dai-link name for the given stream? Looking at the prints the stream_tag is not the most useful information I have seen, but when multiple streams are running they should give some pointer.
I'll check tomorrow if we can swap the substream->name with something more helpful.

ujfalusi · 2021-08-27T09:17:58Z

Changes since v3:

the printed information contains more and more accurate information

Tested on top of SOF clients branch to have working probes and the prints are:
dma-trace
hda_dsp_stream_trigger: cmd 1 on -- (Capture, stream_tag: 1): timeout on STREAM_SD_OFFSET read

aplay -Dplughw:1,0
hda_dsp_stream_trigger: cmd 1 on dai_link "HDA Analog" (Playback, stream_tag: 1): timeout on STREAM_SD_OFFSET read

probes crecord
hda_dsp_stream_trigger: cmd 1 on dai_link "Compress Probe Capture" (Capture, stream_tag: 2): timeout on STREAM_SD_OFFSET read

ujfalusi · 2021-08-27T13:11:50Z

Changes since v4:

Add comment for non audio user case in hda_hstream_dbg_get_stream_info_str()
remove the dai_link casting, simply use rtd->dai_link->name

…imeout In order to provide more information in case of timeout observed while reading STREAM_SD_OFFSET, print out the stream name or in case there is no audio stream associated (like dma-trace), print "--" Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

ranj063

Thanks @ujfalusi. this is quite nice!

ujfalusi requested review from bardliao, keyonjie, libinyang and lyakh as code owners August 26, 2021 10:42

ujfalusi mentioned this pull request Aug 26, 2021
trace: fixes to help for heap allocation debugging thesofproject/sof#4548
Merged

lgirdwood reviewed Aug 26, 2021
View reviewed changes

ujfalusi force-pushed the peter/sof/pr/hda_STREAM_SD_OFFSET_error branch from ee77a51 to 27b016eCompare August 26, 2021 14:01

lgirdwood reviewed Aug 26, 2021
View reviewed changes

ujfalusi force-pushed the peter/sof/pr/hda_STREAM_SD_OFFSET_error branch from 27b016e to fb4185eCompare August 26, 2021 14:20

ujfalusi force-pushed the peter/sof/pr/hda_STREAM_SD_OFFSET_error branch from fb4185e to c21ae64Compare August 26, 2021 14:23

plbossart previously approved these changes Aug 26, 2021
View reviewed changes

ranj063 previously approved these changes Aug 26, 2021
View reviewed changes

lgirdwood previously approved these changes Aug 26, 2021
View reviewed changes

ujfalusi dismissed stale reviews from lgirdwood, ranj063, and plbossart via b0846b5August 27, 2021 09:13

ujfalusi force-pushed the peter/sof/pr/hda_STREAM_SD_OFFSET_error branch from c21ae64 to b0846b5Compare August 27, 2021 09:13

plbossart reviewed Aug 27, 2021
View reviewed changes

Comment threadsound/soc/sof/intel/hda-stream.c

ujfalusi force-pushed the peter/sof/pr/hda_STREAM_SD_OFFSET_error branch from b0846b5 to 666c187Compare August 27, 2021 13:12

plbossart approved these changes Aug 27, 2021
View reviewed changes

ranj063 approved these changes Aug 27, 2021
View reviewed changes

plbossart approved these changes Aug 27, 2021
View reviewed changes

plbossart merged commit b324ced into thesofproject:topic/sof-devAug 27, 2021

Uh oh!

Conversation

ujfalusi commented Aug 26, 2021

Uh oh!

ujfalusi commented Aug 26, 2021

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwoodAug 26, 2021

Choose a reason for hiding this comment

Uh oh!

ujfalusiAug 26, 2021

Choose a reason for hiding this comment

Uh oh!

ujfalusiAug 26, 2021

Choose a reason for hiding this comment

Uh oh!

lgirdwoodAug 26, 2021

Choose a reason for hiding this comment

Uh oh!

ujfalusiAug 26, 2021

Choose a reason for hiding this comment

Uh oh!

ujfalusi commented Aug 26, 2021

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

ujfalusi commented Aug 26, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ranj063 left a comment

Choose a reason for hiding this comment

Uh oh!

ujfalusi commented Aug 26, 2021

Uh oh!

ranj063 commented Aug 26, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

plbossart commented Aug 26, 2021

Uh oh!

ujfalusi commented Aug 26, 2021

Uh oh!

ujfalusi commented Aug 27, 2021

Uh oh!

Uh oh!

ujfalusi commented Aug 27, 2021

Uh oh!

ranj063 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ujfalusi commented Aug 26, 2021•
edited
Loading

ranj063 commented Aug 26, 2021•
edited
Loading