Uh oh!
There was an error while loading. Please reload this page.
Add new IPC for trace dma free - #3197
Merged
plbossart merged 3 commits intoOct 21, 2021
Merged
Conversation
ranj063
requested review from
juimonen, keyonjie, kv2019i and lyakh
as code ownersOctober 5, 2021 23:50
ranj063force-pushed
the
fix/trace_dma_free
branch
from
October 5, 2021 23:52
70ac1f4 to
a9f6186Compareujfalusi
requested changes
Oct 7, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ujfalusi
commented
Oct 7, 2021
Collaborator
@ranj063, while at it, can you also update the |
Add a new SOF_IPC_TRACE_DMA_FREE IPC command to stop and free trace DMA in the FW. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Parse all the trace DMA IPC commands in ipc_log_header(). Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
commented
Oct 15, 2021
CollaboratorAuthor
ranj063force-pushed
the
fix/trace_dma_free
branch
from
October 15, 2021 04:52
a9f6186 to
1d50589CompareSend the DMA_TRACE_FREE IPC during release to stop and free the trace DMA in the DSP. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063force-pushed
the
fix/trace_dma_free
branch
from
October 15, 2021 05:09
1d50589 to
d4de613Compareujfalusi
approved these changes
Oct 15, 2021
| struct sof_ipc_fw_ready *ready = &sdev->fw_ready; | ||
| struct sof_ipc_fw_version *v = &ready->version; | ||
| struct sof_ipc_cmd_hdr hdr; | ||
| struct sof_ipc_reply ipc_reply; |
Collaborator
There was a problem hiding this comment.
nitpick: can you swap these?
or move them local under the if(ABI) ?
Member
kv2019i
approved these changes
Oct 20, 2021
plbossart
approved these changes
Oct 20, 2021
plbossart
left a comment
Member
There was a problem hiding this comment.
nit-pick comments, ok to merge and deal with comments with a fixup
| struct sof_ipc_fw_ready *ready = &sdev->fw_ready; | ||
| struct sof_ipc_fw_version *v = &ready->version; | ||
| struct sof_ipc_cmd_hdr hdr; | ||
| struct sof_ipc_reply ipc_reply; |
Member
| ret = sof_ipc_tx_message(sdev->ipc, hdr.cmd, &hdr, hdr.size, | ||
| &ipc_reply, sizeof(ipc_reply)); | ||
| if (ret < 0) | ||
| dev_err(sdev->dev, "DMA_TRACE_FREE failed with error: %d\n", ret); |
Member
There was a problem hiding this comment.
return ret?
or add a comment that on why we don't return?
This can be done with a fixup PR.
Collaborator
There was a problem hiding this comment.
I think the intention is to continue to the host side release, even if the IPC fails, in this case this should be dev_warn()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FW PR thesofproject/sof#4849