Uh oh!
There was an error while loading. Please reload this page.
upstream reviews - take 2 - #335
Merged
plbossart merged 3 commits intoNov 30, 2018
Merged
Conversation
plbossart
requested review from
RanderWang, bardliao, keyonjie, lgirdwood and ranj063November 29, 2018 19:41
RanderWang
approved these changes
Nov 30, 2018
RanderWang
left a comment
There was a problem hiding this comment.
one question: I don't understand why it is not good to add some interfaces in sof_dsp_ops. Thanks
bardliao
requested changes
Nov 30, 2018
bardliao
left a comment
Collaborator
There was a problem hiding this comment.
We can use SNDRV_PCM_STREAM_PLAYBACK since we are freeing playback stream
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
plbossartforce-pushed
the
fix/upstream-reviews2
branch
from
November 30, 2018 16:17
cbdc405 to
80bb3e0Compareplbossart
commented
Nov 30, 2018
MemberAuthor
@RanderWang we can do whatever changes we want to sof structures since we 'own' the framework. Modifying or abusing ALSA or ASoC APIs and structures is not ok in general, we are not the owners and need to have a strong case to get a change accepted by Mark Brown and Takashi Iwai. |
Make it clear that the current solution is not acceptable and has to be reworked Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
It is not clear why the parsing should continue, so for now exit and return an error. This is only used by BYT/CHT/BDW anyways so the odd of new features being added are slim. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The error flow in pcm_new was completely broken, make sure the page tables are released. The pre-allocated DMA buffer is not released since it's a task the ALSA core will do for us. Added comment of the intent so that people looking for balanced memory allocations understand this is not an omission. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossartforce-pushed
the
fix/upstream-reviews2
branch
from
November 30, 2018 16:32
80bb3e0 to
9374795Compareoder-chiou pushed a commit
to oder-chiou/linux-soundwire
that referenced
this pull request
May 5, 2026
Enable CPU v4 instruction tests for arm64. Below are the test results from BPF test_progs selftests: # ./test_progs -t ldsx_insn,verifier_sdiv,verifier_movsx,verifier_ldsx,verifier_gotol,verifier_bswap thesofproject#115/1 ldsx_insn/map_val and probed_memory:OK thesofproject#115/2 ldsx_insn/ctx_member_sign_ext:OK thesofproject#115/3 ldsx_insn/ctx_member_narrow_sign_ext:OK thesofproject#115 ldsx_insn:OK thesofproject#302/1 verifier_bswap/BSWAP, 16:OK thesofproject#302/2 verifier_bswap/BSWAP, 16 @unpriv:OK thesofproject#302/3 verifier_bswap/BSWAP, 32:OK thesofproject#302/4 verifier_bswap/BSWAP, 32 @unpriv:OK thesofproject#302/5 verifier_bswap/BSWAP, 64:OK thesofproject#302/6 verifier_bswap/BSWAP, 64 @unpriv:OK thesofproject#302 verifier_bswap:OK thesofproject#316/1 verifier_gotol/gotol, small_imm:OK thesofproject#316/2 verifier_gotol/gotol, small_imm @unpriv:OK thesofproject#316 verifier_gotol:OK thesofproject#324/1 verifier_ldsx/LDSX, S8:OK thesofproject#324/2 verifier_ldsx/LDSX, S8 @unpriv:OK thesofproject#324/3 verifier_ldsx/LDSX, S16:OK thesofproject#324/4 verifier_ldsx/LDSX, S16 @unpriv:OK thesofproject#324/5 verifier_ldsx/LDSX, S32:OK thesofproject#324/6 verifier_ldsx/LDSX, S32 @unpriv:OK thesofproject#324/7 verifier_ldsx/LDSX, S8 range checking, privileged:OK thesofproject#324/8 verifier_ldsx/LDSX, S16 range checking:OK thesofproject#324/9 verifier_ldsx/LDSX, S16 range checking @unpriv:OK thesofproject#324/10 verifier_ldsx/LDSX, S32 range checking:OK thesofproject#324/11 verifier_ldsx/LDSX, S32 range checking @unpriv:OK thesofproject#324 verifier_ldsx:OK thesofproject#335/1 verifier_movsx/MOV32SX, S8:OK thesofproject#335/2 verifier_movsx/MOV32SX, S8 @unpriv:OK thesofproject#335/3 verifier_movsx/MOV32SX, S16:OK thesofproject#335/4 verifier_movsx/MOV32SX, S16 @unpriv:OK thesofproject#335/5 verifier_movsx/MOV64SX, S8:OK thesofproject#335/6 verifier_movsx/MOV64SX, S8 @unpriv:OK thesofproject#335/7 verifier_movsx/MOV64SX, S16:OK thesofproject#335/8 verifier_movsx/MOV64SX, S16 @unpriv:OK thesofproject#335/9 verifier_movsx/MOV64SX, S32:OK thesofproject#335/10 verifier_movsx/MOV64SX, S32 @unpriv:OK thesofproject#335/11 verifier_movsx/MOV32SX, S8, range_check:OK thesofproject#335/12 verifier_movsx/MOV32SX, S8, range_check @unpriv:OK thesofproject#335/13 verifier_movsx/MOV32SX, S16, range_check:OK thesofproject#335/14 verifier_movsx/MOV32SX, S16, range_check @unpriv:OK thesofproject#335/15 verifier_movsx/MOV32SX, S16, range_check 2:OK thesofproject#335/16 verifier_movsx/MOV32SX, S16, range_check 2 @unpriv:OK thesofproject#335/17 verifier_movsx/MOV64SX, S8, range_check:OK thesofproject#335/18 verifier_movsx/MOV64SX, S8, range_check @unpriv:OK thesofproject#335/19 verifier_movsx/MOV64SX, S16, range_check:OK thesofproject#335/20 verifier_movsx/MOV64SX, S16, range_check @unpriv:OK thesofproject#335/21 verifier_movsx/MOV64SX, S32, range_check:OK thesofproject#335/22 verifier_movsx/MOV64SX, S32, range_check @unpriv:OK thesofproject#335/23 verifier_movsx/MOV64SX, S16, R10 Sign Extension:OK thesofproject#335/24 verifier_movsx/MOV64SX, S16, R10 Sign Extension @unpriv:OK thesofproject#335 verifier_movsx:OK thesofproject#347/1 verifier_sdiv/SDIV32, non-zero imm divisor, check 1:OK thesofproject#347/2 verifier_sdiv/SDIV32, non-zero imm divisor, check 1 @unpriv:OK thesofproject#347/3 verifier_sdiv/SDIV32, non-zero imm divisor, check 2:OK thesofproject#347/4 verifier_sdiv/SDIV32, non-zero imm divisor, check 2 @unpriv:OK thesofproject#347/5 verifier_sdiv/SDIV32, non-zero imm divisor, check 3:OK thesofproject#347/6 verifier_sdiv/SDIV32, non-zero imm divisor, check 3 @unpriv:OK thesofproject#347/7 verifier_sdiv/SDIV32, non-zero imm divisor, check 4:OK thesofproject#347/8 verifier_sdiv/SDIV32, non-zero imm divisor, check 4 @unpriv:OK thesofproject#347/9 verifier_sdiv/SDIV32, non-zero imm divisor, check 5:OK thesofproject#347/10 verifier_sdiv/SDIV32, non-zero imm divisor, check 5 @unpriv:OK thesofproject#347/11 verifier_sdiv/SDIV32, non-zero imm divisor, check 6:OK thesofproject#347/12 verifier_sdiv/SDIV32, non-zero imm divisor, check 6 @unpriv:OK thesofproject#347/13 verifier_sdiv/SDIV32, non-zero imm divisor, check 7:OK thesofproject#347/14 verifier_sdiv/SDIV32, non-zero imm divisor, check 7 @unpriv:OK thesofproject#347/15 verifier_sdiv/SDIV32, non-zero imm divisor, check 8:OK thesofproject#347/16 verifier_sdiv/SDIV32, non-zero imm divisor, check 8 @unpriv:OK thesofproject#347/17 verifier_sdiv/SDIV32, non-zero reg divisor, check 1:OK thesofproject#347/18 verifier_sdiv/SDIV32, non-zero reg divisor, check 1 @unpriv:OK thesofproject#347/19 verifier_sdiv/SDIV32, non-zero reg divisor, check 2:OK thesofproject#347/20 verifier_sdiv/SDIV32, non-zero reg divisor, check 2 @unpriv:OK thesofproject#347/21 verifier_sdiv/SDIV32, non-zero reg divisor, check 3:OK thesofproject#347/22 verifier_sdiv/SDIV32, non-zero reg divisor, check 3 @unpriv:OK thesofproject#347/23 verifier_sdiv/SDIV32, non-zero reg divisor, check 4:OK thesofproject#347/24 verifier_sdiv/SDIV32, non-zero reg divisor, check 4 @unpriv:OK thesofproject#347/25 verifier_sdiv/SDIV32, non-zero reg divisor, check 5:OK thesofproject#347/26 verifier_sdiv/SDIV32, non-zero reg divisor, check 5 @unpriv:OK thesofproject#347/27 verifier_sdiv/SDIV32, non-zero reg divisor, check 6:OK thesofproject#347/28 verifier_sdiv/SDIV32, non-zero reg divisor, check 6 @unpriv:OK thesofproject#347/29 verifier_sdiv/SDIV32, non-zero reg divisor, check 7:OK thesofproject#347/30 verifier_sdiv/SDIV32, non-zero reg divisor, check 7 @unpriv:OK thesofproject#347/31 verifier_sdiv/SDIV32, non-zero reg divisor, check 8:OK thesofproject#347/32 verifier_sdiv/SDIV32, non-zero reg divisor, check 8 @unpriv:OK thesofproject#347/33 verifier_sdiv/SDIV64, non-zero imm divisor, check 1:OK thesofproject#347/34 verifier_sdiv/SDIV64, non-zero imm divisor, check 1 @unpriv:OK thesofproject#347/35 verifier_sdiv/SDIV64, non-zero imm divisor, check 2:OK thesofproject#347/36 verifier_sdiv/SDIV64, non-zero imm divisor, check 2 @unpriv:OK thesofproject#347/37 verifier_sdiv/SDIV64, non-zero imm divisor, check 3:OK thesofproject#347/38 verifier_sdiv/SDIV64, non-zero imm divisor, check 3 @unpriv:OK thesofproject#347/39 verifier_sdiv/SDIV64, non-zero imm divisor, check 4:OK thesofproject#347/40 verifier_sdiv/SDIV64, non-zero imm divisor, check 4 @unpriv:OK thesofproject#347/41 verifier_sdiv/SDIV64, non-zero imm divisor, check 5:OK thesofproject#347/42 verifier_sdiv/SDIV64, non-zero imm divisor, check 5 @unpriv:OK thesofproject#347/43 verifier_sdiv/SDIV64, non-zero imm divisor, check 6:OK thesofproject#347/44 verifier_sdiv/SDIV64, non-zero imm divisor, check 6 @unpriv:OK thesofproject#347/45 verifier_sdiv/SDIV64, non-zero reg divisor, check 1:OK thesofproject#347/46 verifier_sdiv/SDIV64, non-zero reg divisor, check 1 @unpriv:OK thesofproject#347/47 verifier_sdiv/SDIV64, non-zero reg divisor, check 2:OK thesofproject#347/48 verifier_sdiv/SDIV64, non-zero reg divisor, check 2 @unpriv:OK thesofproject#347/49 verifier_sdiv/SDIV64, non-zero reg divisor, check 3:OK thesofproject#347/50 verifier_sdiv/SDIV64, non-zero reg divisor, check 3 @unpriv:OK thesofproject#347/51 verifier_sdiv/SDIV64, non-zero reg divisor, check 4:OK thesofproject#347/52 verifier_sdiv/SDIV64, non-zero reg divisor, check 4 @unpriv:OK thesofproject#347/53 verifier_sdiv/SDIV64, non-zero reg divisor, check 5:OK thesofproject#347/54 verifier_sdiv/SDIV64, non-zero reg divisor, check 5 @unpriv:OK thesofproject#347/55 verifier_sdiv/SDIV64, non-zero reg divisor, check 6:OK thesofproject#347/56 verifier_sdiv/SDIV64, non-zero reg divisor, check 6 @unpriv:OK thesofproject#347/57 verifier_sdiv/SMOD32, non-zero imm divisor, check 1:OK thesofproject#347/58 verifier_sdiv/SMOD32, non-zero imm divisor, check 1 @unpriv:OK thesofproject#347/59 verifier_sdiv/SMOD32, non-zero imm divisor, check 2:OK thesofproject#347/60 verifier_sdiv/SMOD32, non-zero imm divisor, check 2 @unpriv:OK thesofproject#347/61 verifier_sdiv/SMOD32, non-zero imm divisor, check 3:OK thesofproject#347/62 verifier_sdiv/SMOD32, non-zero imm divisor, check 3 @unpriv:OK thesofproject#347/63 verifier_sdiv/SMOD32, non-zero imm divisor, check 4:OK thesofproject#347/64 verifier_sdiv/SMOD32, non-zero imm divisor, check 4 @unpriv:OK thesofproject#347/65 verifier_sdiv/SMOD32, non-zero imm divisor, check 5:OK thesofproject#347/66 verifier_sdiv/SMOD32, non-zero imm divisor, check 5 @unpriv:OK thesofproject#347/67 verifier_sdiv/SMOD32, non-zero imm divisor, check 6:OK thesofproject#347/68 verifier_sdiv/SMOD32, non-zero imm divisor, check 6 @unpriv:OK thesofproject#347/69 verifier_sdiv/SMOD32, non-zero reg divisor, check 1:OK thesofproject#347/70 verifier_sdiv/SMOD32, non-zero reg divisor, check 1 @unpriv:OK thesofproject#347/71 verifier_sdiv/SMOD32, non-zero reg divisor, check 2:OK thesofproject#347/72 verifier_sdiv/SMOD32, non-zero reg divisor, check 2 @unpriv:OK thesofproject#347/73 verifier_sdiv/SMOD32, non-zero reg divisor, check 3:OK thesofproject#347/74 verifier_sdiv/SMOD32, non-zero reg divisor, check 3 @unpriv:OK thesofproject#347/75 verifier_sdiv/SMOD32, non-zero reg divisor, check 4:OK thesofproject#347/76 verifier_sdiv/SMOD32, non-zero reg divisor, check 4 @unpriv:OK thesofproject#347/77 verifier_sdiv/SMOD32, non-zero reg divisor, check 5:OK thesofproject#347/78 verifier_sdiv/SMOD32, non-zero reg divisor, check 5 @unpriv:OK thesofproject#347/79 verifier_sdiv/SMOD32, non-zero reg divisor, check 6:OK thesofproject#347/80 verifier_sdiv/SMOD32, non-zero reg divisor, check 6 @unpriv:OK thesofproject#347/81 verifier_sdiv/SMOD64, non-zero imm divisor, check 1:OK thesofproject#347/82 verifier_sdiv/SMOD64, non-zero imm divisor, check 1 @unpriv:OK thesofproject#347/83 verifier_sdiv/SMOD64, non-zero imm divisor, check 2:OK thesofproject#347/84 verifier_sdiv/SMOD64, non-zero imm divisor, check 2 @unpriv:OK thesofproject#347/85 verifier_sdiv/SMOD64, non-zero imm divisor, check 3:OK thesofproject#347/86 verifier_sdiv/SMOD64, non-zero imm divisor, check 3 @unpriv:OK thesofproject#347/87 verifier_sdiv/SMOD64, non-zero imm divisor, check 4:OK thesofproject#347/88 verifier_sdiv/SMOD64, non-zero imm divisor, check 4 @unpriv:OK thesofproject#347/89 verifier_sdiv/SMOD64, non-zero imm divisor, check 5:OK thesofproject#347/90 verifier_sdiv/SMOD64, non-zero imm divisor, check 5 @unpriv:OK thesofproject#347/91 verifier_sdiv/SMOD64, non-zero imm divisor, check 6:OK thesofproject#347/92 verifier_sdiv/SMOD64, non-zero imm divisor, check 6 @unpriv:OK thesofproject#347/93 verifier_sdiv/SMOD64, non-zero imm divisor, check 7:OK thesofproject#347/94 verifier_sdiv/SMOD64, non-zero imm divisor, check 7 @unpriv:OK thesofproject#347/95 verifier_sdiv/SMOD64, non-zero imm divisor, check 8:OK thesofproject#347/96 verifier_sdiv/SMOD64, non-zero imm divisor, check 8 @unpriv:OK thesofproject#347/97 verifier_sdiv/SMOD64, non-zero reg divisor, check 1:OK thesofproject#347/98 verifier_sdiv/SMOD64, non-zero reg divisor, check 1 @unpriv:OK thesofproject#347/99 verifier_sdiv/SMOD64, non-zero reg divisor, check 2:OK thesofproject#347/100 verifier_sdiv/SMOD64, non-zero reg divisor, check 2 @unpriv:OK thesofproject#347/101 verifier_sdiv/SMOD64, non-zero reg divisor, check 3:OK thesofproject#347/102 verifier_sdiv/SMOD64, non-zero reg divisor, check 3 @unpriv:OK thesofproject#347/103 verifier_sdiv/SMOD64, non-zero reg divisor, check 4:OK thesofproject#347/104 verifier_sdiv/SMOD64, non-zero reg divisor, check 4 @unpriv:OK thesofproject#347/105 verifier_sdiv/SMOD64, non-zero reg divisor, check 5:OK thesofproject#347/106 verifier_sdiv/SMOD64, non-zero reg divisor, check 5 @unpriv:OK thesofproject#347/107 verifier_sdiv/SMOD64, non-zero reg divisor, check 6:OK thesofproject#347/108 verifier_sdiv/SMOD64, non-zero reg divisor, check 6 @unpriv:OK thesofproject#347/109 verifier_sdiv/SMOD64, non-zero reg divisor, check 7:OK thesofproject#347/110 verifier_sdiv/SMOD64, non-zero reg divisor, check 7 @unpriv:OK thesofproject#347/111 verifier_sdiv/SMOD64, non-zero reg divisor, check 8:OK thesofproject#347/112 verifier_sdiv/SMOD64, non-zero reg divisor, check 8 @unpriv:OK thesofproject#347/113 verifier_sdiv/SDIV32, zero divisor:OK thesofproject#347/114 verifier_sdiv/SDIV32, zero divisor @unpriv:OK thesofproject#347/115 verifier_sdiv/SDIV64, zero divisor:OK thesofproject#347/116 verifier_sdiv/SDIV64, zero divisor @unpriv:OK thesofproject#347/117 verifier_sdiv/SMOD32, zero divisor:OK thesofproject#347/118 verifier_sdiv/SMOD32, zero divisor @unpriv:OK thesofproject#347/119 verifier_sdiv/SMOD64, zero divisor:OK thesofproject#347/120 verifier_sdiv/SMOD64, zero divisor @unpriv:OK thesofproject#347 verifier_sdiv:OK Summary: 6/166 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Xu Kuohai <xukuohai@huawei.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Tested-by: Florent Revest <revest@chromium.org> Acked-by: Yonghong Song <yonghong.song@linux.dev> Acked-by: Florent Revest <revest@chromium.org> Link: https://lore.kernel.org/bpf/20230815154158.717901-8-xukuohai@huaweicloud.com
oder-chiou pushed a commit
to oder-chiou/linux-soundwire
that referenced
this pull request
May 5, 2026
Add a test case which replaces an active ingress qdisc while keeping the miniq in-tact during the transition period to the new clsact qdisc. # ./vmtest.sh -- ./test_progs -t tc_link [...] ./test_progs -t tc_link [ 3.412871] bpf_testmod: loading out-of-tree module taints kernel. [ 3.413343] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel thesofproject#332 tc_links_after:OK thesofproject#333 tc_links_append:OK thesofproject#334 tc_links_basic:OK thesofproject#335 tc_links_before:OK thesofproject#336 tc_links_chain_classic:OK thesofproject#337 tc_links_chain_mixed:OK thesofproject#338 tc_links_dev_chain0:OK thesofproject#339 tc_links_dev_cleanup:OK thesofproject#340 tc_links_dev_mixed:OK thesofproject#341 tc_links_ingress:OK thesofproject#342 tc_links_invalid:OK thesofproject#343 tc_links_prepend:OK thesofproject#344 tc_links_replace:OK thesofproject#345 tc_links_revision:OK Summary: 14/0 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Cc: Martin KaFai Lau <martin.lau@kernel.org> Link: https://lore.kernel.org/r/20240708133130.11609-2-daniel@iogearbox.net Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
oder-chiou pushed a commit
to oder-chiou/linux-soundwire
that referenced
this pull request
May 5, 2026
Current code will validate current plane and previous plane to confirm they can share a SSPP with multi-rect mode. The SSPP is already allocated for previous plane, while current plane is not associated with any SSPP yet. Null pointer is referenced when validating the SSPP of current plane. Skip SSPP validation for current plane. Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020 Mem abort info: ESR = 0x0000000096000004 EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 FSC = 0x04: level 0 translation fault Data abort info: ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 CM = 0, WnR = 0, TnD = 0, TagAccess = 0 GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 user pgtable: 4k pages, 48-bit VAs, pgdp=0000000888ac3000 [0000000000000020] pgd=0000000000000000, p4d=0000000000000000 Internal error: Oops: 0000000096000004 [thesofproject#1] SMP Modules linked in: CPU: 4 UID: 0 PID: 1891 Comm: modetest Tainted: G S 6.15.0-rc2-g3ee3f6e1202e thesofproject#335 PREEMPT Tainted: [S]=CPU_OUT_OF_SPEC Hardware name: SM8650 EV1 rev1 4slam 2et (DT) pstate: 63400009 (nZCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) pc : dpu_plane_is_multirect_capable+0x68/0x90 lr : dpu_assign_plane_resources+0x288/0x410 sp : ffff800093dcb770 x29: ffff800093dcb770 x28: 0000000000002000 x27: ffff000817c6c000 x26: ffff000806b46368 x25: ffff0008013f6080 x24: ffff00080cbf4800 x23: ffff000810842680 x22: ffff0008013f1080 x21: ffff00080cc86080 x20: ffff000806b463b0 x19: ffff00080cbf5a00 x18: 00000000ffffffff x17: 707a5f657a696c61 x16: 0000000000000003 x15: 0000000000002200 x14: 00000000ffffffff x13: 00aaaaaa00aaaaaa x12: 0000000000000000 x11: ffff000817c6e2b8 x10: 0000000000000000 x9 : ffff80008106a950 x8 : ffff00080cbf48f4 x7 : 0000000000000000 x6 : 0000000000000000 x5 : 0000000000000000 x4 : 0000000000000438 x3 : 0000000000000438 x2 : ffff800082e245e0 x1 : 0000000000000008 x0 : 0000000000000000 Call trace: dpu_plane_is_multirect_capable+0x68/0x90 (P) dpu_crtc_atomic_check+0x5bc/0x650 drm_atomic_helper_check_planes+0x13c/0x220 drm_atomic_helper_check+0x58/0xb8 msm_atomic_check+0xd8/0xf0 drm_atomic_check_only+0x4a8/0x968 drm_atomic_commit+0x50/0xd8 drm_atomic_helper_update_plane+0x140/0x188 __setplane_atomic+0xfc/0x148 drm_mode_setplane+0x164/0x378 drm_ioctl_kernel+0xc0/0x140 drm_ioctl+0x20c/0x500 __arm64_sys_ioctl+0xbc/0xf8 invoke_syscall+0x50/0x120 el0_svc_common.constprop.0+0x48/0xf8 do_el0_svc+0x28/0x40 el0_svc+0x30/0xd0 el0t_64_sync_handler+0x144/0x168 el0t_64_sync+0x198/0x1a0 Code: b9402021 370fffc1 f9401441 3707ff81 (f94010a1) ---[ end trace 0000000000000000 ]--- Fixes: 3ed12a3 ("drm/msm/dpu: allow sharing SSPP between planes") Signed-off-by: Jun Nie <jun.nie@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/669224/ Link: https://lore.kernel.org/r/20250819-v6-16-rc2-quad-pipe-upstream-v15-1-2c7a85089db8@linaro.org Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comments on the link DMA support to indicate the current solution is not quite final.
Also fix two issues detected during code reviews (36 patches!), we had 2 issues with error flows for the code loader and the PCM handling. @bardliao you may want to check if the PCM part impacts the load/unload work you are doing.
An additional issue was fixed already by Seppo in a separate PR.