Skip to content

fixup! ASoC: SOF: Introduce struct snd_sof_pipeline - #3984

Merged
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
ranj063:sof-dev-110122
Nov 2, 2022
Merged

fixup! ASoC: SOF: Introduce struct snd_sof_pipeline#3984
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
ranj063:sof-dev-110122

Conversation

@ranj063

@ranj063ranj063 commented Nov 2, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Clear the complete flag for pipelines when the scheduler widget is freed.

Fixes#3983

@ranj063
fixup! ASoC: SOF: Introduce struct snd_sof_pipeline
e630ab4
Clear the complete flag for pipelines when the scheduler widget is
freed.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
ranj063 marked this pull request as ready for review November 2, 2022 02:39
@keqiaozhang

keqiaozhang commented Nov 2, 2022

Copy link
Copy Markdown

Verified that this PR can fix #3983.

@plbossart

plbossart commented Nov 2, 2022

Copy link
Copy Markdown
Member

I don't know what to make of the results @ranj063@keqiaozhang TGLU_UP_HDA_IPC4ZPH is a fail on multiple tests.

@ujfalusi

ujfalusi commented Nov 2, 2022

Copy link
Copy Markdown
Collaborator

I don't know what to make of the results @ranj063@keqiaozhang TGLU_UP_HDA_IPC4ZPH is a fail on multiple tests.

I think what happened is that multiple-pipeline-playback.sh failed - firmware crash - (if it is because of this PR or not is a question) since we prevent powering down the DSP to preserve the DSP state. Consecutive tests fail since the DSP is kept powered in crashed state. With IPC4/Zephyr we don't have panic interrupt/message so we can not force a DSP power cycle.

Let me check it locally, it should be easy to hit.

ujfalusi
ujfalusi reviewed Nov 2, 2022
View reviewed changes
Comment threadsound/soc/sof/sof-audio.c

/* clear pipeline complete */
if (swidget->id == snd_soc_dapm_scheduler)
swidget->spipe->complete = 0;

@ujfalusiujfalusiNov 2, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a pipeline belong to different paths?

@ranj063ranj063Nov 2, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ujfalusi yes it can and the scheduler widget will be freed only when the last of all the users lets it go

@ujfalusi

ujfalusi commented Nov 2, 2022

Copy link
Copy Markdown
Collaborator

Let me check it locally, it should be easy to hit.

No crash so far after 46 iteration.

@ranj063

ranj063 commented Nov 2, 2022

Copy link
Copy Markdown
CollaboratorAuthor

I don't know what to make of the results @ranj063@keqiaozhang TGLU_UP_HDA_IPC4ZPH is a fail on multiple tests.

@plbossart IPC4 failures are due toe the chaind DAM SOF PR which shouldnt have been merged. There's a revert for that as well

@ranj063

ranj063 commented Nov 2, 2022

Copy link
Copy Markdown
CollaboratorAuthor

I don't know what to make of the results @ranj063@keqiaozhang TGLU_UP_HDA_IPC4ZPH is a fail on multiple tests.

I think what happened is that multiple-pipeline-playback.sh failed - firmware crash - (if it is because of this PR or not is a question) since we prevent powering down the DSP to preserve the DSP state. Consecutive tests fail since the DSP is kept powered in crashed state. With IPC4/Zephyr we don't have panic interrupt/message so we can not force a DSP power cycle.

Let me check it locally, it should be easy to hit.

it is because of the SOF PR for chained DMA that was merged a bit too early

@plbossart

plbossart commented Nov 2, 2022

Copy link
Copy Markdown
Member

@ujfalusi any objections here? this needs to go in before 2pm PDT to fix daily tests

@plbossart
plbossart merged commit 2ff6aa4 into thesofproject:topic/sof-devNov 2, 2022
@plbossartplbossart mentioned this pull request Nov 3, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ujfalusiujfalusiujfalusi left review comments
@plbossartplbossartplbossart approved these changes
@bardliaobardliaobardliao approved these changes
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood is a code owner
@kv2019ikv2019iAwaiting requested review from kv2019ikv2019i is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@ajitkupandeyajitkupandeyAwaiting requested review from ajitkupandey
@kuanhsunchengkuanhsunchengAwaiting requested review from kuanhsuncheng
@yaochunhungyaochunhungAwaiting requested review from yaochunhung

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG][ADL][TGL] playback failed at the second run with ipc tx error for 0x60010000 GLB_STREAM_MSG: PCM_PARAMS

5 participants

@ranj063@keqiaozhang@plbossart@ujfalusi@bardliao