Uh oh!
There was an error while loading. Please reload this page.
ASoC: SOF: ipc4-topology: update pipeline_params in process prepare - #4185
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lgirdwood
commented
Feb 14, 2023
@ranj063 any update ? |
Uh oh!
There was an error while loading. Please reload this page.
Copy the output format only if the returned index is less than the available number of output formats and it is meant for Pin 0. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
…format count Initialize the input format in the base config only if a module has input formats available. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Some modules may modify the audio format during processing. So, update the pipeline params based on pin 0's output format during process prepare. Signed-off-by: Libin Yang <libin.yang@intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
9e23068 to
a6a7837Compare
plbossart
left a comment
There was a problem hiding this comment.
I can't pretend I fully understand what's behind this PR but the code looks good to me.
ranj063
commented
Feb 15, 2023
@ujfalusi could you please take a look at this one? |
ujfalusi
commented
Feb 16, 2023
@ranj063, there is a firmware crash on ADLP: |
ujfalusi
commented
Feb 16, 2023
SOFCI TEST |
| sizeof(struct sof_ipc4_audio_format)); | ||
| /* copy Pin 0 output format */ | ||
| if (available_fmt->num_output_formats && ret < available_fmt->num_output_formats && | ||
| !available_fmt->output_pin_fmts[ret].pin_index) |
There was a problem hiding this comment.
nitpick: it would be cleaner to available_fmt->output_pin_fmts[ret].pin_index == 0 as the comment is also telling that we are looking for pin0
There was a problem hiding this comment.
pin_index is a u32, so !available_fmt->output_pin_fmts[ret].pin_index == 0 is doing the same no?
There was a problem hiding this comment.
I know, they do the same thing, I was just saying that in this context !pin_index is not easily translates to the intention of pin_index == 0.
It was a nitpick observation.
Some modules may modify the audio format during processing. So, update the pipeline params based on pin 0's output format during process prepare.
Signed-off-by: Libin Yang libin.yang@intel.com
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com