ASoC: SOF: ipc4-topology: Always validate the audio format on fmt init by ujfalusi · Pull Request #5435 · thesofproject/linux

ujfalusi · 2025-05-30T13:16:58Z

Even if there is a single format supported by the module on it's input or output, it must be validated that it is matching with the reference parameters.

The DAI copier's DAI side reference is adjusted to the formats it supports, but modules deep within the path might have incorrect configuration in topology (single format which is not matching with the previous module's output for example). This should be reported as errors and not silently accepted.

ujfalusi · 2025-06-02T09:24:09Z

Changes since v1:

Only do the validation on input side, modules can do conversion and it is forced by a non matching output (static, single) format.

singalsu

Thanks, prior to this it was possible capture with a format that was not fully implemented into a topology and get a corrupt recording. I tested successfully today multi-channel use cases with this patch, #5441 and #5442.

bardliao · 2025-06-23T12:16:44Z

SOFCI TEST

ujfalusi · 2025-06-23T13:42:47Z

Changes since v2:

rebased on 8-bit format support

ranj063 · 2025-06-24T00:08:37Z

@ujfalusi are the LNL/pTL failures related to the PR?

ujfalusi · 2025-06-24T08:03:39Z

@ujfalusi are the LNL/pTL failures related to the PR?

They are, but not sure why...

[ 326.327500] kernel: snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-lnl 0000:00:1f.3: Dai copier alh-copier.SDW2-Capture.0, type 28, ChainDMA: no
[ 326.327509] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: sof_ipc4_init_input_audio_fmt: Unsupported audio format: 48000Hz, 24bit, 4 channels
[ 326.327581] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: failed to prepare widget alh-copier.SDW2-Capture.0
[ 326.327614] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: Failed to prepare connected widgets
[ 326.327643] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: sof_pcm_setup_connected_widgets: pcm3 (Amp feedback), dir 1: widget list prepare failed
[ 326.327683] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: ASoC error (-22): at snd_soc_pcm_component_hw_params() on 0000:00:1f.3
[ 326.327765] kernel: Amp feedback: ASoC error (-22): at __soc_pcm_hw_params() on Amp feedback

4 channels????

ujfalusi · 2025-06-24T08:15:55Z

@ujfalusi are the LNL/pTL failures related to the PR?

They are, but not sure why...

[ 326.327500] kernel: snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-lnl 0000:00:1f.3: Dai copier alh-copier.SDW2-Capture.0, type 28, ChainDMA: no
[ 326.327509] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: sof_ipc4_init_input_audio_fmt: Unsupported audio format: 48000Hz, 24bit, 4 channels
[ 326.327581] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: failed to prepare widget alh-copier.SDW2-Capture.0
[ 326.327614] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: Failed to prepare connected widgets
[ 326.327643] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: sof_pcm_setup_connected_widgets: pcm3 (Amp feedback), dir 1: widget list prepare failed
[ 326.327683] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: ASoC error (-22): at snd_soc_pcm_component_hw_params() on 0000:00:1f.3
[ 326.327765] kernel: Amp feedback: ASoC error (-22): at __soc_pcm_hw_params() on Amp feedback

4 channels????

it is not the 4 channels, but the 24bits, the alh-copier.SDW2-Capture.0 only supports 32bit and single format, so now that we check the input fmt for single format as well we see that 24bit is asked and we would have used 32bit, so the fmt is not supported:

Jun 23 15:09:15 gk-lnlm-rvp-06 kernel: snd_sof:sof_ipc4_widget_setup_comp_dai: sof-audio-pci-intel-lnl 0000:00:1f.3: Updating IPC structure for alh-copier.SDW2-Capture.0
Jun 23 15:09:15 gk-lnlm-rvp-06 kernel: snd_sof:sof_ipc4_get_audio_fmt: sof-audio-pci-intel-lnl 0000:00:1f.3: Number of input audio formats: 1. Number of output audio formats: 1
Jun 23 15:09:15 gk-lnlm-rvp-06 kernel: snd_sof:sof_ipc4_get_audio_fmt: sof-audio-pci-intel-lnl 0000:00:1f.3: widget alh-copier.SDW2-Capture.0: is_pages: 1
Jun 23 15:09:15 gk-lnlm-rvp-06 kernel: snd_sof:sof_ipc4_get_audio_fmt: sof-audio-pci-intel-lnl 0000:00:1f.3: Input audio formats for alh-copier.SDW2-Capture.0
Jun 23 15:09:15 gk-lnlm-rvp-06 kernel: snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-lnl 0000:00:1f.3: Pin #0: 48000Hz, 32bit, 4ch (ch_map 0xffff3210 ch_cfg 4 interleaving_style 0 fmt_cfg 0x1804) buffer size 768
Jun 23 15:09:15 gk-lnlm-rvp-06 kernel: snd_sof:sof_ipc4_get_audio_fmt: sof-audio-pci-intel-lnl 0000:00:1f.3: Output audio formats for alh-copier.SDW2-Capture.0
Jun 23 15:09:15 gk-lnlm-rvp-06 kernel: snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-lnl 0000:00:1f.3: Pin #0: 48000Hz, 32bit, 4ch (ch_map 0xffff3210 ch_cfg 4 interleaving_style 0 fmt_cfg 0x12004) buffer size 768
Jun 23 15:09:15 gk-lnlm-rvp-06 kernel: snd_sof:sof_ipc4_widget_setup_comp_dai: sof-audio-pci-intel-lnl 0000:00:1f.3: dai alh-copier.SDW2-Capture.0 node_type 17 dai_type 4 dai_index 0

@singalsu , any idea?

singalsu · 2025-06-24T08:32:23Z

any idea?

Is that a topology issue, would it work if we add to alh copier the 24 bit format?

ujfalusi · 2025-06-24T08:32:59Z

any idea?
Is that a topology issue, would it work if we add to alh copier the 24 bit format?

Yes, that would fix the issue

ujfalusi · 2025-06-24T10:55:18Z

[ 1038.199172] [peter] sof_ipc4_init_input_audio_fmt: 48000Hz/24bit/4ch/1type VS 48000Hz/24bit/4ch/0type

The type differs for the same format:
SNDRV_PCM_FORMAT_S24_LE -> SOF_IPC4_TYPE_LSB_INTEGER (1)
SOF_IPC4_AUDIO_FORMAT_CFG_SAMPLE_TYPE(fmt->fmt_cfg) -> SOF_IPC4_TYPE_MSB_INTEGER (0)

In topologies the type is set to MSB mostly, but some random places uses LSB.

So, this PR is correct

…mt init Even if there is a single format supported by the module on it's input, it must be validated that it is matching with the reference parameters. The DAI copier's DAI side reference is adjusted to the formats it supports, but modules deep within the path might have incorrect configuration in topology (single format which is not matching with the previous module's output for example). This should be reported as errors and not silently accepted. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

ujfalusi · 2025-06-26T07:22:36Z

Changes since v3:

rebased again on top of the fmt fix

singalsu · 2025-06-27T08:22:16Z

This patch is needed to be able to support channels up/downmix in firmware. It's needed for thesofproject/sof#10071 .

lyakh · 2025-06-27T08:28:40Z

 if (params_rate(params) == rate && params_channels(params) == channels &&
 sample_valid_bits == valid_bits && sample_type == type)
-break;
+goto in_fmt;


stylistically I think the commonly used pattern, where goto is only used for error handling is clearer. IIUC this change is using goto to jump to a success case continuation, while handling the error on the main code path. Also it doesn't seem to be related to the fix. The actual fix seems to be removing the lines 1579-1582 (and removing the jump label), that would also make the patch smaller

In fact the code - including the return statement - after in_fmt: label could be added here in side this if statement, and the loop would still be reasonable size. But IMO not a big deal.

right, I converted this function to work and look like the coutnerpart sof_ipc4_init_output_audio_fmt().
I can keep the two function different, but I cannot change the output function when touching the input.

jsarha · 2025-06-27T08:43:13Z

 if (params_rate(params) == rate && params_channels(params) == channels &&
 sample_valid_bits == valid_bits && sample_type == type)
-break;
+goto in_fmt;


In fact the code - including the return statement - after in_fmt: label could be added here in side this if statement, and the loop would still be reasonable size. But IMO not a big deal.

ranj063 · 2025-06-27T16:15:00Z

@bardliao please feel free to merge if you're good

bardliao · 2025-06-30T02:42:50Z

@ujfalusi Could you take a look at the NOCODEC CI issues?
https://sof-ci.01.org/linuxpr/PR5435/build8152/devicetest/index.html
https://sof-ci.01.org/linuxpr/PR5435/build8150/devicetest/index.html
https://sof-ci.01.org/linuxpr/PR5435/build8151/devicetest/index.html
Looks like multiple-pause-resume-50.sh, multiple-pipeline-capture.sh, and multiple-pipeline-all.sh are failed.

ujfalusi · 2025-06-30T06:50:23Z

@ujfalusi Could you take a look at the NOCODEC CI issues? https://sof-ci.01.org/linuxpr/PR5435/build8152/devicetest/index.html https://sof-ci.01.org/linuxpr/PR5435/build8150/devicetest/index.html https://sof-ci.01.org/linuxpr/PR5435/build8151/devicetest/index.html Looks like multiple-pause-resume-50.sh, multiple-pipeline-capture.sh, and multiple-pipeline-all.sh are failed.

something is not right, but it is not this patch, it is correctly flagging that
https://sof-ci.01.org/linuxpr/PR5435/build8152/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=multiple-pipeline-capture
arecord -D hw:0,12 -c 2 -r 48000 -f S16_LE /dev/null -q

host-copier.12.capture does not support 16bit input format (only 32bit on in)
If we go back:
dai-copier.SSP.NoCodec-0.capture is configured with 32bit in/out (only supports 32bit on in/out)
gain.8.1 is configured with 32bit in/out (only supports 32bit on in/out)
module-copier.8.2 is configured with 32bit in/out (only supports 32bit on in/out)
module-copier.17.2 is configured with 16bit in/out (supports 16bit and 32bit on in/out) !!!! BUG BUG BUG BUG !!!!
gain.17.1 is configured with 16bit in/out (supports 16bit and 32bit on in/out)
host-copier.12.capture fail for 16bit since it only supports 32bit on input, but supports 16, 24, 32bit on output

The bug happens at module-copier.17.2 which is not caused by this PR since this PR forces format check if there is a single input format present (this is why we fail at the end at host copier).
In the daily test I cannot see hw:0,12 been opened, so it is not tested, I cannot crosscheck, but let me look for PR runs...

ujfalusi · 2025-06-30T06:58:37Z

@bardliao , found in daily:
https://sof-ci.ostc.intel.com/#/result/planresultdetail/54823?model=MTLP_RVP_NOCODEC&testcase=multiple-pipeline-capture-50

arecord -D hw:0,12 -c 2 -r 48000 -f S16_LE /dev/null -q

If we go back:
dai-copier.SSP.NoCodec-0.capture is configured with 32bit in/out (only supports 32bit on in/out)
gain.8.1 is configured with 32bit in/out (only supports 32bit on in/out)
module-copier.8.2 is configured with 32bit in/out (only supports 32bit on in/out)
module-copier.17.2 is configured with 16bit in/out (supports 16bit and 32bit on in/out) !!!! BUG BUG BUG BUG !!!!
gain.17.1 is configured with 16bit in/out (supports 16bit and 32bit on in/out)
host-copier.12.capture is configured with 32bit input and 16bit output !!!! SILENT BUG !!!!

So, the bug is at module-copier.17.2

ujfalusi · 2025-06-30T08:10:02Z

sof-tgl-nocodec.tplg is working fine, but it looks identical.

ujfalusi · 2025-06-30T08:49:13Z

OK, I can reproduce this on topic/sof-dev.
This works correctly:

arecord -D hw:0,12 -c 2 -r 48000 -f S16_LE /dev/null -q

log:

[ 36.969475] snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-tgl 0000:00:1f.3: Module copier module-copier.17.2, type 31
[ 36.969484] snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-tgl 0000:00:1f.3: copier module-copier.17.2, IPC size is 84
[ 36.969491] snd_sof:sof_ipc4_dbg_module_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Audio format (in/out format index: 1/0) for module-copier.17.2:
[ 36.969499] snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Pin #0: 48000Hz, 32bit, 2ch (ch_map 0xffffff10 ch_cfg 1 interleaving_style 0 fmt_cfg 0x12002) buffer size 384
[ 36.969531] snd_sof:sof_ipc4_update_cpc_from_manifest: sof-audio-pci-intel-tgl 0000:00:1f.3: COPIER (UUID: 9BA00C83-CA12-4A83-943C-1FA2E82F9DDA): No CPC value available in the firmware file's manifest (ibs/obs: 384/384)
[ 36.969540] snd_sof:sof_ipc4_update_resource_usage: sof-audio-pci-intel-tgl 0000:00:1f.3: module-copier.17.2: ibs / obs / cpc: 384 / 384 / 0
[ 36.969548] snd_sof:sof_ipc4_dbg_module_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Audio format (in/out format index: 1/0) for gain.17.1:
[ 36.969555] snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Pin #0: 48000Hz, 32bit, 2ch (ch_map 0xffffff10 ch_cfg 1 interleaving_style 0 fmt_cfg 0x12002) buffer size 384
[ 36.969563] snd_sof:sof_ipc4_update_cpc_from_manifest: sof-audio-pci-intel-tgl 0000:00:1f.3: GAIN (UUID: 61BCA9A8-18D0-4A18-8E7B-2639219804B7): No CPC value available in the firmware file's manifest (ibs/obs: 384/384)
[ 36.969594] snd_sof:sof_ipc4_update_resource_usage: sof-audio-pci-intel-tgl 0000:00:1f.3: gain.17.1: ibs / obs / cpc: 384 / 384 / 0
[ 36.969602] snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-tgl 0000:00:1f.3: Host copier host-copier.12.capture, type 24, ChainDMA: no, stream_tag: 1
[ 36.969613] snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-tgl 0000:00:1f.3: copier host-copier.12.capture, IPC size is 84
[ 36.969621] snd_sof:sof_ipc4_dbg_module_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Input audio format for host-copier.12.capture:
[ 36.969627] snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Pin #0: 48000Hz, 32bit, 2ch (ch_map 0xffffff10 ch_cfg 1 interleaving_style 0 fmt_cfg 0x12002) buffer size 384
[ 36.969644] snd_sof:sof_ipc4_dbg_module_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Output audio format (format index: 1) for host-copier.12.capture:
[ 36.969651] snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Pin #0: 48000Hz, 16bit, 2ch (ch_map 0xffffff10 ch_cfg 1 interleaving_style 0 fmt_cfg 0x11002) buffer size 192
[ 36.969660] snd_sof:sof_ipc4_update_cpc_from_manifest: sof-audio-pci-intel-tgl 0000:00:1f.3: COPIER (UUID: 9BA00C83-CA12-4A83-943C-1FA2E82F9DDA): No CPC value available in the firmware file's manifest (ibs/obs: 384/192)
[ 36.969668] snd_sof:sof_ipc4_update_resource_usage: sof-audio-pci-intel-tgl 0000:00:1f.3: host-copier.12.capture: ibs / obs / cpc: 384 / 192 / 0

The 0,12 will misconfigure:

terminal 1: arecord -D hw:0,0 -c 2 -r 48000 -f S16_LE /dev/null -q
terminal 2: arecord -D hw:0,12 -c 2 -r 48000 -f S16_LE /dev/null -q

like this:

[ 361.231201] snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-tgl 0000:00:1f.3: Module copier module-copier.17.2, type 31
[ 361.231213] snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-tgl 0000:00:1f.3: copier module-copier.17.2, IPC size is 84
[ 361.231222] snd_sof:sof_ipc4_dbg_module_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Audio format (in/out format index: 0/1) for module-copier.17.2:
[ 361.231230] snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Pin #0: 48000Hz, 16bit, 2ch (ch_map 0xffffff10 ch_cfg 1 interleaving_style 0 fmt_cfg 0x11002) buffer size 192
[ 361.231244] snd_sof:sof_ipc4_update_cpc_from_manifest: sof-audio-pci-intel-tgl 0000:00:1f.3: COPIER (UUID: 9BA00C83-CA12-4A83-943C-1FA2E82F9DDA): No CPC value available in the firmware file's manifest (ibs/obs: 192/192)
[ 361.231257] snd_sof:sof_ipc4_update_resource_usage: sof-audio-pci-intel-tgl 0000:00:1f.3: module-copier.17.2: ibs / obs / cpc: 192 / 192 / 0
[ 361.231267] snd_sof:sof_ipc4_dbg_module_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Audio format (in/out format index: 0/1) for gain.17.1:
[ 361.231275] snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Pin #0: 48000Hz, 16bit, 2ch (ch_map 0xffffff10 ch_cfg 1 interleaving_style 0 fmt_cfg 0x11002) buffer size 192
[ 361.231287] snd_sof:sof_ipc4_update_cpc_from_manifest: sof-audio-pci-intel-tgl 0000:00:1f.3: GAIN (UUID: 61BCA9A8-18D0-4A18-8E7B-2639219804B7): No CPC value available in the firmware file's manifest (ibs/obs: 192/192)
[ 361.231291] snd_sof:sof_ipc4_update_resource_usage: sof-audio-pci-intel-tgl 0000:00:1f.3: gain.17.1: ibs / obs / cpc: 192 / 192 / 0
[ 361.231294] snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-tgl 0000:00:1f.3: Host copier host-copier.12.capture, type 24, ChainDMA: no, stream_tag: 2
[ 361.231299] snd_sof:sof_ipc4_prepare_copier_module: sof-audio-pci-intel-tgl 0000:00:1f.3: copier host-copier.12.capture, IPC size is 84
[ 361.231303] snd_sof:sof_ipc4_dbg_module_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Input audio format for host-copier.12.capture:
[ 361.231305] snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Pin #0: 48000Hz, 32bit, 2ch (ch_map 0xffffff10 ch_cfg 1 interleaving_style 0 fmt_cfg 0x12002) buffer size 384
[ 361.231309] snd_sof:sof_ipc4_dbg_module_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Output audio format (format index: 1) for host-copier.12.capture:
[ 361.231312] snd_sof:sof_ipc4_dbg_audio_format: sof-audio-pci-intel-tgl 0000:00:1f.3: Pin #0: 48000Hz, 16bit, 2ch (ch_map 0xffffff10 ch_cfg 1 interleaving_style 0 fmt_cfg 0x11002) buffer size 192
[ 361.231315] snd_sof:sof_ipc4_update_cpc_from_manifest: sof-audio-pci-intel-tgl 0000:00:1f.3: COPIER (UUID: 9BA00C83-CA12-4A83-943C-1FA2E82F9DDA): No CPC value available in the firmware file's manifest (ibs/obs: 384/192)
[ 361.231319] snd_sof:sof_ipc4_update_resource_usage: sof-audio-pci-intel-tgl 0000:00:1f.3: host-copier.12.capture: ibs / obs / cpc: 384 / 192 / 0

ujfalusi · 2025-06-30T09:04:03Z

Right, I think this has never worked correctly and I do have a fix for this rolled since May 2024....
ujfalusi@0bd977e

Basically the issue is that we don't really support this type of branch.
We skip the already configured module instances and thus we have no idea how they are configured:

module-copier.8.2 is configured by the first capture to :0,0 and it is set to input/output 32bit, when the capture to :0,12 starts we skip up to module-copier.8.2 and use the host params as reference as this is the best guess we have at this point. Since the copier supports 16bit, we use that as input/output.

ujfalusi · 2025-06-30T11:04:02Z

@bardliao, this fixes the issue on topology level: thesofproject/sof#10081

ujfalusi · 2025-06-30T13:32:31Z

OK, so that is not fixing the issue, we will need to: #5471

ujfalusi · 2025-08-07T13:04:03Z

SOFCI TEST

ujfalusi requested review from bardliao, dbaluta, kv2019i, lgirdwood, plbossart and ranj063 as code owners May 30, 2025 13:16

ujfalusi requested a review from singalsu May 30, 2025 13:17

ujfalusi force-pushed the peter/sof/pr/validate-in-out-fmt-at-init-01 branch from b7f545c to 71da2a6Compare June 2, 2025 09:23

singalsu approved these changes Jun 3, 2025
View reviewed changes

This was referenced Jun 3, 2025
ASoC: SOF: ipc4-pcm: Add fixup for channels #5441
Merged
ASoC: SOF: ipc4-topology: Correct the process module's output lookup #5442
Merged

ranj063 previously approved these changes Jun 3, 2025
View reviewed changes

lgirdwood previously approved these changes Jun 23, 2025
View reviewed changes

ujfalusi dismissed stale reviews from lgirdwood and ranj063 via 15ace47June 23, 2025 13:42

ujfalusi force-pushed the peter/sof/pr/validate-in-out-fmt-at-init-01 branch from 71da2a6 to 15ace47Compare June 23, 2025 13:42

singalsu mentioned this pull request Jun 25, 2025
fixup! ASoC: SOF: ipc4-topology: Add support for 8-bit formats #5466
Merged

ujfalusi force-pushed the peter/sof/pr/validate-in-out-fmt-at-init-01 branch from 15ace47 to fbea2d8Compare June 26, 2025 07:22

bardliao approved these changes Jun 27, 2025
View reviewed changes

lyakh reviewed Jun 27, 2025
View reviewed changes

jsarha approved these changes Jun 27, 2025
View reviewed changes

lgirdwood approved these changes Jun 27, 2025
View reviewed changes

ranj063 approved these changes Jun 27, 2025
View reviewed changes

ujfalusi mentioned this pull request Jun 30, 2025
Tools: Topology2: cavs-nocodec: Fix formats for Port0 first/second ca… thesofproject/sof#10081
Merged

bardliao merged commit 9c9d463 into thesofproject:topic/sof-devOct 1, 2025
2 of 7 checks passed

Uh oh!

Conversation

ujfalusi commented May 30, 2025

Uh oh!

ujfalusi commented Jun 2, 2025

Uh oh!

singalsu left a comment

Choose a reason for hiding this comment

Uh oh!

bardliao commented Jun 23, 2025

Uh oh!

ujfalusi commented Jun 23, 2025

Uh oh!

ranj063 commented Jun 24, 2025

Uh oh!

ujfalusi commented Jun 24, 2025

Uh oh!

ujfalusi commented Jun 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

singalsu commented Jun 24, 2025

Uh oh!

ujfalusi commented Jun 24, 2025

Uh oh!

ujfalusi commented Jun 24, 2025

Uh oh!

ujfalusi commented Jun 26, 2025

Uh oh!

singalsu commented Jun 27, 2025

Uh oh!

lyakhJun 27, 2025

Choose a reason for hiding this comment

Uh oh!

jsarhaJun 27, 2025

Choose a reason for hiding this comment

Uh oh!

ujfalusiJun 27, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsarhaJun 27, 2025

Choose a reason for hiding this comment

Uh oh!

ranj063 commented Jun 27, 2025

Uh oh!

bardliao commented Jun 30, 2025

Uh oh!

ujfalusi commented Jun 30, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ujfalusi commented Jun 30, 2025

Uh oh!

ujfalusi commented Jun 30, 2025

Uh oh!

ujfalusi commented Jun 30, 2025

Uh oh!

ujfalusi commented Jun 30, 2025

Uh oh!

ujfalusi commented Jun 30, 2025

Uh oh!

ujfalusi commented Jun 30, 2025

Uh oh!

ujfalusi commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ujfalusi commented Jun 24, 2025•
edited
Loading

ujfalusiJun 27, 2025•
edited
Loading

ujfalusi commented Jun 30, 2025•
edited
Loading