Skip to content

Enable sof-docs deploy in GitHub Actions - #324

Merged
lgirdwood merged 3 commits into
thesofproject:masterfrom
xiulipan:pr/ghdeploy2
Feb 3, 2021
Merged

Enable sof-docs deploy in GitHub Actions#324
lgirdwood merged 3 commits into
thesofproject:masterfrom
xiulipan:pr/ghdeploy2

Conversation

@xiulipan

@xiulipanxiulipan commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

spilt from #321
depend on #323 as the deploy job needs build job.

@xiulipan
CI: disable Travis to avoid depoly conflict
7325c10
Will use GitHub Action to do deploy.
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipanxiulipan mentioned this pull request Feb 2, 2021
Closed
lgirdwood
lgirdwood reviewed Feb 2, 2021
View reviewed changes
Comment thread.github/actions/create-publish-folder.sh Outdated
Comment thread.github/workflows/pull-request.yml
marc-hb
marc-hb approved these changes Feb 3, 2021
View reviewed changes

@marc-hbmarc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it works

Comment thread.github/workflows/pull-request.yml
Comment thread.github/workflows/pull-request.yml Outdated
marc-hb
marc-hb reviewed Feb 3, 2021
View reviewed changes
Comment thread.github/workflows/pull-request.yml Outdated
@marc-hb

marc-hb commented Feb 3, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

depend on #323 as the deploy job needs build job.

One-line change, fixed, Github Actions now passing. Please rebase #323 on top of this after it's merged. One-line conflict.

git fetch origin pull/324/head
git checkout FETCH_HEAD
git rebase -i HEAD~3 # two fixups
git push -f ... ghdeploy2

@xiulipan
CI: GitHub: add local action to create publish folder
b87e76d
use local action to create publish folder for local test
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipan
CI: GitHub: enable action to deploy
01b7b52
use public action https://github.com/marketplace/actions/github-pages-action
to deploy HTML to our github.io repo when we make a push to publish branch
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipan

xiulipan commented Feb 3, 2021

Copy link
Copy Markdown
ContributorAuthor

@lgirdwood Update and fix newline issue.
@marc-hb rebased with the order that we will merge #324 first.
@deb-intel@intelkevinputnam Please help review and merge

@lgirdwood
lgirdwood merged commit abab289 into thesofproject:masterFeb 3, 2021
@marc-hbmarc-hb mentioned this pull request Feb 3, 2021
Closed
@xiulipan
xiulipan deleted the pr/ghdeploy2 branch February 4, 2021 03:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-hbmarc-hbmarc-hb approved these changes
@lgirdwoodlgirdwoodlgirdwood approved these changes
@deb-inteldeb-intelAwaiting requested review from deb-inteldeb-intel is a code owner
@intelkevinputnamintelkevinputnamAwaiting requested review from intelkevinputnamintelkevinputnam is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiulipan@marc-hb@lgirdwood