Skip to content

intel_debug: add suggestions for DMIC and ES8336 platforms - #420

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
plbossart:fix/hdaudio-dmic-bugs
Jul 12, 2022
Merged

intel_debug: add suggestions for DMIC and ES8336 platforms#420
lgirdwood merged 1 commit into
thesofproject:masterfrom
plbossart:fix/hdaudio-dmic-bugs

Conversation

@plbossart

@plbossartplbossart commented Jul 6, 2022

Copy link
Copy Markdown
Member

Instead of repeating the same things on GitHub issues, maybe this
documentation will help.

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

@plbossart

plbossart commented Jul 6, 2022

Copy link
Copy Markdown
MemberAuthor

not checked due to problem on Ubuntu 22.04

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
sphinx-tabs 3.3.1 requires docutils~=0.17.0, but you have docutils 0.16 which is incompatible.

@plbossart
plbossart requested review from ranj063 and ujfalusiJuly 6, 2022 20:45
lgirdwood
lgirdwood reviewed Jul 6, 2022
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think @marc-hb has been looking at the recent content generation issues and the pip issue may be related.

Comment threadgetting_started/intel_debug/suggestions.rst Outdated
Comment threadgetting_started/intel_debug/suggestions.rst Outdated
@marc-hb

marc-hb commented Jul 7, 2022

Copy link
Copy Markdown
Collaborator

https://github.com/thesofproject/sof-docs/runs/7222607705

I submitted a fix in sof for these 2 doxygen errorsplease help review and expedite: thesofproject/sof#5995

/home/runner/work/sof-docs/sof-docs/api/dai-drivers-api.rst:4: WARNING: Duplicate ID: "group__sof__dai__drivers_1ga8c720c310f408b2f97ce014562d6a910".
/home/runner/work/sof-docs/sof-docs/api/dai-drivers-api.rst:4: WARNING: Duplicate explicit target name: "group__sof__dai__drivers_1ga8c720c310f408b2f97ce014562d6a910".
/home/runner/work/sof-docs/sof-docs/api/dai-drivers-api.rst:6: WARNING: Duplicate declaration, const struct device* dai::drv

(Yes the fix is in sof.git, not in sof-docs.git. It's a doxygen-related issue but it shows only in sphinx/sof-docs)

The other errors clearly come from this PR:

/home/runner/work/sof-docs/sof-docs/getting_started/intel_debug/suggestions.rst:155: WARNING: Error in "code-block" directive:
maximum 1 argument(s) allowed, 10 supplied.
.. code-block::
[ 4.301490] sof-audio-pci-intel-tgl 0000:00:1f.3: DMICs detected in NHLT tables: 2

not checked due to problem on Ubuntu 22.04

Exactly why I created this alternative a long time ago, please try it:

pip3 -r scripts/requirements-lax.txt

@plbossart
plbossartforce-pushed the fix/hdaudio-dmic-bugs branch from ed86d01 to 7e4cdd7CompareJuly 7, 2022 13:25
@plbossart

plbossart commented Jul 7, 2022

Copy link
Copy Markdown
MemberAuthor

pip3 -r scripts/requirements-lax.txt

pip3 -r scripts/requirements-lax.txt

Usage:
pip3 [options]

no such option: -r

???

@plbossart
plbossartforce-pushed the fix/hdaudio-dmic-bugs branch from 7e4cdd7 to 0b30417CompareJuly 7, 2022 16:04
@intelkevinputnam

intelkevinputnam commented Jul 7, 2022

Copy link
Copy Markdown
Collaborator

pip3 -r scripts/requirements-lax.txt

pip3 -r scripts/requirements-lax.txt

Usage: pip3 [options]

no such option: -r

???

try: pip3 install -r scripts/requirements-lax.txt

@marc-hb

marc-hb commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

try: pip3 install -r scripts/requirements-lax.txt

Indeed, sorry for the mistake. I just tried this on Ubuntu 22.04 and it worked 100%

lgirdwood
lgirdwood approved these changes Jul 8, 2022
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart pip issues resolved now ?

@plbossart

plbossart commented Jul 8, 2022

Copy link
Copy Markdown
MemberAuthor

@plbossart pip issues resolved now ?

yes, no issues with the 'requirements.lax', the command above was missing a --user switch

marc-hb
marc-hb reviewed Jul 9, 2022
View reviewed changes

@marc-hbmarc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful!

Comment threadgetting_started/intel_debug/suggestions.rst Outdated
Comment threadgetting_started/intel_debug/suggestions.rst Outdated
Comment threadgetting_started/intel_debug/suggestions.rst Outdated
Comment threadgetting_started/intel_debug/suggestions.rst
platform firmware/NHTL.

There are however a number of hardware configurations that cannot be
detected from platform firmware. To work-around this limitation, the

@marc-hbmarc-hbJul 9, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "platform" firmware?

@plbossartplbossartJul 11, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACPI and others.

Comment threadgetting_started/intel_debug/suggestions.rst Outdated
marc-hb
marc-hb requested changes Jul 9, 2022
View reviewed changes

@marc-hbmarc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting at least the NHTL -> NHLT fixes.

@plbossart
intel_debug: add suggestions for DMIC and ES8336 platforms
b3def46
Instead of repeating the same things on GitHub issues, maybe this
documentation will help.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
plbossartforce-pushed the fix/hdaudio-dmic-bugs branch from 0b30417 to b3def46CompareJuly 11, 2022 15:07
@plbossart
plbossart requested a review from marc-hbJuly 11, 2022 15:08
@lgirdwood
lgirdwood merged commit 99db679 into thesofproject:masterJul 12, 2022
@plbossart

plbossart commented Jul 18, 2022

Copy link
Copy Markdown
MemberAuthor

Can we please push this to the official docs @lgirdwood@deb-intel ?

@lgirdwood

lgirdwood commented Jul 18, 2022

Copy link
Copy Markdown
Member

@deb-intel are you able to rebuild and publish this week ? Thanks !

@deb-intel

deb-intel commented Jul 18, 2022

Copy link
Copy Markdown
Collaborator

@lgirdwood Yes, I can publish by my EOD today.

@marc-hb

marc-hb commented Jul 18, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

@plbossart in general while waiting for https://thesofproject.github.io/latest/index.html you can point people at GitHub in the meantime, for instance this page is rendered and looks very good: https://github.com/thesofproject/sof-docs/blob/master/getting_started/intel_debug/suggestions.rst#es8336-support

@deb-intel

deb-intel commented Jul 18, 2022

Copy link
Copy Markdown
Collaborator

@lgirdwood The website has been published and includes all merged PRs.

@marc-hb

marc-hb commented Jul 18, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

https://thesofproject.github.io/latest/getting_started/intel_debug/suggestions.html#es8336-support

cc: @MrChromebox

@lgirdwood

lgirdwood commented Jul 19, 2022

Copy link
Copy Markdown
Member

Thanks @deb-intel

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@ujfalusiujfalusiujfalusi approved these changes
@marc-hbmarc-hbmarc-hb approved these changes
@anton-intelanton-intelAwaiting requested review from anton-intel
@deb-inteldeb-intelAwaiting requested review from deb-inteldeb-intel is a code owner
@intelkevinputnamintelkevinputnamAwaiting requested review from intelkevinputnamintelkevinputnam is a code owner
@greg-intelgreg-intelAwaiting requested review from greg-intel
@ranj063ranj063Awaiting requested review from ranj063

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@plbossart@marc-hb@intelkevinputnam@lgirdwood@deb-intel@ujfalusi