Skip to content

Connection preferences - #39

Open
edominia wants to merge 1 commit into
thesofproject:topic/gst-topofrom
edominia:conn_preferences
Open

Connection preferences#39
edominia wants to merge 1 commit into
thesofproject:topic/gst-topofrom
edominia:conn_preferences

Conversation

@edominia

@edominiaedominia commented Jan 20, 2020

Copy link
Copy Markdown

Resolves issue #35

lgirdwood
lgirdwood reviewed Jan 20, 2020
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember and write a commit message for each commit and PR title. Otherwise reviewers have no clue what they are reviewing and history is useless.

@edominiaedominia changed the title Connecion preferencesConnection preferencesJan 21, 2020
mmaka1
mmaka1 requested changes Feb 5, 2020
View reviewed changes
Comment threadorg.sofproject.gst.topo/src/org/sofproject/gst/topo/ui/preferences/ConnectionPreferences.java Outdated
Comment threadorg.sofproject.gst.topo/src/org/sofproject/gst/topo/ui/preferences/ConnectionPreferences.java Outdated
Comment threadorg.sofproject.ui/META-INF/MANIFEST.MF Outdated
Comment threadorg.sofproject.gst.topo/src/org/sofproject/gst/topo/ui/preferences/ConnectionPreferences.java Outdated
getFieldEditorParent());
addField(ipFieldEditor);

userFieldEditor = new StringFieldEditor(ConnectionPreferencesConst.CONN_USERNAME, "Username for all projects: ",

@mmaka1mmaka1Feb 5, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Last login name for Audio Dev projects: "?

@edominiaedominiaFeb 11, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want use 'audio'. I will change it to Last login name for Dev projects.

Comment threadorg.sofproject.gst.topo/src/org/sofproject/gst/topo/ui/preferences/ConnectionPreferences.java Outdated

@Override
protected void createFieldEditors() {
ipFieldEditor = new StringFieldEditor(ConnectionPreferencesConst.CONN_ADDR, "Address for all projects: ",

@mmaka1mmaka1Feb 5, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to maintain a list of let's say 5 last entered addresses and populate a drop down box in the login dialog.

@edominiaedominiaFeb 11, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but let's make a new issue for it to create it later.

@edominia
Add possibility to set node address and username in preferences
1308a9c
User has to write node address and username for every project separately.
It improves user experience by creating a possibility to set both in preferences windows so user doesn't have to repeat them for
every project if they don't change.
Signed-off-by: Emilia Dominiak <emilia.dominiak@intel.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood left review comments
@mmaka1mmaka1mmaka1 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edominia@lgirdwood@mmaka1