Volume reset for alsabat testing by keqiaozhang · Pull Request #1010 · thesofproject/sof-test

keqiaozhang · 2023-03-13T08:11:06Z

No description provided.

marc-hb · 2023-03-13T16:05:24Z

BTW there's a list of volume issues in

check-pause-resume: handle volume MAX output in expect #931

singalsu · 2023-03-13T17:31:53Z

 amixer -Dhw:0 scontrols | sed -e "s/^.*'\(.*\)'.*/\1/" |egrep 'PGA|gain' |
 while read -r mixer_name
 do
- amixer -Dhw:0 -- sset "$mixer_name" 0dB


@ujfalusi Do you have idea why 0 dB is not working?

Note: In tplg1 100% could be +20 or +40 dB in some cases.

marc-hb · 2023-03-14T04:23:29Z

 {
 # set all PGA* volume to 0dB
- amixer -Dhw:0 scontrols | sed -e "s/^.*'\(.*\)'.*/\1/" |grep PGA |
+ amixer -Dhw:0 scontrols | sed -e "s/^.*'\(.*\)'.*/\1/" |egrep 'PGA|gain' |


marc-hb · 2023-03-14T04:24:59Z

only suspend/resume timeouts in https://sof-ci.01.org/softestpr/PR1010/build181/devicetest/index.html but some alsabat failures in https://sof-ci.01.org/softestpr/PR1010/build182/devicetest/index.html

keqiaozhang · 2023-03-14T05:10:57Z

but some alsabat failures in https://sof-ci.01.org/softestpr/PR1010/build182/devicetest/index.html

These failures will be fixed in

alsa_settings: add alsa settings for IPC4 platforms #992

EDIT, now:

Amixer setting for ipc4 platforms #1012

keqiaozhang · 2023-03-14T08:49:16Z

After more tests, I found not all gain controls can set to 0dB,
For example:

amixer -Dhw:0 -- sset 'gain.0.1 1 Playback Volume 0' 0dB
amixer: Invalid command!
amixer -Dhw:0 -- sset "gain.100.1 DMIC0 Capture Volume 1" 0dB
amixer: Invalid command!

This is still a problem that needs to be clarified.

singalsu · 2023-03-14T10:54:24Z

I'm wondering if there has ever been a working dB setting in amixer. 0dB has worked but it doesn't seem accept negative values for attenuation.

$ amixer sset 'PGA1.0 1 Master' 0dB
Simple mixer control 'PGA1.0 1 Master',0
Capabilities: pvolume
Playback channels: Front Left - Front Right
Limits: Playback 0 - 32
Mono:
Front Left: Playback 32 [100%] [0.00dB]
Front Right: Playback 32 [100%] [0.00dB]
$ amixer sset 'PGA1.0 1 Master' -6dB
amixer: invalid option -- '6'
Invalid switch or option -? needs an argument.
amixer: invalid option -- 'B'
Invalid switch or option -? needs an argument.

The manual pages suggests that it should be possible but maybe there's some bug

 set or sset <SCONTROL> <PARAMETER> ...
Sets the simple mixer control contents. The parameter can be the volume either as a percentage from 0% to
100% with % suffix, a dB gain with dB suffix (like -12.5dB), or an exact hardware value. The dB gain can be
used only for the mixer elements with available dB information. When plus(+) or minus(-) letter is appended
after volume value, the volume is incremented or decremented from the current value, respectively.

It could be command line quotation issue too. Setting first to 0 dB and then decrement 6 dB works.

$ amixer sset 'PGA1.0 1 Master' 0dB
Simple mixer control 'PGA1.0 1 Master',0
Capabilities: pvolume
Playback channels: Front Left - Front Right
Limits: Playback 0 - 32
Mono:
Front Left: Playback 32 [100%] [0.00dB]
Front Right: Playback 32 [100%] [0.00dB]
$ amixer sset 'PGA1.0 1 Master' 6dB-
Simple mixer control 'PGA1.0 1 Master',0
Capabilities: pvolume
Playback channels: Front Left - Front Right
Limits: Playback 0 - 32
Mono:
Front Left: Playback 29 [91%] [-6.00dB]
Front Right: Playback 29 [91%] [-6.00dB]

singalsu · 2023-03-14T11:18:37Z

I checked with UPX set up to IPC4, works there too:

$ amixer sset 'gain.1.1 1 2nd' 0dB
Simple mixer control 'gain.1.1 1 2nd',0
Capabilities: pvolume
Playback channels: Front Left - Front Right
Limits: Playback 0 - 45
Mono:
Front Left: Playback 45 [100%] [0.00dB]
Front Right: Playback 45 [100%] [0.00dB]
$ amixer sset 'gain.1.1 1 2nd' 6dB-
Simple mixer control 'gain.1.1 1 2nd',0
Capabilities: pvolume
Playback channels: Front Left - Front Right
Limits: Playback 0 - 45
Mono:
Front Left: Playback 42 [93%] [-6.00dB]
Front Right: Playback 42 [93%] [-6.00dB]

singalsu · 2023-03-14T11:20:43Z

This is still a problem that needs to be clarified.

Maybe there's a difference in topology in working and non-working gains?

the volume ctl name PGA is for IPC3, IPC4 uses keyword gain. so rename the function to a more generic name to cover IPC4. Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>

No all IPC4 gain controls can set 0dB directly, maybe there're some problems there. As the alternative, use 100% for IPC4 gain. Will be unified after the problem is fixed. Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>

We have aligned that to use 0dB for all sof volume controls in CI test. Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>

keqiaozhang · 2023-03-15T06:17:05Z

Maybe there's a difference in topology in working and non-working gains?

Not sure about it. Since alsabat test occasionally failed on some IPC4 platforms. So for IPC4 platforms, let's set the gain volume to 100%. We can switch it back to 0dB after we fixed this issue.

marc-hb · 2023-03-15T21:13:16Z

Fixing this shellcheck warning is not trivial:
https://github.com/thesofproject/sof-test/actions/runs/4423370532/jobs/7756041716
https://www.shellcheck.net/wiki/SC2207

 ----- shellcheck -x test-case/volume-basic-test.sh ----
In test-case/volume-basic-test.sh line 61:
pgalist=($(amixer -c"$sofcard" controls | grep -i PGA | sed 's/ /_/g;' | awk -Fname= '{print $2}'))
^-- SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).

Here's one way how. Note PGA is now gain in IPC4 (thx @fredoh9 !) so I added it.

ubuntu@sh-mtlp-rvp-hda-03:~$ mapfile pgalist <<(amixer -c"$sofcard" controls | awk -Fname= '/PGA|gain/ { gsub(" ","_", $2 ); print $2}')
ubuntu@sh-mtlp-rvp-hda-03:~$ declare -p pgalist
declare -a pgalist=([0]=$'\'gain.1.1_1_2nd_Playback_Volume\'\n' [1]=$'\'gain.11.1_DMIC0_Capture_Volume_1\'\n' [2]=$'\'gain.15.1_Deepbuffer_Volume\'\n' [3]=$'\'gain.2.1_2_Main_Playback_Volume\'\n')

keqiaozhang · 2023-03-16T06:33:55Z

Here's one way how. Note PGA is now gain in IPC4 (thx @fredoh9 !) so I added it.

volume-basic-test.sh only support IPC3 ATM, IPC4 is not supported.
In this PR, I only renamed the reset_PGA_volume to a generic name reset_sof_volume. Will add the volume test for IPC4 platforms later.

keqiaozhang · 2023-03-21T02:42:34Z

CI Test passed on all platforms. Can we merge this PR? @marc-hb @singalsu @fredoh9
For more tests, Please refer to:#1012 (comment)

marc-hb · 2023-03-21T22:26:03Z

https://sof-ci.01.org/softestpr/PR1010/build194/devicetest/index.html?model=TGLU_RVP_NOCODEC_IPC4ZPH&testcase=check-alsabat-headset-playback looks like a failure (no idea why)

keqiaozhang · 2023-03-22T02:04:17Z

https://sof-ci.01.org/softestpr/PR1010/build194/devicetest/index.html?model=TGLU_RVP_NOCODEC_IPC4ZPH&testcase=check-alsabat-headset-playback looks like a failure (no idea why)

It's a known issue on IPC4 nocodec platforms:thesofproject/sof#7285

keqiaozhang requested a review from a team as a code owner March 13, 2023 08:11

keqiaozhang requested review from aiChaoSONG, fredoh9, marc-hb and miRoox March 13, 2023 08:13

marc-hb requested a review from singalsu March 13, 2023 17:26

singalsu reviewed Mar 13, 2023
View reviewed changes

keqiaozhang force-pushed the volume_reset branch from 8966f04 to a8fed1aCompare March 14, 2023 02:14

marc-hb reviewed Mar 14, 2023
View reviewed changes

marc-hb mentioned this pull request Mar 14, 2023
alsa_settings: add alsa settings for IPC4 platforms #992
Closed

keqiaozhang force-pushed the volume_reset branch from a8fed1a to fa11809Compare March 14, 2023 05:09

marc-hb requested a review from plbossart March 15, 2023 00:01

keqiaozhang added 3 commits March 15, 2023 13:29

lib.sh: rename function reset_PGA_volume to a more generic name
30a1c20
the volume ctl name PGA is for IPC3, IPC4 uses keyword gain. so rename the function to a more generic name to cover IPC4. Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>

lib.sh: reset all sof volume to 0dB before alsabat testing
691a756
We have aligned that to use 0dB for all sof volume controls in CI test. Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>

keqiaozhang force-pushed the volume_reset branch from fa11809 to 691a756Compare March 15, 2023 06:14

marc-hb mentioned this pull request Mar 15, 2023
Amixer setting for ipc4 platforms #1012
Merged

marc-hb added the False Pass / green failure label Mar 21, 2023

miRoox approved these changes Mar 27, 2023
View reviewed changes

keqiaozhang merged commit ba2f6c5 into thesofproject:mainMar 28, 2023

keqiaozhang deleted the volume_reset branch March 28, 2023 06:40

	amixer -Dhw:0 scontrols \| sed -e "s/^.'\(.\)'.*/\1/"\|egrep'PGA\|gain'\|
	amixer -Dhw:0 scontrols \| sed -e "s/^.'\(.\)'.*/\1/"\| grep -E'PGA\|gain'\|

Uh oh!

Conversation

keqiaozhang commented Mar 13, 2023

Uh oh!

marc-hb commented Mar 13, 2023

Uh oh!

singalsuMar 13, 2023

Choose a reason for hiding this comment

Uh oh!

singalsuMar 13, 2023

Choose a reason for hiding this comment

Uh oh!

marc-hbMar 14, 2023

Choose a reason for hiding this comment

Uh oh!

marc-hb commented Mar 14, 2023

Uh oh!

keqiaozhang commented Mar 14, 2023• edited by marc-hb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keqiaozhang commented Mar 14, 2023

Uh oh!

singalsu commented Mar 14, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

singalsu commented Mar 14, 2023

Uh oh!

singalsu commented Mar 14, 2023

Uh oh!

keqiaozhang commented Mar 15, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc-hb commented Mar 15, 2023

Uh oh!

keqiaozhang commented Mar 16, 2023

Uh oh!

keqiaozhang commented Mar 21, 2023

Uh oh!

marc-hb commented Mar 21, 2023

Uh oh!

keqiaozhang commented Mar 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

keqiaozhang commented Mar 14, 2023•
edited by marc-hb
Loading

singalsu commented Mar 14, 2023•
edited
Loading

keqiaozhang commented Mar 15, 2023•
edited
Loading