Skip to content

volume-basic-test.sh: catch amixer failures and log all controls - #1074

Merged
marc-hb merged 2 commits into
thesofproject:mainfrom
marc-hb:more-volume-basic-log
Jul 4, 2023
Merged

volume-basic-test.sh: catch amixer failures and log all controls#1074
marc-hb merged 2 commits into
thesofproject:mainfrom
marc-hb:more-volume-basic-log

Conversation

@marc-hb

Copy link
Copy Markdown
Collaborator

This (1) provides some logging (2) avoids skip_test if amixer fails

Partial fix for thesofproject#312
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This (1) provides some logging (2) avoids skip_test if amixer fails
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb

marc-hb commented Jun 30, 2023

Copy link
Copy Markdown
CollaboratorAuthor

@marc-hb
marc-hb marked this pull request as ready for review June 30, 2023 01:53
@marc-hb
marc-hb requested a review from a team as a code ownerJune 30, 2023 01:53
@marc-hb
marc-hb requested a review from ranj063June 30, 2023 01:54
@marc-hb

Copy link
Copy Markdown
CollaboratorAuthor

This is the more "cosmetic" subset of #1068 which requires more discussion - while this one can hopefully be expedited.

@keqiaozhangkeqiaozhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very small change and can catch the corner case when amixer fails. LGTM.

@marc-hb
marc-hb merged commit 64ba51d into thesofproject:mainJul 4, 2023
@marc-hb
marc-hb deleted the more-volume-basic-log branch July 4, 2023 15:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@marc-hb@keqiaozhang