Uh oh!
There was an error while loading. Please reload this page.
case-lib: is_ipc4: use new debugfs file instead of kernel parameter - #1167
Conversation
plbossart
commented
Apr 3, 2024
shellcheck error is a pre-existing issue that was obviously overlooked MTLP_RVP_NOCODEC is listed twice in the same OR. |
There was a problem hiding this comment.
cc:
# If /sys/module/snd_sof_pci/parameters/ipc_type does not exist
# the DUT is running IPC3 mode
This shortcut and bad assumption should print a big fat dlogw() TODAY and be "upgraded" to a die() failure in the future. Please add the dlogw() now; I think that would have saved you time and it will save others'
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
(Unrelated) fix submitted in #1168. Now merged. |
7e3fc59 to
7423c19CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
First step to remove use of kernel parameters Link: thesofproject/linux#4902 Link: thesofproject#1166 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
prefer the use of the debugfs information to the kernel parameter. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Dump kernel parameters AND debugfs fw_profile Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
No functionality change Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
marc-hb
commented
Apr 5, 2024
Lots of models missing but everything green for the ones present |
marc-hb
commented
Apr 9, 2024
This does not work actually: it's at least missing a few |
marc-hb
commented
Apr 9, 2024
Filed new issue: |
First step to remove use of kernel parameters
Link: thesofproject/linux#4902
Link: #1166