Uh oh!
There was an error while loading. Please reload this page.
tools: Initial version of IPC4 tx message logger using eBPF - #1205
tools: Initial version of IPC4 tx message logger using eBPF#1205ujfalusi wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
I don't know BPF but this seems readable so LGTM. Some kernel developer should review.
Could you move this to a new subdirectory? The tools/ directory (one of the common, meaningless names...) is getting too crowded. How about tools/BPF/ipc4-msg-trace.bt? We already know it's SOF from the repo name.
Perfect for a |
ce80292 to
6a574daCompareujfalusi
commented
Jun 10, 2024
Changes since v1:
|
6a574da to
61031d7Compareujfalusi
commented
Jun 10, 2024
Changes since v2:
|
marc-hb
left a comment
There was a problem hiding this comment.
Someone else must review the actual BPF code
marc-hb
commented
Jun 10, 2024
"Big string" support submitted: |
marc-hb
commented
Jun 12, 2024
Merged. |
ujfalusi
commented
Jun 13, 2024
Thanks for the heads up. I think the big string is still short for us (payload can be 4096 bytes) and the bigstring (if I read it right) tops at 1024. |
Ping? PS: LNL had a very bad day on June 10th, let's run things again even if this script is not used anywhere yet. |
marc-hb
commented
Jun 17, 2024
SOFCI TEST |
61031d7 to
7800e11Compareujfalusi
commented
Jul 15, 2024
Changes since v3:
|
7800e11 to
2013acbCompareujfalusi
commented
Jul 16, 2024
Changes since v4:
|
2013acb to
dd6c66aCompareThe ipc4-msg-trace.bt script will tap into the entry of sof_ipc4_log_header() which is always called but only prints if dynamic debugging is enabled. It's parameter list is not expected to be changed. The bpftrace must be installed to be able to use the script sudo pacman -S bpftrace sudo emerge -a bpftrace sudo apt install bpftrace sudo dnf install bpftrace To use the script: sudo ./tools/eBPF/sof-ipc4-msg-trace.bt or sudo bpftrace tools/eBPF/sof-ipc4-msg-trace.bt It will start logging the sent messages (including payloads) and received notification with exception of 0x1b060000 - trace update. To stop the logging, just terminate the script with CTRL+C Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
dd6c66a to
21de993Compare
The bpftrace script will tap into the entry of sof_ipc4_log_header() which is always called but only prints if dynamic debugging is enabled. It's parameter list is not expected to be changed.
The bpftrace must be installed to be able to use the script
sudo pacman -S bpftrace
sudo emerge -a bpftrace
sudo apt install bpftrace
sudo dnf install bpftrace
To use the script:
sudo ./tools/sof-ipc4-msg-trace.bt
or
sudo bpftrace tools/sof-ipc4-msg-trace.bt
It will start logging the sent messages (including payloads) and received notification with exception of 0x1b060000 - trace update.
To stop the logging, just terminate the script with CTRL+C