Uh oh!
There was an error while loading. Please reload this page.
Test-case: Updated check-sof-logger.sh with SOF-specific codec - #1248
Merged
Conversation
sofci
commented
Jan 13, 2025
Collaborator
Can one of the admins verify this patch?
|
marc-hb
commented
Jan 13, 2025
Collaborator
test this please |
marc-hb
reviewed
Jan 13, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kv2019i
approved these changes
Jan 13, 2025
kv2019i
left a comment
Contributor
There was a problem hiding this comment.
No blockers, PR seems good, but I'd encourage to look up old git commits to get a feel of the style on conventions used in this repo.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…SOF probes We have multiple sof* devices whenever SOF probes are enabled Signed-off-by: Hariprasad, Rajendra <hariprasad.rajendra@intel.com>
marc-hb
approved these changes
Jan 16, 2025
ujfalusi
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated SOF-specific codecs since the sof* regex also lists sofprobes
Should fix#1243