Skip to content

Test-case: Enhance "amixer" card selection - #1249

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
harajend:fix/verify-kernel-boot-log
Jan 17, 2025
Merged

Test-case: Enhance "amixer" card selection#1249
kv2019i merged 1 commit into
thesofproject:mainfrom
harajend:fix/verify-kernel-boot-log

Conversation

@harajend

@harajendharajend commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Added Enhancement for "amixer" card selection: support card identification by name

@harajend
harajend requested a review from a team as a code ownerJanuary 13, 2025 05:56
@sofci

sofci commented Jan 13, 2025

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

reply test this please to run this test once

@harajend
harajendforce-pushed the fix/verify-kernel-boot-log branch from ae665c6 to 2722df4CompareJanuary 13, 2025 06:27
This was referenced Jan 13, 2025
Closed
Closed
marc-hb
marc-hb reviewed Jan 13, 2025
View reviewed changes

@marc-hbmarc-hb left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is empty.

Avoid vague words like "update" or "Enhance". Try to be as specific as possible, for instance "select the first card by name because it's not always numbered 0" (assuming I'm guessing correctly)

Note the review already started in #1245.

Comment threadtest-case/verify-kernel-boot-log.sh Outdated
Comment threadtest-case/verify-kernel-boot-log.sh Outdated
kv2019i
kv2019i requested changes Jan 15, 2025
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code good, but git commit message needs to follow repository style (and have a signed off).

Comment threadtest-case/verify-kernel-boot-log.sh Outdated
@harajend
harajendforce-pushed the fix/verify-kernel-boot-log branch 2 times, most recently from fba0b90 to 9969f61CompareJanuary 15, 2025 11:49
kv2019i
kv2019i approved these changes Jan 15, 2025
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harajend !

marc-hb
marc-hb reviewed Jan 15, 2025
View reviewed changes

@marc-hbmarc-hb left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is still confusing. I think it should say:

Search for DMIC on the first card found instead of card 0

Avoid vague words like "enhance". This is a bug FIX that makes the test pass, so it's not just an "enhancement".

Comment threadtest-case/verify-kernel-boot-log.sh Outdated
Comment threadtest-case/verify-kernel-boot-log.sh Outdated
@harajend
verify-kernel-log.sh: Support card identification by name
a4dc166
Select the first card by name because it is not always numbered 0
Signed-off-by: Hariprasad, Rajendra <hariprasad.rajendra@intel.com>
@harajend
harajendforce-pushed the fix/verify-kernel-boot-log branch from 9969f61 to a4dc166CompareJanuary 16, 2025 18:55
@harajend
harajend requested a review from marc-hbJanuary 16, 2025 18:57
@marc-hb

marc-hb commented Jan 16, 2025

Copy link
Copy Markdown
Collaborator

Again, no Jenkins testing :-(

ujfalusi
ujfalusi reviewed Jan 17, 2025
View reviewed changes
Comment threadtest-case/verify-kernel-boot-log.sh
(set -x
# name= is hardcoded in /usr/share/alsa/ucm2/*
# - https://github.com/thesofproject/sof-test/issues/1244
first_card_name=$(aplay -l | awk 'NR == 2 {print $3}')

@ujfalusiujfalusiJan 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could do the same with arecord and probably verify that the name starts with sof

@kv2019i
kv2019i merged commit d4b799a into thesofproject:mainJan 17, 2025
@harajendharajend mentioned this pull request Mar 17, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kv2019ikv2019ikv2019i approved these changes
@marc-hbmarc-hbmarc-hb approved these changes
+1 more reviewer
@ujfalusiujfalusiujfalusi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@harajend@sofci@marc-hb@ujfalusi@kv2019i