Uh oh!
There was an error while loading. Please reload this page.
test: add compressed audio socwatch test - #1345
Merged
redzynix merged 2 commits intoApr 20, 2026
Merged
Conversation
ekurdybxforce-pushed
the
compressed_audio_socwatch_test
branch
2 times, most recently
from
March 5, 2026 13:42
8a46815 to
70150f4Compareekurdybxforce-pushed
the
compressed_audio_socwatch_test
branch
6 times, most recently
from
March 17, 2026 12:00
c9edb0c to
f1455fbCompareekurdybxforce-pushed
the
compressed_audio_socwatch_test
branch
4 times, most recently
from
March 24, 2026 14:27
b3ad6c8 to
a5626acCompareekurdybxforce-pushed
the
compressed_audio_socwatch_test
branch
2 times, most recently
from
April 17, 2026 10:09
0bcbd9a to
7883e5cCompareekurdybxforce-pushed
the
compressed_audio_socwatch_test
branch
2 times, most recently
from
April 17, 2026 10:54
028929a to
d2d4f57Compareekurdybx
marked this pull request as ready for review
April 17, 2026 11:09
ekurdybx
requested review from
a team, golowanow, lgirdwood and marc-hb
as code ownersApril 17, 2026 11:09
| print(f"Incorrect value: {pc_state} time % was {value}, expected {expected_value}") | ||
| failures += 1 | ||
| return 0 if failures == 0 else 1 |
Contributor
There was a problem hiding this comment.
It's cool but I think keeping it easier to read would be better.
Suggested change
| return0iffailures==0else1 | |
| iffailures==0: | |
| return0 | |
| return1 |
redzynix
approved these changes
Apr 17, 2026
ekurdybxforce-pushed
the
compressed_audio_socwatch_test
branch
2 times, most recently
from
April 17, 2026 12:03
cc6155f to
6154da5Comparemarc-hb
reviewed
Apr 17, 2026
marc-hb
left a comment
Collaborator
There was a problem hiding this comment.
Very clean and easy to read! Minor suggestions below
| with open(pc_states_file, encoding="utf-8") as file: | ||
| for line in file: | ||
| m = pattern.match(line) | ||
| if m: |
Collaborator
There was a problem hiding this comment.
"early return" pattern
Suggested change
| ifm: | |
| ifnotm: | |
| continue |
Same as you already did below but saves a lot more indentation (and mental load).
| print(f"Incorrect value: {pc_state} time % was {value}, expected {expected_value}") | ||
| failures += 1 | ||
| if failures: |
Collaborator
There was a problem hiding this comment.
Suggested change
| iffailures: | |
| returnfailures |
Then you may not want the main script to exit the number of failures too because some values may have special meaning - but for sure this function has nothing better to return than the number of failures.
ContributorAuthor
There was a problem hiding this comment.
This func returns the result of the analysis - which is true or false.
| pattern = re.compile(r'^PC(\d+)\s*,\s*(\d+(?:\.\d+)?)\s*,\s*(\d+(?:\.\d+)?)\s*$') | ||
| failures = 0 | ||
| with open(pc_states_file, encoding="utf-8") as file: |
Collaborator
There was a problem hiding this comment.
You could move the with open() to the caller and save even more indentation.
| def analyze_pc_states(pc_states_file, expected_results): | ||
| pattern = re.compile(r'^PC(\d+)\s*,\s*(\d+(?:\.\d+)?)\s*,\s*(\d+(?:\.\d+)?)\s*$') |
Collaborator
There was a problem hiding this comment.
Regexps are notoriously cryptic. What really helps in such cases is to give a few input examples in a comment.
| check_cplay_command() | ||
| { | ||
| dlogi "${play_command[@]}" | ||
| if ! "${play_command[@]}"; then |
Collaborator
There was a problem hiding this comment.
Style nit:
Suggested change
| if!"${play_command[@]}";then | |
| "${play_command[@]}"|| | |
| die ... |
| expected_results="{\"PC10.2\":$pc10_threshold}" | ||
| # Analyze if the % of the time spent in given PC state was as expected | ||
| if python3 "$SCRIPT_HOME"/tools/analyze-pc-states.py "$pc_states_file" "$expected_results"; then |
Collaborator
There was a problem hiding this comment.
chmod a+x analyze-pc-states.py
I'm afraid sof-test is not going to work on Windows anytime soon!
Suggested change
| ifpython3 "$SCRIPT_HOME"/tools/analyze-pc-states.py "$pc_states_file""$expected_results";then | |
| if"$SCRIPT_HOME"/tools/analyze-pc-states.py "$pc_states_file""$expected_results";then |
PLangowski
approved these changes
Apr 20, 2026
ekurdybxforce-pushed
the
compressed_audio_socwatch_test
branch
5 times, most recently
from
April 20, 2026 12:10
405be8b to
d38b647CompareSigned-off-by: Emilia Kurdybelska <emiliax.kurdybelska@intel.com>
Add test that plays mp3 audio using cplay, and check PC states with Socwatch Signed-off-by: Emilia Kurdybelska <emiliax.kurdybelska@intel.com>
ekurdybxforce-pushed
the
compressed_audio_socwatch_test
branch
from
April 20, 2026 12:11
d38b647 to
2a9d625CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test that plays MP3 sound and performs Socwatch analysis to check if dut enters and stays in PC10 state for the expected % of time (default expected value: 80% in PC10.2 state)
Note: this test will only pass when: