Skip to content

Test Case: Add check suspend resume test - #22

Merged
xiulipan merged 1 commit into
thesofproject:masterfrom
Bin-QA:S3
Jan 9, 2020
Merged

Test Case: Add check suspend resume test#22
xiulipan merged 1 commit into
thesofproject:masterfrom
Bin-QA:S3

Conversation

@Bin-QA

@Bin-QABin-QA commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

Add new test Case for the suspend resume

Signed-off-by: Wu, BinX binx.wu@intel.com

@Bin-QA

Bin-QA commented Jan 6, 2020

Copy link
Copy Markdown
ContributorAuthor

@libinyang@keqiaozhang@xiulipan@aiChaoSONG
please help to review this case, current know issue: #16

@xiulipanxiulipan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bin-QA Please rename the test case into suspend/resume, for some platform we will need to run in deep(s3) and for some platform we would like to run in s2idle(s0ix). But we would to let the device to run on the default setting.

So please keep the args for the suspend/resume type, but only overwrite when we want, we should output what type we are running.

Comment threadtest-case/check-s3.sh Outdated
Comment threadtest-case/check-s3.sh Outdated
Comment threadtest-case/check-s3.sh Outdated
Comment threadtest-case/check-s3.sh Outdated
Comment threadtest-case/check-s3.sh Outdated
Comment threadtest-case/check-s3.sh
Comment threadtest-case/check-s3.sh Outdated
@Bin-QABin-QA changed the title Test Case: Add check S3 testTest Case: Add check suspend resume testJan 6, 2020

@xiulipanxiulipan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some simple issue with commit spilt and variable naming.
I think we need to only override the power mode when we want and keep the default value as it is.

Comment threadcase-lib/lib.sh Outdated
Comment threadtest-case/check-suspend-resume.sh Outdated
Comment threadtest-case/check-suspend-resume.sh Outdated
Comment threadtest-case/check-suspend-resume.sh Outdated
Comment threadtest-case/check-suspend-resume.sh Outdated
@xiulipan

Copy link
Copy Markdown
Contributor

@Bin-QA@keqiaozhang@libinyang So here I think we will keep the behavior to be

  • use default mode to do test if no argument is passed.
  • override the mode with the argument

@keqiaozhang

Copy link
Copy Markdown
Contributor

@xiulipan Agree, use deep as default and override it if it's specified.

Comment threadtest-case/check-suspend-resume.sh Outdated
Comment threadtest-case/check-suspend-resume.sh Outdated
Comment threadtest-case/check-suspend-resume.sh Outdated
Add new Test Case for the suspend resume
Signed-off-by: Wu, BinX <binx.wu@intel.com>
@stripes416

Copy link
Copy Markdown
Contributor

I'm currently running the manual suspend-resume tests on ICL --- this looks good to me & I can't think of anything to add to the code. Good job @Bin-QA

@xiulipanxiulipan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiulipan
xiulipan merged commit 606d849 into thesofproject:masterJan 9, 2020
@Bin-QA
Bin-QA deleted the S3 branch January 22, 2020 06:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Bin-QA@xiulipan@keqiaozhang@stripes416@wenqingfu@libinyang@aiChaoSONG