fix shell check error for case-lib/* by Bin-QA · Pull Request #222 · thesofproject/sof-test

Bin-QA · 2020-05-15T09:29:15Z

Update for fix shell check error for case-lib/*
expect case-lib/config.sh file

Bin-QA · 2020-05-15T09:30:05Z

Wait for CI system detect error

marc-hb

Thanks for doing all these fixes, will make future reviews much easier! See comments below.

marc-hb · 2020-05-15T17:28:08Z

 else
- [ "${OPT_VALUE_lst[$i]}" -eq 0 ] && echo -e "\t""Default Value: Off" \
- || echo -e "\t""Default Value: On"
+ echo -e "\t""Default Value: On"


Avoid echo, use printf
printf'\tDefault Value: 'if [ "${OPT_PARM_lst[$i]}"-eq 1 ];thenprintf'%s\n'"${OPT_VALUE_lst[$i]}" ... printf'On\n'

marc-hb · 2020-05-15T17:29:30Z

 if [ $# -lt 1 ]; then
- dlogi "Topology file name is not specified, unable to run command: ${BASH_SOURCE[-1]}" && exit 1
+ dlogi "Topology file name is not specified, unable to run command: $SCRIPT_NAME"
+ exit 1


marc-hb · 2020-05-15T17:29:44Z

+ tplg_path=$(func_lib_get_tplg_path "$1") || {
+ dloge "No available topology for pipeline export"
+ exit 1
+ }


marc-hb · 2020-05-15T18:40:46Z

About the [WIP] : if you submit the PR as a "github draft" then no reviewer will be automatically added.
https://github.blog/2019-02-14-introducing-draft-pull-requests/

It's too late now, you can't go back to Draft. Next time.

paulstelian97 · 2020-05-18T08:08:42Z

It's too late now, you can't go back to Draft. Next time.

Not too late apparently. It can always be converted back and review requests re-sent.

fix shell check error and cleanup some useless code Signed-off-by: Wu, BinX <binx.wu@intel.com>

1. remove _func_logcmd_add_timestamp function direct to use 'alais' for the dlog* command 2. fix shell check error 3. remove some useless code Signed-off-by: Wu, BinX <binx.wu@intel.com>

1. refine option for sof-tplgreader format 2. fix shell check error and remove some useless code Signed-off-by: Wu, BinX <binx.wu@intel.com>

fix shell check error and remove some useless code Signed-off-by: Wu, BinX <binx.wu@intel.com>

use readarray instead of IFS readarray make code more simple and clean It also fix shell check error This change refer hijack.sh: exit lib.sh: func_lib_disable_pulseaudio pipeline.sh: func_pipeline_export

Bin-QA · 2020-05-19T03:29:21Z

@marc-hb

die() function to fix I want to add into other PR,
it also refer the problem we have different exit code
so here die() just focus on dloge + exit 1?
echo replace with print just for the opt.sh or other file

Already verify on CI system

marc-hb · 2020-05-19T21:16:25Z

I keep losing track of where die() is available versus not. If it's not available here yet then forget it for now.
For very simple strings with no control characters echo is IMHO not the best but acceptable. For anything more advanced like for instance control characters please use printf.

Bin-QA · 2020-05-20T06:30:29Z

For very simple strings with no control characters echo is IMHO not the best but acceptable. For anything more advanced like for instance control characters please use printf.

@marc-hb I already try with printf
but I find, if I want use this style string "description need two\nlines" will not output
like my design, so it need to parse the string, how to deal those string for output

paulstelian97 · 2020-05-20T07:59:52Z

but I find, if I want use this style string "description need two\nlines" will not output
like my design, so it need to parse the string, how to deal those string for output

Use single quotes on that, otherwise the shell will eat the \. Or do double escaping.

marc-hb · 2020-05-20T21:21:36Z

Exactly: always single quote the format string:

printf'format: \t%s\nstring: \t%d'"$arg1""$arg2"

a='pri\nt_this'echo -e "value:\t$a"printf'val:\t%s\n'"$a"

echo command with '-e' option will hide the control char for the output string replace with printf '%s' to instead of it Signed-off-by: Wu, BinX <binx.wu@intel.com>

Bin-QA · 2020-05-25T00:21:23Z

@marc-hb Can you help me to review this patch, or you think what I need to update

marc-hb

@marc-hb Can you help me to review this patch, or you think what I need to update

Sorry for the delay, this is a large PR and I don't really understand the changes unrelated to shellcheck. Next time please submit several smaller PRs, one at a time thanks!

marc-hb · 2020-07-01T01:49:23Z

Next time please submit several smaller PRs, one at a time thanks!

It's not only impossible to review changes that large, it's also impossible to test them in a reasonable time. See for instance regression #266

Bin-QA requested review from marc-hb and xiulipan as code owners May 15, 2020 09:29

marc-hb requested changes May 15, 2020
View reviewed changes

marc-hb mentioned this pull request May 15, 2020
lib: opt.sh: remove useless cmd.txt code and shellcheck cleanup #206
Closed

paulstelian97 marked this pull request as draft May 18, 2020 08:07

paulstelian97 removed the request for review from xiulipan May 18, 2020 08:08

Bin-QA added 6 commits May 19, 2020 10:57

case-lib: lib.sh: fix shell check error
c3a05f2
fix shell check error and cleanup some useless code Signed-off-by: Wu, BinX <binx.wu@intel.com>

case-lib: logging_ctl.sh: remove _func_logcmd_add_timestamp
318c6a2
1. remove _func_logcmd_add_timestamp function direct to use 'alais' for the dlog* command 2. fix shell check error 3. remove some useless code Signed-off-by: Wu, BinX <binx.wu@intel.com>

case-lib: pipeline.sh: refine option for sof-tplgreader format
52fb90f
1. refine option for sof-tplgreader format 2. fix shell check error and remove some useless code Signed-off-by: Wu, BinX <binx.wu@intel.com>

case-lib: opt.sh fix shell check error
0ffaf87
fix shell check error and remove some useless code Signed-off-by: Wu, BinX <binx.wu@intel.com>

case-lib: hijack.sh: fix shell check error
4a92e69
fix shell check error and remove some useless code Signed-off-by: Wu, BinX <binx.wu@intel.com>

case-lib: use readarray instead of IFS
6c7fa3e
use readarray instead of IFS readarray make code more simple and clean It also fix shell check error This change refer hijack.sh: exit lib.sh: func_lib_disable_pulseaudio pipeline.sh: func_pipeline_export

Bin-QA force-pushed the shellcheck branch from 157e128 to 6c7fa3eCompare May 19, 2020 03:17

Bin-QA marked this pull request as ready for review May 19, 2020 05:44

case-lib: opt.sh replace echo to printf
e67b2d9
echo command with '-e' option will hide the control char for the output string replace with printf '%s' to instead of it Signed-off-by: Wu, BinX <binx.wu@intel.com>

Bin-QA changed the title [WIP]fix shell check error for case-lib/*fix shell check error for case-lib/*May 21, 2020

marc-hb self-requested a review May 28, 2020 04:23

marc-hb approved these changes May 28, 2020
View reviewed changes

Bin-QA merged commit b4fe945 into thesofproject:masterMay 28, 2020

Bin-QA deleted the shellcheck branch May 28, 2020 04:54

marc-hb added the pulseaudio label Jul 30, 2020

Uh oh!

Conversation

Bin-QA commented May 15, 2020

Uh oh!

Bin-QA commented May 15, 2020

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marc-hbMay 15, 2020

Choose a reason for hiding this comment

Uh oh!

marc-hbMay 15, 2020

Choose a reason for hiding this comment

Uh oh!

marc-hbMay 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

marc-hb commented May 15, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulstelian97 commented May 18, 2020

Uh oh!

Bin-QA commented May 19, 2020

Uh oh!

marc-hb commented May 19, 2020

Uh oh!

Bin-QA commented May 20, 2020

Uh oh!

paulstelian97 commented May 20, 2020

Uh oh!

marc-hb commented May 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bin-QA commented May 25, 2020

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

marc-hb commented Jul 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marc-hb commented May 15, 2020•
edited
Loading

marc-hb commented May 20, 2020•
edited
Loading