Uh oh!
There was an error while loading. Please reload this page.
test-case: verify-sof-firmware-load: update filter of firmware keyword - #252
Closed
Bin-QA wants to merge 1 commit into
Closed
test-case: verify-sof-firmware-load: update filter of firmware keyword#252Bin-QA wants to merge 1 commit into
Bin-QA wants to merge 1 commit into
Conversation
aiChaoSONG
commented
Jun 11, 2020
@Bin-QA title : fireware? |
Bin-QA
commented
Jun 11, 2020
ContributorAuthor
update |
marc-hb
commented
Jun 11, 2020
Collaborator
There are at least two places where spell checking can be automated
|
marc-hb
requested changes
Jun 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Bin-QAforce-pushed
the
j2
branch
2 times, most recently
from
June 12, 2020 05:07
a8eab5f to
c410db2Compare Closed
with replace kern.log file the keyword filter already changed from '] sof-audio' to 'sof-audio' so need refine the case filter Signed-off-by: Wu, BinX <binx.wu@intel.com>
marc-hb
requested changes
Jul 2, 2020
| dlogi "Checking SOF Firmware load info in kernel log" | ||
| if [[ $(eval $cmd | grep "] sof-audio.*version") ]]; then | ||
| $cmd | grep -q "sof-audio.*Firmware.*version" && { |
Collaborator
There was a problem hiding this comment.
This needs to stand out as a separate commit, otherwise it's too easy to assume this is just a shellcheck cleanup like the rest of the commit.
xiulipan
commented
Sep 2, 2020
Contributor
I will close this one as @Bin-QA no longer work on this. |
marc-hb added a commit
to marc-hb/sof-test
that referenced
this pull request
Sep 2, 2020
As previously suggested in abandonned PR thesofproject#252. Follow-up to commit 14b8d50 ("verify-firmware-presence.sh: missing quotes and other warnings") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
commented
Sep 2, 2020
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with replace kern.log file the keyword filter already changed from
'] sof-audio' to 'sof-audio' so need refine the case filter
Signed-off-by: Wu, BinX binx.wu@intel.com