Skip to content

add User space test cases (version2) - #479

Merged
xiulipan merged 5 commits into
thesofproject:masterfrom
libinyang:user_case
Jan 18, 2021
Merged

add User space test cases (version2)#479
xiulipan merged 5 commits into
thesofproject:masterfrom
libinyang:user_case

Conversation

@libinyang

@libinyanglibinyang commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

a lot of changes have been made from the first version. And we have a full talk about the implementation. So open a new thread based on @marc-hb 's suggestion. The old version can be found: #363

This patchset includes:
check-userspace-cardinfo: check pulseaudio can parse the ucm correctly and exports the correct card
check-userspace-paplay: go through all the active sinks and play on it if port is available
check-userspace-parecord: go through all the active sources and record on it if port is available

@libinyang
libinyang requested a review from a team as a code ownerNovember 2, 2020 06:39
@libinyanglibinyang mentioned this pull request Nov 2, 2020
Closed
marc-hb
marc-hb requested changes Nov 5, 2020
View reviewed changes

@marc-hbmarc-hb left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very quick and incomplete review.

The code is very readable, thanks! but I'm wondering whether all of it is really needed, especially the long pactl parser

Maybe there's no need for that much manual error handling either, relying on the defaults could be enough.

Comment threadcase-lib/lib.sh Outdated
Comment threadtest-case/check-userspace-cardinfo.sh Outdated
Comment threadtest-case/check-userspace-paplay.sh Outdated
Comment threadtest-case/check-userspace-paplay.sh Outdated
Comment threadtest-case/check-userspace-parecord.sh Outdated
Comment threadtools/pactlinfo.py Outdated
Comment threadtools/pactlinfo.py
Comment threadtest-case/check-userspace-paplay.sh
Comment threadtest-case/check-userspace-paplay.sh
@xiulipan

xiulipan commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

@libinyang Ping for update or close.

@libinyang
case-lib: add helper function to check pulseaudio status
5981b27
Add the helper function to check whether pulseaudio runs
properly or not.
Signed-off-by: Libin Yang <libin.yang@intel.com>
@libinyang
userspace: add check-userspace-cardinfo
b281225
Check the pulseaudio card info to make sure the card is ready.
Signed-off-by: Libin Yang <libin.yang@intel.com>
@libinyang
tools: add pactlinfo
28ee0bd
Add the tool pactlinfo.py to parse the pactl list information
Signed-off-by: Libin Yang <libin.yang@intel.com>
@libinyang
userspace: add check-userspace-paplay
6b05cf2
This test case will go through all the sinks on the tested cards, and
try to paplay it if the active port is not "not available"
Signed-off-by: Libin Yang <libin.yang@intel.com>
@libinyang
userspace: add check-userspace-parecord
82bfaf1
This test case will go through all the sources on the tested cards, and
try to parecord it if the active port is not "not available"
Signed-off-by: Libin Yang <libin.yang@intel.com>
@libinyang

libinyang commented Dec 25, 2020

Copy link
Copy Markdown
ContributorAuthor

All the feedbacks are ACKed except the 'timeout' issue keeps open.

@libinyang

libinyang commented Jan 11, 2021

Copy link
Copy Markdown
ContributorAuthor

ping for review

@xiulipan
xiulipan requested a review from marc-hbJanuary 18, 2021 07:02
@xiulipan
xiulipan merged commit 93f19db into thesofproject:masterJan 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-hbmarc-hbAwaiting requested review from marc-hb
1 more reviewer
@xiulipanxiulipanxiulipan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@libinyang@xiulipan@marc-hb