Uh oh!
There was an error while loading. Please reload this page.
Make multiple-pipeline-playback 99% identical to -capture again - #525
Conversation
While making recent changes to multiple-pipeline-capture.sh I had vaguely noticed some similarities with multiple-pipeline-playback.sh but I had naively not realized that they were both an exact copy/paste of each other except for a couple lines. This commit make -playback catch up with recent -capture enhancements. It also makes them nearly identical again which is the first step before (painful) deduplication. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
commented
Nov 18, 2020
As of November 18 the version of the (newer) -capture test this catches up to didn't have a single nightly test run yet. In other words this is not ready for merge yet. |
marc-hb
commented
Nov 18, 2020
For https://sof-ci.01.org/softestpr/PR525/build412/devicetest/ APL_UP2_HDA was not available, everything else is PASS |
marc-hb
commented
Nov 19, 2020
Except for the current shortage of APL_UP2_HDA , https://sof-ci.01.org/softestpr/PR525/build412/devicetest was successful. |
marc-hb
commented
Nov 19, 2020
These two test scripts are really almost exactly the same. After #525 is merged and successfully tested over some period of quiet (and rare) CI time, the easiest next step is probably to replace them both with one-line wrappers like this:
#!/bin/bash
multiple-pipeline-common.sh --prefer playback "$@"
#!/bin/bash
multiple-pipeline-common.sh --prefer record "$@"cc: @ranj063 , @aiChaoSONG |
xiulipan
commented
Nov 19, 2020
@marc-hb Do you consider to merge this two scripts to one and use a simple option for different test?
|
xiulipan
commented
Nov 19, 2020
SOFCI TEST EDIT: only to get a bit one additional test round and some extra coverage with the latest version of everything. |
marc-hb
commented
Nov 20, 2020
OK let's fast-track this, I think it's low-risk and it's blocking a number of next steps. |
marc-hb
commented
Nov 24, 2020
Deduplication submitted in #532, not ready for merge today considering the other changes already merged today but 100% ready for review, thanks! |
While making recent changes to multiple-pipeline-capture.sh I had
vaguely noticed some similarities with multiple-pipeline-playback.sh but
I had naively not realized that they were both an exact copy/paste of
each other except for a couple lines. This commit make -playback catch
up with recent -capture enhancements. It also makes them nearly
identical again which is the first step before (painful) deduplication.
Signed-off-by: Marc Herbert marc.herbert@intel.com