Uh oh!
There was an error while loading. Please reload this page.
multiple-pipeline: replace pidof->ps to catch uninterruptible sleep - #538
Merged
Conversation
Break the strange dependency between how many processes to start and how many were found in the previous run. Also move it next to func_run_pipeline_with_type() to make it clearer it's actually a parameter of that function. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
pidof ignores processes in uninterruptable sleep by default, probably because sending them signals is futile. pidof has a -z option but it's just simpler to use "ps". Also de-duplicate code into new ps_checks() function Fixes: thesofproject#472 Any aplay or arecord process can be in uninterruptable sleep when doing I/O but the easiest way to reproduce is to wait a few seconds and let the DSP go to sleep. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This was referenced Dec 1, 2020
marc-hb
commented
Dec 1, 2020
CollaboratorAuthor
The only way to make sure races are fixed is to make them worse. This is what TEST #537 did. |
marc-hb
commented
Dec 1, 2020
CollaboratorAuthor
marc-hb
marked this pull request as ready for review
December 1, 2020 17:39
marc-hb
commented
Dec 2, 2020
CollaboratorAuthor
Note @keqiaozhang moved uninterruptible sleep to the "normal" state category in commit 180b5d7 |
xiulipan
approved these changes
Dec 2, 2020
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Nice catch, I think we already find the process status issue in
sof-test/tools/sof-process-state.sh
Lines 40 to 41 in 686d273
But the difference of
pidof and ps is really difficult to debug.fredoh9
commented
Dec 2, 2020
Contributor
This is really good catch and fix! Thanks Marc! |
marc-hb
commented
Dec 2, 2020
CollaboratorAuthor
Follow-up commit #543 should save about 20 minutes in nightly tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pidof ignores processes in uninterruptable sleep by default, probably
because sending them signals is futile. pidof has a -z option but it's
just simpler to use "ps".
Also de-duplicate code into new ps_checks() function
Fixes: #472
Any aplay or arecord process can be in uninterruptable sleep when doing
I/O but the easiest way to reproduce is to wait a few seconds and let the
DSP go to sleep.