Skip to content

tools: sof-kernel-log-check: filter out e1000e network error - #620

Closed
fredoh9 wants to merge 1 commit into
thesofproject:mainfrom
fredoh9:fix/ignore_ethernet_error
Closed

tools: sof-kernel-log-check: filter out e1000e network error#620
fredoh9 wants to merge 1 commit into
thesofproject:mainfrom
fredoh9:fix/ignore_ethernet_error

Conversation

@fredoh9

Copy link
Copy Markdown
Contributor

This error was found in CML and TGL devices.
kernel: e1000e 0000:00:1f.6 enp0s31f6: Hardware Error
kernel: e1000e 0000:00:1f.6 eno0: Hardware Error

Signed-off-by: Fred Oh fred.oh@intel.com

@plbossartplbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we abstract the hardware address with the regexp?

Comment threadtools/sof-kernel-log-check.sh Outdated
@fredoh9
fredoh9force-pushed the fix/ignore_ethernet_error branch from 91ae7b8 to ef04259CompareMarch 5, 2021 20:25
@xiulipan
xiulipan marked this pull request as ready for review March 8, 2021 05:41
@xiulipan
xiulipan requested a review from a team as a code ownerMarch 8, 2021 05:41
xiulipan
xiulipan previously approved these changes Mar 8, 2021
@marc-hb

Copy link
Copy Markdown
Collaborator

@fredoh9 we don't need this since disabling built-in Ethernet in the BIOS, correct?

@marc-hb

Copy link
Copy Markdown
Collaborator

Re-open if needed.

@marc-hbmarc-hb closed this Apr 23, 2021
@fredoh9

Copy link
Copy Markdown
ContributorAuthor

This error happens occasionally. Ideally it should not happen as we disable built-in ethernet interface from the BIOS. Number of devices are keep growing and less people to manage all. I will re-open this for the review.

===========================>>
[ 156.271599] kernel: e1000e 0000:00:1f.6 eno1: Hardware Error
<<===========================

@fredoh9

fredoh9 commented May 2, 2023

Copy link
Copy Markdown
ContributorAuthor

looks it matches fine. current filter is

  • e1000e 0000:00:.+..+| en*: Hardware Error

I can slightly change REGEX like this too,

  • e1000e [0-9a-fA-F]{4}:[0-9a-fA-F]{2}:[0-9a-fA-F]{2}.[0-9a-fA-F] en.+: Hardware Error
  • e1000e 0000:00:[0-9a-fA-F]{2}.[0-9a-fA-F] en.+: Hardware Error

@fredoh9
fredoh9force-pushed the fix/ignore_ethernet_error branch from ef04259 to d114bd0CompareMay 2, 2023 18:48
@fredoh9
fredoh9 requested a review from plbossartMay 2, 2023 18:49
@fredoh9

fredoh9 commented May 2, 2023

Copy link
Copy Markdown
ContributorAuthor

Wait a sec, UP Xtreme has two ethernet adapters, looks mostly problem in 1f.6 device. But we need more generic filter like above my suggestion. Will submit a fix shortly.

ubuntu@sh-tglu-up-hda-05:~$ lspci | grep Ethernet
00:1f.6 Ethernet controller: Intel Corporation Ethernet Connection (13) I219-LM (rev 20)
2d:00.0 Ethernet controller: Intel Corporation Ethernet Controller (2) I225-IT (rev 03)
ubuntu@jf-tglu-up-hda-03:~$ lspci | grep Ethernet
00:1f.6 Ethernet controller: Intel Corporation Ethernet Connection (13) I219-LM (rev 20)
02:00.0 Ethernet controller: Intel Corporation Ethernet Controller (2) I225-IT (rev 03)

This error was found in CML and TGL devices.
kernel: e1000e 0000:00:1f.6 enp0s31f6: Hardware Error
kernel: e1000e 0000:00:1f.6 eno0: Hardware Error
Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
@marc-hb

Copy link
Copy Markdown
Collaborator

We can blocklist e1000e with Ansible instead, I just did that manually on sh-tglu-up-hda-05, see #564. No need to mess with BIOS anymore. Also, blocklist means anyone can still modprobe e1000e once if needed.

@marc-hbmarc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocklist

@fredoh9

Copy link
Copy Markdown
ContributorAuthor

blocklist

you mean blacklist?

@marc-hb

Copy link
Copy Markdown
Collaborator

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@fredoh9@marc-hb@plbossart@xiulipan@greg-intel