Skip to content

check-sof-logger: reload drivers first + dma_nudge() workaround - #710

Merged
marc-hb merged 2 commits into
thesofproject:mainfrom
marc-hb:logger-reload
Jun 25, 2021
Merged

check-sof-logger: reload drivers first + dma_nudge() workaround#710
marc-hb merged 2 commits into
thesofproject:mainfrom
marc-hb:logger-reload

Conversation

@marc-hb

Copy link
Copy Markdown
Collaborator

As we look for the FW ABI banner we must start from a clean state

Signed-off-by: Marc Herbert marc.herbert@intel.com

@marc-hb

Copy link
Copy Markdown
CollaboratorAuthor

https://sof-ci.01.org/softestpr/PR710/build741/devicetest/ failed on

@marc-hb
marc-hbforce-pushed the logger-reload branch 2 times, most recently from 36a811e to 08248bbCompareJune 18, 2021 07:03
@marc-hb

Copy link
Copy Markdown
CollaboratorAuthor

TGLH_RVP_HDA error: Unable to open in file /sys/kernel/debug/sof/trace: No such file or directory

Fixed in https://sof-ci.01.org/softestpr/PR710/build743/devicetest/ by adding a delay.

BDW and BYT: empty DMA trace

Unchanged.

@marc-hb

Copy link
Copy Markdown
CollaboratorAuthor

DMA trace stuck again for BDW and BYT in https://sof-ci.01.org/softestpr/PR710/build744/devicetest/, until a "nudge" gets everything out.

@marc-hb

Copy link
Copy Markdown
CollaboratorAuthor

#711 fix should go first

As we look for the FW ABI banner we must start from a clean state
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
See bug thesofproject/sof#4333
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb

Copy link
Copy Markdown
CollaboratorAuthor

In https://sof-ci.01.org/softestpr/PR710/build748/devicetest/ bug thesofproject/sof#4333 is reproduced as usual on BDW and BYT and then worked around by this new check-sof-logger "nudge".

@marc-hb
marc-hb marked this pull request as ready for review June 19, 2021 06:57
@marc-hb
marc-hb requested a review from a team as a code ownerJune 19, 2021 06:57
@marc-hb

Copy link
Copy Markdown
CollaboratorAuthor

Thanks @plbossart !

This has been in review for 7+ days and I tested this quite thoroughly. Will merge tomorrow if no objection by then.

To be clear:

  • The first commit makes failure 4333 more deterministic
  • The second commit "hides" it. The intention is to leave 4333 open until it is fixed (or close as wontfix)

@marc-hb
marc-hb merged commit b0b7c2d into thesofproject:mainJun 25, 2021
@marc-hb
marc-hb deleted the logger-reload branch June 25, 2021 09:00
@marc-hbmarc-hb added the area:logs Log and results collection, storage, etc. label Jul 3, 2021
@marc-hbmarc-hb changed the title check-sof-logger: reload drivers firstcheck-sof-logger: reload drivers first + dma_nudgeSep 15, 2021
@marc-hbmarc-hb changed the title check-sof-logger: reload drivers first + dma_nudgecheck-sof-logger: reload drivers first + dma_nudge() workaroundSep 15, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logsLog and results collection, storage, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-hb@plbossart@aiChaoSONG