opt.sh: catch duplicate --long options

[marc-hb]

As found by Pierre in fix#791

Until #791 is merged it should fail like this:

23:29:31 [ERROR] Duplicate '--loop' option: loop count
23:29:31 [ERROR] Starting func_exit_handler(), exit status=1, FUNCNAME stack:
23:29:31 [ERROR] die() @ ./test-case/../case-lib/lib.sh
23:29:31 [ERROR] _fill_opt_vars() @ sof-test/case-lib/opt.sh:59
23:29:31 [ERROR] func_opt_parse_option() @ sof-test/case-lib/opt.sh:120
23:29:31 [ERROR] main() @ ./test-case/multiple-pause-resume.sh:48

Signed-off-by: Marc Herbert marc.herbert@intel.com

[marc-hb]

multiple-pause-resume.sh fails as expected in https://sof-ci.01.org/softestpr/PR794/build909/devicetest, fixed by #791 to merge before this.

[marc-hb]

The SOF_FW_BOOT_IN_PROGRESS in https://sof-ci.01.org/softestpr/PR794/build909/devicetest/?model=ADLP_RVP_NOCODEC&testcase=check-suspend-resume-5 seems related to thesofproject/linux#3238 - and totally unrelated to this PR.

https://sof-ci.01.org/softestpr/PR794/build909/devicetest/?model=GLK_BOB_DA7219&testcase=check-kmod-load-unload-after-playback has an interesting corruption that is totally unrelated to this PR.

[ 457.727833] kernel: sof-audio-pci-intel-apl 0000:00:0e.0: ipc tx succeeded: 0x30130000: GLB_TPLG_MSG: PIPE_COMPLETE
[ 457.727839] kernel: sof-audio-pci-intel-apl 0000:00:0e.0: ipc tx: 0x40020000: GLB_PM_MSG: CTX_RESTORE
[ 457.728009] kernel: sof-audio-pci-intel-apl 0000:00:0e.0: ipc tx succeeded: 0x40020000: GLB_PM_MSG: CTX_RESTORE
[ 457.797940] kernel: general protection fault, probably for non-canonical address 0xdead0000000000f0: 0000 [#1] SMP PTI
[ 457.797953] kernel: CPU: 1 PID: 10567 Comm: irq/96-da7219-a Not tainted 5.15.0-rc4-daily-default-20211027-0 #37625241
[ 457.797958] kernel: Hardware name: Google Bobba/Bobba, BIOS Google_Bobba.11825.0.2019_03_06_2015 03/06/2019
[ 457.797961] kernel: RIP: 0010:dapm_find_widget+0x71/0xd0 [snd_soc_core]
[ 457.797998] kernel: Code: 00 48 89 e7 e8 a0 92 d6 e3 49 89 e7 48 8b 5d 18 45 31 ed 48 8b 83 00 04 00 00 48 81 c3 00 04 00 00 4c 8d 60 e8 48 39 c3 74 29 <49> 8b 7c 24 08 4c 89 fe e8 22 3d d6 e3 85 c0 75 0a 49 39 6c 24 28
[ 457.798002] kernel: RSP: 0018:ffffa5a940523d80 EFLAGS: 00010202
[ 457.798006] kernel: RAX: dead000000000100 RBX: ffffffffc09c74e0 RCX: 0000000000000000
[ 457.798009] kernel: RDX: 0000000000000063 RSI: ffffffffc0550a4d RDI: ffffa3cf5fe69280
[ 457.798012] kernel: RBP: ffffa3cf42379f68 R08: 0000000000000001 R09: 0000000000000001
[ 457.798014] kernel: R10: ffffa5a940523e38 R11: 0000000000000000 R12: dead0000000000e8
[ 457.798016] kernel: R13: 0000000000000000 R14: 0000000000000001 R15: ffffffffc0550a4d
[ 457.798019] kernel: FS: 0000000000000000(0000) GS:ffffa3cfbbc00000(0000) knlGS:0000000000000000
[ 457.798022] kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 457.798024] kernel: CR2: 00007feb2f567000 CR3: 0000000102004000 CR4: 0000000000350ee0
[ 457.798027] kernel: Call Trace:
[ 457.798033] kernel: ? __mutex_unlock_slowpath+0x40/0x280
[ 457.798041] kernel: ? snd_soc_dapm_disable_pin+0x1e/0x50 [snd_soc_core]
[ 457.798072] kernel: snd_soc_dapm_set_pin+0x18/0x90 [snd_soc_core]
[ 457.798101] kernel: snd_soc_dapm_disable_pin+0x2b/0x50 [snd_soc_core]
[ 457.798128] kernel: da7219_aad_irq_thread+0x24a/0x280 [snd_soc_da7219]
[ 457.798137] kernel: ? irq_thread+0x7e/0x1a0
[ 457.798142] kernel: ? irq_forced_thread_fn+0x70/0x70
[ 457.798145] kernel: irq_thread_fn+0x18/0x60
[ 457.798149] kernel: irq_thread+0xc8/0x1a0
[ 457.798152] kernel: ? __kthread_parkme+0x38/0x90
[ 457.798157] kernel: ? wake_threads_waitq+0x30/0x30
[ 457.798160] kernel: ? irq_thread_dtor+0x80/0x80
[ 457.798164] kernel: kthread+0x141/0x170
[ 457.798168] kernel: ? set_kthread_struct+0x40/0x40
[ 457.798172] kernel: ret_from_fork+0x1f/0x30

[marc-hb]

SOFCI TEST

[marc-hb]

https://sof-ci.01.org/softestpr/PR794/build910/devicetest/?model=CML_RVP_SDW&testcase=check-suspend-resume-with-playback-5 has again the old rtcwake timeout while https://sof-ci.01.org/softestpr/PR794/build910/devicetest/?model=BYT_MB_NOCODEC&testcase=check-alsabat-headset-playback has some usual alsabat failure. Everything else is green.

[greg-intel]

I'm curious why the duplication of an argument occurs. It's not common to have to check that an arg only appears once, so I'm wondering if there's a root cause we can fix?

[marc-hb]

I'm curious why the duplication of an argument occurs.

Because of hasty copy/paste/diverge, already fixed by #791. This one is so it never happens again.