Uh oh!
There was an error while loading. Please reload this page.
lib.sh: disable logging with SOF_LOGGING=none env or missing .ldc - #813
Conversation
Some configurations don't support the logger. Others do but do not want to run it for various reasons. Supersedes thesofproject#811, see earlier discussions there. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
commented
Dec 1, 2021
Need to fix the commit message. |
https://sof-ci.01.org/softestpr/PR813/build934/devicetest has three known and unrelated issues: ADL NTP sync / too fast boot + very recent (5.6) "preemptible" regression thesofproject/linux#3283 + some rtcwake timeout To really test this in CI (in addition to extensive testing locally) I hardcoded |
| # Some firmware/OS configurations do not support logging. | ||
| ldcFile=$(find_ldc_file) || { | ||
| dlogi '.ldc dictionary file not found, SOF logs collection disabled' | ||
| return 0 # 0 is 'true' |
There was a problem hiding this comment.
Not sure this comment is needed, as the script self documents on the line before. Or the comment can be on the line before the function definition, to clarify the outputs.
There was a problem hiding this comment.
You're right, it's overkill. I will remove but only if someone requests some other changes because it does do not much harm either and uses very little real estate.
| fi | ||
| # ... across all tests at once. | ||
| # In the future we should support SOF_LOGGING=etrace (only), see |
There was a problem hiding this comment.
Need more clarification. In future we will support only etrace? why? slogger seems useful to me
fredoh9
left a comment
There was a problem hiding this comment.
In general, I like this idea. logger_disabled() has 3 options to support
- no ldc file in the system
- OPT_VAL['s'] == 0
- $SOF_LOGGING == none
| fi | ||
| # ... across all tests at once. | ||
| # In the future we should support SOF_LOGGING=etrace (only), see |
| # Some firmware/OS configurations do not support logging. | ||
| ldcFile=$(find_ldc_file) || { | ||
| dlogi '.ldc dictionary file not found, SOF logs collection disabled' | ||
| return 0 # 0 is 'true' |
There was a problem hiding this comment.
You're right, it's overkill. I will remove but only if someone requests some other changes because it does do not much harm either and uses very little real estate.
Some configurations don't support the logger. Others do but do not want
to run it for various reasons.
Supersedes #811, see earlier discussions there.
Signed-off-by: Marc Herbert marc.herbert@intel.com