Uh oh!
There was an error while loading. Please reload this page.
verify-sof-firmware-load: fix dmesg.txt collection + better logs + fix -help - #873
Merged
marc-hb merged 2 commits intoMar 3, 2022
Merged
Conversation
Both ktimes and wallclock timestamps are useful but using sometimes the former and other times the latter can make troubleshooting failures more difficult. In this case print both. It is especially useful here considering this test PASSes after unloading the driver. Also update the -help message that was out of date with recent changes and move logs after journalctl status in case of failure. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
setup_kernel_check_point() was causing the collected dmesg.txt to be empty. Replace it with disable_kernel_check_point(). This test makes sense only immediately after boot so for sure we want the full logs since boot. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hbforce-pushed
the
fix-empty-dmesg-in-verify-load
branch
from
March 2, 2022 03:07
46084a8 to
5fabfdaComparemarc-hb
commented
Mar 2, 2022
CollaboratorAuthor
dmesg collected in https://sof-ci.01.org/softestpr/PR873/build1000/devicetest/?model=TGLU_UP_HDA_ZEPHYR&testcase=verify-kernel-boot-log Re-running cause one device was unavailable |
marc-hb
marked this pull request as ready for review
March 2, 2022 03:11
greg-intel
approved these changes
Mar 2, 2022
marc-hb
commented
Mar 2, 2022
CollaboratorAuthor
Thanks @greg-intel All failures in https://sof-ci.01.org/softestpr/PR873/build1001/devicetest/ happened in other tests than this one. dmesg.txt is now collected successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 commits