Skip to content

test-case: check-alsabat.sh: Lower the threshold for detecting tones - #991

Merged
marc-hb merged 1 commit into
thesofproject:mainfrom
singalsu:alsabat_adjust_k_threshold
Mar 13, 2023
Merged

test-case: check-alsabat.sh: Lower the threshold for detecting tones#991
marc-hb merged 1 commit into
thesofproject:mainfrom
singalsu:alsabat_adjust_k_threshold

Conversation

@singalsu

@singalsusingalsu commented Dec 8, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

The default parameter sigma k is 3.0 when omitted from command line. This patch drops the threshold to half with 1.5 to better detect distortion in playback. Alsabat judges spectral components above the threshold as sine frequencies.

This change should increase the probability fail a test to avoid green failures to happen.

Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com

singalsu
singalsu commented Dec 8, 2022
View reviewed changes
Comment threadtest-case/check-alsabat.sh Outdated
@singalsu
singalsuforce-pushed the alsabat_adjust_k_threshold branch 2 times, most recently from afeb0ae to 66417b9CompareDecember 8, 2022 14:58
@singalsusingalsu mentioned this pull request Dec 20, 2022
Merged
marc-hb
marc-hb previously approved these changes Dec 20, 2022
View reviewed changes
@marc-hb

marc-hb commented Dec 20, 2022

Copy link
Copy Markdown
Collaborator

suspend/resume failure in https://sof-ci.01.org/softestpr/PR991/build110/devicetest/index.html is unrelated, other tests are passing.

@singalsu
test-case: check-alsabat.sh: Lower the threshold for detecting tones
4c8a02a
The default parameter sigma k is 3.0 when omitted from command line.
This patch drops the threshold to half with 1.5 to better detect
distortion in playback. Alsabat judges spectral components above the
threshold as sine frequencies.
This change should increase the probability fail a test to avoid
green failures to happen.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@singalsu
singalsuforce-pushed the alsabat_adjust_k_threshold branch from 66417b9 to 4c8a02aCompareDecember 21, 2022 10:43
@singalsu

singalsu commented Dec 21, 2022

Copy link
Copy Markdown
ContributorAuthor

Removed now revert to 997 Hz.

@singalsu
singalsu marked this pull request as ready for review December 21, 2022 16:17
@singalsu
singalsu requested a review from a team as a code ownerDecember 21, 2022 16:17
@singalsu

singalsu commented Dec 21, 2022

Copy link
Copy Markdown
ContributorAuthor

Ready, the two fails look unrelated.

@marc-hb

marc-hb commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator

I don't know whether https://sof-ci.01.org/softestpr/PR991/build119/devicetest/index.html?model=TGLU_UP_HDA_IPC4ZPH&testcase=check-alsabat-headset-playback is related or not but it's in the same test so let's not merge this yet

Also spotted by @plbossart in https://sof-ci.01.org/linuxpr/PR4101/build2529/devicetest/index.html?model=TGLU_UP_HDA_IPC4ZPH&testcase=check-alsabat-headset-playback on a different device of the same model

2022-12-20 13:26:53 UTC [REMOTE_INFO] Run alsa setting for TGLU_UP_HDA_IPC4ZPH 2022-12-20 13:26:53 UTC [REMOTE_WARNING] alsa setting for TGLU_UP_HDA_IPC4ZPH is not available

@keqiaozhang

keqiaozhang commented Dec 23, 2022

Copy link
Copy Markdown
Contributor

I don't know whether https://sof-ci.01.org/softestpr/PR991/build119/devicetest/index.html?model=TGLU_UP_HDA_IPC4ZPH&testcase=check-alsabat-headset-playback is related or not but it's in the same test so let's not merge this yet

It's not related, #992 can fix it.

@keqiaozhangkeqiaozhang mentioned this pull request Dec 23, 2022
Closed
@keqiaozhang

keqiaozhang commented Dec 23, 2022

Copy link
Copy Markdown
Contributor

I tested this PR with #992, the results are as expected:
image

keqiaozhang
keqiaozhang approved these changes Dec 26, 2022
View reviewed changes

@keqiaozhangkeqiaozhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-hb

marc-hb commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

SOFCI TEST

@marc-hb

marc-hb commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

Only suspend/resume failure that this test does not change: merging

@marc-hb
marc-hb merged commit 92fe8a1 into thesofproject:mainMar 13, 2023
@marc-hbmarc-hb mentioned this pull request Mar 13, 2023
Merged
@marc-hb

marc-hb commented Mar 14, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

@fredoh9 confirmed in internal issue 379 that reverting this makes some tests pass/green fail again.

@fredoh9

fredoh9 commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

Not sure why 821 Hz only fails with this fix.
Even last device test results also, check-alsabat.sh failed on both TGL/ADL nocodec mode.
https://sof-ci.01.org/softestpr/PR991/build180/devicetest/index.html

If the change affects the test results directly, let's not merge the change until everything is under control.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-hbmarc-hbAwaiting requested review from marc-hbmarc-hb is a code owner
1 more reviewer
@keqiaozhangkeqiaozhangkeqiaozhang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@singalsu@marc-hb@keqiaozhang@fredoh9